Issues in Bootstrap.php (master) - Issues in master - SerafimArts/Properties - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Bootstrap.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of Properties package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Serafim\Properties;

use Psr\SimpleCache\CacheInterface;
use Serafim\Properties\Attribute\AttributeInterface;

/**
 * Class Bootstrap
 */
final class Bootstrap
{
    /**
     * @var Bootstrap
     */
    private static $instance;

    /**
     * @var CacheInterface
     */
    private $cache;

    /**
     * @var Builder
     */
    private $builder;

    /**
     * @var array|string[]
     */
    private $inheritance = [];

    /**
     * @return Bootstrap
     */
    public static function getInstance(): self
    {
        return self::$instance ?? self::setInstance(new self());
    }

    /**
     * @param self|Bootstrap $instance
     * @return Bootstrap
     */
    public static function setInstance(?self $instance): self
    {
        return self::$instance = $instance;
    }

    /**
     * Bootstrap constructor.
     */
    private function __construct()
    {
        $this->cache = new ArrayCache();
        $this->builder = new Builder();
    }

    /**
     * @return array
     */
    public function getInvocationPosition(): array
    {
        $trace = \debug_backtrace(\DEBUG_BACKTRACE_IGNORE_ARGS)[2] ?? [];

        return [$trace['file'] ?? __FILE__, $trace['line'] ?? __LINE__];
    }

    /**
     * @param null|CacheInterface $cache
     */
    public function setCacheDriver(?CacheInterface $cache): void
    {
        $this->cache = $cache ?? new ArrayCache();
    }

    /**
     * @param string $class
     * @param string $name
     * @return AttributeInterface|null
     * @throws \Psr\SimpleCache\InvalidArgumentException
     */
    public function getAttribute(string $class, string $name): ?AttributeInterface
    {
        foreach ($this->getClassInheritance($class) as $child) {
            $result = $this->getAttributeOrBuild($child, $name, function () use ($child) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                foreach ($this->builder->buildClass($child) as $attribute) {
                    yield $this->getCacheKey($child, $attribute->getName()) => $attribute;
                }
            });

            if ($result) {
                return $result;
            }
        }

        return null;
    }

    /**
     * @param string $class
     * @param string $name
     * @return bool
     * @throws \Psr\SimpleCache\InvalidArgumentException
     */
    public function hasAttribute(string $class, string $name): bool
    {
        return $this->getAttribute($class, $name) !== null;
    }

    /**
     * @param string $class
     * @return iterable|string[]
     */
    private function getClassInheritance(string $class): iterable
    {
        $inheritance = function() use ($class) {
            yield $class;
            yield from \array_keys(\class_parents($class));
            yield from \array_keys(\class_implements($class));
            yield from \array_keys(\class_uses($class));
        };

        if (! isset($this->inheritance[$class])) {
            $this->inheritance[$class] = \iterator_to_array($inheritance(), false);
        }

        return $this->inheritance[$class];
    }

    /**
     * @param string $class
     * @param string $name
     * @param \Closure $build
     * @return null|AttributeInterface
     * @throws \Psr\SimpleCache\InvalidArgumentException
     */
    private function getAttributeOrBuild(string $class, string $name, \Closure $build): ?AttributeInterface
    {
        $key = $this->getCacheKey($class, $name);

        if (! $this->cache->has($key)) {
            foreach ($build() as $inner => $attribute) {
                $this->cache->set($inner, $attribute);
            }
        }

        return $this->cache->get($key);
    }

    /**
     * @param string $class
     * @param string $name
     * @return string
     */
    private function getCacheKey(string $class, string $name): string
    {
        return \hash('md4', \implode(':', [$class, $name]));
    }
}


1			<?php
2			/**
3			* This file is part of Properties package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Serafim\Properties;
11
12			use Psr\SimpleCache\CacheInterface;
13			use Serafim\Properties\Attribute\AttributeInterface;
14
15			/**
16			* Class Bootstrap
17			*/
18			final class Bootstrap
19			{
20			/**
21			* @var Bootstrap
22			*/
23			private static $instance;
24
25			/**
26			* @var CacheInterface
27			*/
28			private $cache;
29
30			/**
31			* @var Builder
32			*/
33			private $builder;
34
35			/**
36			* @var array\|string[]
37			*/
38			private $inheritance = [];
39
40			/**
41			* @return Bootstrap
42			*/
43			public static function getInstance(): self
44			{
45			return self::$instance ?? self::setInstance(new self());
46			}
47
48			/**
49			* @param self\|Bootstrap $instance
50			* @return Bootstrap
51			*/
52			public static function setInstance(?self $instance): self
53			{
54			return self::$instance = $instance;
55			}
56
57			/**
58			* Bootstrap constructor.
59			*/
60			private function __construct()
61			{
62			$this->cache = new ArrayCache();
63			$this->builder = new Builder();
64			}
65
66			/**
67			* @return array
68			*/
69			public function getInvocationPosition(): array
70			{
71			$trace = \debug_backtrace(\DEBUG_BACKTRACE_IGNORE_ARGS)[2] ?? [];
72
73			return [$trace['file'] ?? __FILE__, $trace['line'] ?? __LINE__];
74			}
75
76			/**
77			* @param null\|CacheInterface $cache
78			*/
79			public function setCacheDriver(?CacheInterface $cache): void
80			{
81			$this->cache = $cache ?? new ArrayCache();
82			}
83
84			/**
85			* @param string $class
86			* @param string $name
87			* @return AttributeInterface\|null
88			* @throws \Psr\SimpleCache\InvalidArgumentException
89			*/
90			public function getAttribute(string $class, string $name): ?AttributeInterface
91			{
92			foreach ($this->getClassInheritance($class) as $child) {
93			$result = $this->getAttributeOrBuild($child, $name, function () use ($child) {
			0 ignored issues – show Bug introduced 2018-10-13 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `$this->getAttributeOrBui...> $attribute); } })` (which targets `Serafim\Properties\Boots...::getAttributeOrBuild()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
94			foreach ($this->builder->buildClass($child) as $attribute) {
95			yield $this->getCacheKey($child, $attribute->getName()) => $attribute;
96			}
97			});
98
99			if ($result) {
100			return $result;
101			}
102			}
103
104			return null;
105			}
106
107			/**
108			* @param string $class
109			* @param string $name
110			* @return bool
111			* @throws \Psr\SimpleCache\InvalidArgumentException
112			*/
113			public function hasAttribute(string $class, string $name): bool
114			{
115			return $this->getAttribute($class, $name) !== null;
116			}
117
118			/**
119			* @param string $class
120			* @return iterable\|string[]
121			*/
122			private function getClassInheritance(string $class): iterable
123			{
124			$inheritance = function() use ($class) {
125			yield $class;
126			yield from \array_keys(\class_parents($class));
127			yield from \array_keys(\class_implements($class));
128			yield from \array_keys(\class_uses($class));
129			};
130
131			if (! isset($this->inheritance[$class])) {
132			$this->inheritance[$class] = \iterator_to_array($inheritance(), false);
133			}
134
135			return $this->inheritance[$class];
136			}
137
138			/**
139			* @param string $class
140			* @param string $name
141			* @param \Closure $build
142			* @return null\|AttributeInterface
143			* @throws \Psr\SimpleCache\InvalidArgumentException
144			*/
145			private function getAttributeOrBuild(string $class, string $name, \Closure $build): ?AttributeInterface
146			{
147			$key = $this->getCacheKey($class, $name);
148
149			if (! $this->cache->has($key)) {
150			foreach ($build() as $inner => $attribute) {
151			$this->cache->set($inner, $attribute);
152			}
153			}
154
155			return $this->cache->get($key);
156			}
157
158			/**
159			* @param string $class
160			* @param string $name
161			* @return string
162			*/
163			private function getCacheKey(string $class, string $name): string
164			{
165			return \hash('md4', \implode(':', [$class, $name]));
166			}
167			}
168

SerafimArts / Properties

Issues (19)

Security Analysis no request data

src/Bootstrap.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like