TypeHint - Code Metrics - Inspection of "Add generics support" - SerafimArts/Properties - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b12741...03b4a1 )

by Kirill

created 2018-10-14 22:56 UTC

TypeHint A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
wmc	12
lcom	2
cbo	0
dl	0
loc	97
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getName()	4	1
A	addMatcher()	6	1
B	matchScalar()	21	6
A	match()	4	1
A	isBuiltin()	4	1
A	matchBuiltin()	6	1

<?php
/**
 * This file is part of Properties package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Serafim\Properties\Attribute;

/**
 * Class TypeHint
 */
abstract class TypeHint implements HintInterface
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var Matchable[]
     */
    private $matchers = [];

    /**
     * TypeHint constructor.
     * @param string $name
     */
    public function __construct(string $name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @param Matchable $matcher
     * @return Disjunction
     */
    public function addMatcher(Matchable $matcher): Matchable
    {
        $this->matchers[] = $matcher;

        return $this;
    }

    /**
     * @param string $name
     * @param mixed $value
     * @return bool
     */
    protected function matchScalar(string $name, $value): bool
    {
        switch (true) {
            case $this->isBuiltin($name):
                return $this->matchBuiltin($name, $value);

            case $name === 'mixed':
                return true;

            case $name === 'null':
            case $name === 'void':
                return $value === null;

            case \class_exists($name):
                return $value instanceof $name;

            default:
                @\trigger_error('Unrecognized type-hint "' . $name . '"');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                return true;
        }
    }

    /**
     * @param mixed $value
     * @return bool
     */
    public function match($value): bool
    {
        return $this->matchScalar($this->name, $value);
    }

    /**
     * @param string $name
     * @return bool
     */
    private function isBuiltin(string $name): bool
    {
        return \function_exists('\\is_' . $name);
    }

    /**
     * @param string $name
     * @param mixed $value
     * @return bool
     */
    private function matchBuiltin(string $name, $value): bool
    {
        $function = '\\is_' . $name;

        return $function($value);
    }
}


1			<?php
2			/**
3			* This file is part of Properties package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Serafim\Properties\Attribute;
11
12			/**
13			* Class TypeHint
14			*/
15			abstract class TypeHint implements HintInterface
16			{
17			/**
18			* @var string
19			*/
20			private $name;
21
22			/**
23			* @var Matchable[]
24			*/
25			private $matchers = [];
26
27			/**
28			* TypeHint constructor.
29			* @param string $name
30			*/
31			public function __construct(string $name)
32			{
33			$this->name = $name;
34			}
35
36			/**
37			* @return string
38			*/
39			public function getName(): string
40			{
41			return $this->name;
42			}
43
44			/**
45			* @param Matchable $matcher
46			* @return Disjunction
47			*/
48			public function addMatcher(Matchable $matcher): Matchable
49			{
50			$this->matchers[] = $matcher;
51
52			return $this;
53			}
54
55			/**
56			* @param string $name
57			* @param mixed $value
58			* @return bool
59			*/
60			protected function matchScalar(string $name, $value): bool
61			{
62			switch (true) {
63			case $this->isBuiltin($name):
64			return $this->matchBuiltin($name, $value);
65
66			case $name === 'mixed':
67			return true;
68
69			case $name === 'null':
70			case $name === 'void':
71			return $value === null;
72
73			case \class_exists($name):
74			return $value instanceof $name;
75
76			default:
77			@\trigger_error('Unrecognized type-hint "' . $name . '"');
			0 ignored issues – show Security Best Practice introduced 2018-10-13 17:03 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
78			return true;
79			}
80			}
81
82			/**
83			* @param mixed $value
84			* @return bool
85			*/
86			public function match($value): bool
87			{
88			return $this->matchScalar($this->name, $value);
89			}
90
91			/**
92			* @param string $name
93			* @return bool
94			*/
95			private function isBuiltin(string $name): bool
96			{
97			return \function_exists('\\is_' . $name);
98			}
99
100			/**
101			* @param string $name
102			* @param mixed $value
103			* @return bool
104			*/
105			private function matchBuiltin(string $name, $value): bool
106			{
107			$function = '\\is_' . $name;
108
109			return $function($value);
110			}
111			}
112

SerafimArts / Properties

Push — master ( b12741...03b4a1 )

TypeHint A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like