Serafim\Properties\Reducers\TypeHint\GenericReducer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	0	4	1
A	reduce()	0	13	2

<?php
/**
 * This file is part of Properties package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Serafim\Properties\Reducers\TypeHint;

use Railt\Parser\Ast\RuleInterface;
use Serafim\Properties\Attribute\GenericTypeHint;
use Serafim\Properties\Attribute\Matchable;
use Serafim\Properties\Attribute\TypeHint;
use Serafim\Properties\Reducers\ReducerInterface;

/**
 * Class GenericReducer
 */
class GenericReducer implements ReducerInterface
{
    /**
     * @param RuleInterface $rule
     * @return bool
     */
    public function match(RuleInterface $rule): bool
    {
        return $rule->getName() === 'Generic';
    }

    /**
     * @param RuleInterface $rule
     * @return \Generator|Matchable
     */
    public function reduce(RuleInterface $rule): \Generator
    {
        /** @var string $name */
        $name = yield $rule->first('Type');

        $keyValue = [];

        foreach ($rule->first('GenericArguments') as $argument) {

The expression $rule->first('GenericArguments') of type null|object<Railt\Parser\Ast\NodeInterface> is not guaranteed to be traversable. How about adding an additional type check?

            $keyValue[] = yield $argument;
        }

        return new GenericTypeHint($name, ...$keyValue);

$keyValue is of type array, but the function expects a null|object<Serafim\Properties\Attribute\Matchable>.

    }
}