Omnipay\Heidelpay\Message\CreateBasketRequest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	0	22	3
A	getItemsData()	0	18	2
A	getTaxAmount()	0	4	1
A	setTaxAmount()	0	4	1
A	getDiscount()	0	4	1
A	setDiscount()	0	4	1
A	getEndpoint()	0	4	1

<?php


namespace Omnipay\Heidelpay\Message;

use Omnipay\Common\Item;

class CreateBasketRequest extends AbstractRequest
{
    /**
     * @return array
     * @throws \Omnipay\Common\Exception\InvalidRequestException
     */
    public function getData()
    {
        $this->validate('transactionId', 'currency', 'items', 'amount');

        $data = [
            'amountTotalGross' => $this->getAmountInteger() / 100,
            'currencyCode' => $this->getCurrency(),
            'orderId' => $this->getTransactionId(),
            'note' => $this->getDescription(),
            'basketItems' => $this->getItemsData()
        ];

        if ($this->getTaxAmount()) {
            $data['amountTotalVat'] = $this->getTaxAmount();
        }

        if ($this->getDiscount()) {
            $data['amountTotalDiscount'] = $this->getDiscount();
        }

        return $data;
    }

    /**
     * @return array
     */
    public function getItemsData()
    {
        $data = [];

        /** @var Item $item */
        foreach ($this->getItems() as $item) {

The expression $this->getItems() of type object<Omnipay\Common\ItemBag>|null is not guaranteed to be traversable. How about adding an additional type check?

            $data[] = [
                'basketItemReferenceId' => uniqid(),
                'quantity' => $item->getQuantity(),
                'amountPerUnit' => $item->getPrice(),
                'amountGross' => $item->getPrice() * $item->getQuantity(),
                'title' => $item->getName(),
                'subTitle' => $item->getDescription()
            ];
        }

        return $data;
    }


    /**
     * @return string
     */
    public function getTaxAmount()
    {
        return $this->getParameter('tax_amount');
    }

    /**
     * @param $value
     * @return CreateBasketRequest
     */
    public function setTaxAmount($value)
    {
        return $this->setParameter('tax_amount', $value);
    }

    /**
     * @return string
     */
    public function getDiscount()
    {
        return $this->getParameter('discount');
    }

    /**
     * @param $value
     * @return CreateBasketRequest
     */
    public function setDiscount($value)
    {
        return $this->setParameter('discount', $value);
    }

    /**
     * @return string
     */
    public function getEndpoint()
    {
        return parent::getEndpoint().'baskets';
    }
}