ValueObject::compare() - Code Metrics - Inspection of "Create sorting for ValueObject" - SenseException/intl-sort - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( db3d0f...fd00a0 )

by Claudio

created 2020-05-08 21:41 UTC

ValueObject::compare() A

↳ Parent: ValueObject

Complexity

Conditions	3
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	16
ccs	9
cts	9
cp	1
rs	9.9666
cc	3
nc	4
nop	2
crap	3

<?php

declare(strict_types=1);

namespace Budgegeria\IntlSort\Comparator;

use Budgegeria\IntlSort\Exception\IntlSortException;
use Collator;

class ValueObject implements Comparable
{
    /**
     * @var Collator
     */
    private $collator;

    /**
     * @var string
     */
    private $methodOrPropertyName;

    /**
     * @var bool
     */
    private $isProperty;

    public function __construct(Collator $collator, string $name, bool $isProperty)
    {
        $this->collator = $collator;
        $this->methodOrPropertyName = $name;
        $this->isProperty = $isProperty;
    }

    /**
     * {@inheritDoc}
     */
    public function compare($value, $comparativeValue): int
    {
        try {
            $compared = $this->collator->compare(
                $this->callAccessor($value),
                $this->callAccessor($comparativeValue)
            );

            if ($this->collator->getErrorCode() !== 0) {
                throw IntlSortException::errorOnSort($this->collator->getErrorMessage());
            }
        } catch (\IntlException $e) {
            throw IntlSortException::errorOnSort($e->getMessage());
        }

        return $compared;
    }

    private function callAccessor(object $valueObject) : string
    {
        if ($this->isProperty) {
            return (string) $valueObject->{$this->methodOrPropertyName};
        }

        return (string) $valueObject->{$this->methodOrPropertyName}();
    }
}

1		<?php
2
3		declare(strict_types=1);
4
5		namespace Budgegeria\IntlSort\Comparator;
6
7		use Budgegeria\IntlSort\Exception\IntlSortException;
8		use Collator;
9
10		class ValueObject implements Comparable
11		{
12		/**
13		* @var Collator
14		*/
15		private $collator;
16
17		/**
18		* @var string
19		*/
20		private $methodOrPropertyName;
21
22		/**
23		* @var bool
24		*/
25		private $isProperty;
26
27	26	public function __construct(Collator $collator, string $name, bool $isProperty)
28		{
29	26	$this->collator = $collator;
30	26	$this->methodOrPropertyName = $name;
31	26	$this->isProperty = $isProperty;
32	26	}
33
34		/**
35		* {@inheritDoc}
36		*/
37	24	public function compare($value, $comparativeValue): int
38		{
39		try {
40	24	$compared = $this->collator->compare(
41	24	$this->callAccessor($value),
42	24	$this->callAccessor($comparativeValue)
43		);
44
45	22	if ($this->collator->getErrorCode() !== 0) {
46	22	throw IntlSortException::errorOnSort($this->collator->getErrorMessage());
47		}
48	4	} catch (\IntlException $e) {
49	2	throw IntlSortException::errorOnSort($e->getMessage());
50		}
51
52	20	return $compared;
53		}
54
55	24	private function callAccessor(object $valueObject) : string
56		{
57	24	if ($this->isProperty) {
58	12	return (string) $valueObject->{$this->methodOrPropertyName};
59		}
60
61	12	return (string) $valueObject->{$this->methodOrPropertyName}();
62		}
63		}

SenseException / intl-sort

Push — master ( db3d0f...fd00a0 )

ValueObject::compare() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like