Collator::compare() - Code Metrics - Inspection of "Add special sort for null values" - SenseException/intl-sort - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 938fb4...cfa6a0 )

by Claudio

created 2021-08-17 20:00 UTC

Collator::compare() B

↳ Parent: Collator

Complexity

Conditions	7
Paths	3

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	7

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	7
eloc	7
nc	3
nop	2
dl	0
loc	15
ccs	8
cts	8
cp	1
crap	7
rs	8.8333
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Budgegeria\IntlSort;

use Collator as IntlCollector;

use function assert;
use function is_int;

class Collator extends IntlCollector
{
    public const NULL_VALUES_FIRST = 1;
    public const NULL_VALUES_LAST  = 2;

    /** @var int|null */
    private $nullableSort;

    public function setNullableSort(?int $value): void
    {
        $this->nullableSort = $value;
    }

    /**
     * @param mixed $value
     * @param mixed $comparativeValue
     */
    public function compare($value, $comparativeValue): int
    {
        if ($this->nullableSort === self::NULL_VALUES_LAST && ($comparativeValue === null || $value === null)) {
            return $comparativeValue <=> $value;
        }

        if ($this->nullableSort === self::NULL_VALUES_FIRST && ($comparativeValue === null || $value === null)) {
            return 1;
        }

        $result = parent::compare((string) $value, (string) $comparativeValue);

        assert(is_int($result));

        return $result;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Budgegeria\IntlSort;
6
7		use Collator as IntlCollector;
8
9		use function assert;
10		use function is_int;
11
12		class Collator extends IntlCollector
13		{
14		public const NULL_VALUES_FIRST = 1;
15		public const NULL_VALUES_LAST = 2;
16
17		/** @var int\|null */
18		private $nullableSort;
19
20	3	public function setNullableSort(?int $value): void
21		{
22	3	$this->nullableSort = $value;
23	3	}
24
25		/**
26		* @param mixed $value
27		* @param mixed $comparativeValue
28		*/
29	54	public function compare($value, $comparativeValue): int
30		{
31	54	if ($this->nullableSort === self::NULL_VALUES_LAST && ($comparativeValue === null \|\| $value === null)) {
32	1	return $comparativeValue <=> $value;
33		}
34
35	54	if ($this->nullableSort === self::NULL_VALUES_FIRST && ($comparativeValue === null \|\| $value === null)) {
36	2	return 1;
37		}
38
39	54	$result = parent::compare((string) $value, (string) $comparativeValue);
40
41	54	assert(is_int($result));
42
43	54	return $result;
44		}
45		}
46

SenseException / intl-sort

Push — master ( 938fb4...cfa6a0 )

Collator::compare() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like