OptionsTest::initProvider() - Code Metrics - SemanticMediaWiki/SummaryCards - Measure and Improve Code Quality continuously with Scrutinizer

OptionsTest::initProvider() A
last analyzed 2021-02-09 14:15 UTC

↳ Parent: OptionsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	28
rs	9.472
c	0
b	0
f	0

<?php

namespace SUC\Tests;

use SUC\Options;

/**
 * @covers \SUC\Options
 * @group summary-cards
 *
 * @license GNU GPL v2+
 * @since   1.0
 *
 * @author mwjames
 */
class OptionsTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$this->assertInstanceOf(
			'\SUC\Options',
			new Options()
		);
	}

	public function testAddOption() {

		$instance = new Options();

		$this->assertFalse(
			$instance->has( 'Foo' )
		);

		$instance->set( 'Foo', 42 );

		$this->assertEquals(
			42,
			$instance->get( 'Foo' )
		);
	}

	/**
	 * @dataProvider initProvider
	 */
	public function testInit( $name ) {

		$instance = Options::newFromGlobals();

		$this->assertTrue(
			$instance->has( $name )
		);
	}

	public function testUnregisteredKeyThrowsException() {

		$instance = new Options();

		$this->setExpectedException( 'InvalidArgumentException' );
		$instance->get( 'Foo' );
	}

	public function initProvider() {

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'tooltipRequestCacheTTL'
		);

		$provider[] = array(
			'cachePrefix'
		);

		$provider[] = array(
			'enabledNamespaceWithTemplate'
		);

		$provider[] = array(
			'enabledForAnonUsers'
		);

		$provider[] = array(
			'backendParserCacheLifetime'
		);

		$provider[] = array(
			'backendParserCacheType'
		);

		return $provider;
	}

}


1			<?php
2
3			namespace SUC\Tests;
4
5			use SUC\Options;
6
7			/**
8			* @covers \SUC\Options
9			* @group summary-cards
10			*
11			* @license GNU GPL v2+
12			* @since 1.0
13			*
14			* @author mwjames
15			*/
16			class OptionsTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$this->assertInstanceOf(
21			'\SUC\Options',
22			new Options()
23			);
24			}
25
26			public function testAddOption() {
27
28			$instance = new Options();
29
30			$this->assertFalse(
31			$instance->has( 'Foo' )
32			);
33
34			$instance->set( 'Foo', 42 );
35
36			$this->assertEquals(
37			42,
38			$instance->get( 'Foo' )
39			);
40			}
41
42			/**
43			* @dataProvider initProvider
44			*/
45			public function testInit( $name ) {
46
47			$instance = Options::newFromGlobals();
48
49			$this->assertTrue(
50			$instance->has( $name )
51			);
52			}
53
54			public function testUnregisteredKeyThrowsException() {
55
56			$instance = new Options();
57
58			$this->setExpectedException( 'InvalidArgumentException' );
59			$instance->get( 'Foo' );
60			}
61
62			public function initProvider() {
63
64			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-07 13:25 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
65			'tooltipRequestCacheTTL'
66			);
67
68			$provider[] = array(
69			'cachePrefix'
70			);
71
72			$provider[] = array(
73			'enabledNamespaceWithTemplate'
74			);
75
76			$provider[] = array(
77			'enabledForAnonUsers'
78			);
79
80			$provider[] = array(
81			'backendParserCacheLifetime'
82			);
83
84			$provider[] = array(
85			'backendParserCacheType'
86			);
87
88			return $provider;
89			}
90
91			}
92

SemanticMediaWiki / SummaryCards

OptionsTest::initProvider() A last analyzed 2021-02-09 14:15 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

OptionsTest::initProvider() A
last analyzed 2021-02-09 14:15 UTC