Issues in SemanticWatchlist.hooks.php (master) - Issues in master - SemanticMediaWiki/SemanticWatchlist - Measure and Improve Code Quality continuously with Scrutinizer

Issues (34)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

SemanticWatchlist.hooks.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Static class for hooks handled by the Semantic Watchlist extension.
 *
 * @since 0.1
 *
 * @file SemanticWatchlist.hooks.php
 * @ingroup SemanticWatchlist
 *
 * @licence GNU GPL v3+
 * @author Jeroen De Dauw < [email protected] >
 */
final class SWLHooks {

    /**
     * Handle the updateDataBefore hook of SMW >1.6, which gets called
     * every time the value of a propery changes somewhere.
     *
     * @since 0.1
     *
     * @param SMWStore $store
     * @param SMWChangeSet $changes
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return true
     */
	public static function onDataUpdate( SMWStore $store, SMWSemanticData $newData ) {
		$subject = $newData->getSubject();
		$oldData = $store->getSemanticData( $subject );
		$title = Title::makeTitle( $subject->getNamespace(), $subject->getDBkey() );

		$groups = SWLGroups::getMatchingWatchGroups( $title );

		$edit = false;

		foreach ( $groups as /* SWLGroup */ $group ) {
			$changeSet = SWLChangeSet::newFromSemanticData( $oldData, $newData, $group->getProperties() );

			if ( $changeSet->hasUserDefinedProperties() ) {
				if ( $edit === false ) {
					$edit = new SWLEdit(
						$title->getArticleID(),
						$GLOBALS['wgUser']->getName(),
						wfTimestampNow()
					);

					$edit->writeToDB();
				}

				$changeSet->setEdit( $edit );
				$setId = $changeSet->writeToStore( $groups, $edit->getId() );

				if ( $setId != 0 ) {
					$group->notifyWatchingUsers( $changeSet );
				}
			}
		}

		return true;
	}

    /**
     * Handles group notification.
     *
     * @since 0.1
     *
     * @param SWLGroup $group
     * @param array $userIDs
     * @param SMWChangeSet $changes
     *
     * @return true
     */
    public static function onGroupNotify( SWLGroup $group, array $userIDs, SWLChangeSet $changes ) {
    	global $egSWLMailPerChange, $egSWLMaxMails;

    	foreach ( $userIDs as $userID ) {
    		$user = User::newFromId( $userID );

    		if ( $user->getOption( 'swl_email', false ) ) {
				if ( $user->getName() != $changes->getEdit()->getUser()->getName() || $GLOBALS['egSWLEnableSelfNotify'] ) {
					if ( !method_exists( 'Sanitizer', 'validateEmail' ) || Sanitizer::validateEmail( $user->getEmail() ) ) {
						$lastNotify = $user->getOption( 'swl_last_notify' );
						$lastWatch = $user->getOption( 'swl_last_watch' );

						if ( is_null( $lastNotify ) || is_null( $lastWatch ) || $lastNotify < $lastWatch ) {
							$mailCount = $user->getOption( 'swl_mail_count', 0 );

							if ( $egSWLMailPerChange || $mailCount < $egSWLMaxMails ) {
								SWLEmailer::notifyUser( $group, $user, $changes, $egSWLMailPerChange );
								$user->setOption( 'swl_last_notify', wfTimestampNow() );
								$user->setOption( 'swl_mail_count', $mailCount + 1 );
								$user->saveSettings();
							}
						}
					}
				}
    		}
    	}

        return true;
    }

	/**
	 * Adds a link to Admin Links page.
	 *
	 * @since 0.1
	 *
	 * @return true
	 */
	public static function addToAdminLinks( &$admin_links_tree ) {
	    $displaying_data_section = $admin_links_tree->getSection( wfMessage( 'adminlinks_browsesearch' )->text() );

	    // Escape if SMW hasn't added links.
	    if ( is_null( $displaying_data_section ) ) return true;
	    $smw_docu_row = $displaying_data_section->getRow( 'smw' );

	    $smw_docu_row->addItem( AlItem::newFromSpecialPage( 'WatchlistConditions' ) );

	    return true;
	}

}


1			<?php
2
3			/**
4			* Static class for hooks handled by the Semantic Watchlist extension.
5			*
6			* @since 0.1
7			*
8			* @file SemanticWatchlist.hooks.php
9			* @ingroup SemanticWatchlist
10			*
11			* @licence GNU GPL v3+
12			* @author Jeroen De Dauw < [email protected] >
13			*/
14			final class SWLHooks {
15
16			/**
17			* Handle the updateDataBefore hook of SMW >1.6, which gets called
18			* every time the value of a propery changes somewhere.
19			*
20			* @since 0.1
21			*
22			* @param SMWStore $store
23			* @param SMWChangeSet $changes
			0 ignored issues – show Bug introduced 2015-12-04 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$changes`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
24			*
25			* @return true
26			*/
27			public static function onDataUpdate( SMWStore $store, SMWSemanticData $newData ) {
28			$subject = $newData->getSubject();
29			$oldData = $store->getSemanticData( $subject );
30			$title = Title::makeTitle( $subject->getNamespace(), $subject->getDBkey() );
31
32			$groups = SWLGroups::getMatchingWatchGroups( $title );
33
34			$edit = false;
35
36			foreach ( $groups as /* SWLGroup */ $group ) {
37			$changeSet = SWLChangeSet::newFromSemanticData( $oldData, $newData, $group->getProperties() );
38
39			if ( $changeSet->hasUserDefinedProperties() ) {
40			if ( $edit === false ) {
41			$edit = new SWLEdit(
42			$title->getArticleID(),
43			$GLOBALS['wgUser']->getName(),
44			wfTimestampNow()
45			);
46
47			$edit->writeToDB();
48			}
49
50			$changeSet->setEdit( $edit );
51			$setId = $changeSet->writeToStore( $groups, $edit->getId() );
52
53			if ( $setId != 0 ) {
54			$group->notifyWatchingUsers( $changeSet );
55			}
56			}
57			}
58
59			return true;
60			}
61
62			/**
63			* Handles group notification.
64			*
65			* @since 0.1
66			*
67			* @param SWLGroup $group
68			* @param array $userIDs
69			* @param SMWChangeSet $changes
70			*
71			* @return true
72			*/
73			public static function onGroupNotify( SWLGroup $group, array $userIDs, SWLChangeSet $changes ) {
74			global $egSWLMailPerChange, $egSWLMaxMails;
75
76			foreach ( $userIDs as $userID ) {
77			$user = User::newFromId( $userID );
78
79			if ( $user->getOption( 'swl_email', false ) ) {
80			if ( $user->getName() != $changes->getEdit()->getUser()->getName() \|\| $GLOBALS['egSWLEnableSelfNotify'] ) {
81			if ( !method_exists( 'Sanitizer', 'validateEmail' ) \|\| Sanitizer::validateEmail( $user->getEmail() ) ) {
82			$lastNotify = $user->getOption( 'swl_last_notify' );
83			$lastWatch = $user->getOption( 'swl_last_watch' );
84
85			if ( is_null( $lastNotify ) \|\| is_null( $lastWatch ) \|\| $lastNotify < $lastWatch ) {
86			$mailCount = $user->getOption( 'swl_mail_count', 0 );
87
88			if ( $egSWLMailPerChange \|\| $mailCount < $egSWLMaxMails ) {
89			SWLEmailer::notifyUser( $group, $user, $changes, $egSWLMailPerChange );
90			$user->setOption( 'swl_last_notify', wfTimestampNow() );
91			$user->setOption( 'swl_mail_count', $mailCount + 1 );
92			$user->saveSettings();
93			}
94			}
95			}
96			}
97			}
98			}
99
100			return true;
101			}
102
103			/**
104			* Adds a link to Admin Links page.
105			*
106			* @since 0.1
107			*
108			* @return true
109			*/
110			public static function addToAdminLinks( &$admin_links_tree ) {
111			$displaying_data_section = $admin_links_tree->getSection( wfMessage( 'adminlinks_browsesearch' )->text() );
112
113			// Escape if SMW hasn't added links.
114			if ( is_null( $displaying_data_section ) ) return true;
115			$smw_docu_row = $displaying_data_section->getRow( 'smw' );
116
117			$smw_docu_row->addItem( AlItem::newFromSpecialPage( 'WatchlistConditions' ) );
118
119			return true;
120			}
121
122			}
123

SemanticMediaWiki / SemanticWatchlist

Issues (34)

Security Analysis no request data

SemanticWatchlist.hooks.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like