Issues in UserAccountDataChecker.php (master) - Issues in master - SemanticMediaWiki/SemanticSignup - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/UserAccountDataChecker.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SES;

use User;
use Sanitizer;
use Exception;

/**
 * @license GNU GPL v3+
 * @since 1.0
 *
 * @author Serhii Kutnii
 */
class UserAccountDataChecker extends DataChecker {

	public $mUsername = '';
	public $mPassword = '';
	public $mEmail = '';
	public $mRealname = '';
	public $mDomain = '';
	public $mLanguage = '';
	public $mRemember = false;
	public $mUser = null;

	public function __construct() {
		$that = $this;
		$this->addCheck( array( &$that, 'checkDomainValidity' ), array() );
		$this->addCheck( array( &$that, 'checkDomainUser' ), array() );
		$this->addCheck( array( &$that, 'checkCreatePermissions' ), array() );
		$this->addCheck( array( &$that, 'checkSorbs' ), array() );
		$this->addCheck( array( &$that, 'checkUserExists' ), array() );
		$this->addCheck( array( &$that, 'checkPasswordLength' ), array() );
		$this->addCheck( array( &$that, 'checkEmailValidity' ), array() );
	}

	// Checks

	public function checkDomainValidity() {
		global $wgAuth;

		if ( !$wgAuth->validDomain( $this->mDomain ) )
			$this->error( wfMessage( 'wrongpassword' )->text() );
	}

	public function checkDomainUser() {
		global $wgAuth;

		if ( ( 'local' != $this->mDomain ) && ( '' != $this->mDomain )
			&& !$wgAuth->canCreateAccounts() && ( !$wgAuth->userExists( $this->mName ) || !$wgAuth->authenticate( $this->mName, $this->mPassword ) ) )
class MyClass { }

$x = new MyClass();
$x->foo = true;
				$this->error( wfMessage( 'wrongpassword' )->text() );
	}

	public function checkCreatePermissions() {
		global $wgUser;

		if ( !$wgUser->isAllowed( 'createaccount' ) || $wgUser->isBlockedFromCreateAccount() )
			$this->error( wfMessage( 'ses-createforbidden' )->text() );
	}

	public function checkSorbs() {
		global $wgProxyWhitelist;
		global $wgEnableSorbs, $wgRequest;
		$ip = $wgRequest->getIP();
		if ( $wgEnableSorbs && !in_array( $ip, $wgProxyWhitelist ) &&
		  $wgUser->inSorbsBlacklist( $ip ) )

		 	$this->error( wfMessage( 'sorbs_create_account_reason' )->text() );
	}

	public function checkUserExists() {
		if ( $this->mUser->idForName() )
			$this->error( wfMessage( 'ses-userexists' )->text() );
	}

	public function checkPasswordLength() {
		if ( !$this->mUser->isValidPassword( $this->mPassword ) )
		{
			global $wgMinimalPasswordLength;
			$this->error( wfMessage( 'passwordtooshort' )->numParams( $wgMinimalPasswordLength )->text() );
		}
	}

	public function checkEmailValidity() {
		global $wgEnableEmail;
		if ( $wgEnableEmail && $this->mEmail !== '' && !Sanitizer::validateEmail( $this->mEmail ) ) {
			$this->error( wfMessage( 'invalidemailaddress' )->text() );
		}
	}

	protected function populateData() {
		$this->mUsername = $this->getUserDataValue( 'wpName', 'nousername' );
		$name = trim( $this->mUsername );
		$this->mUser = User::newFromName( $name, 'creatable' );
		if ( !$this->mUser ) {
			$this->error( wfMessage( 'ses-noname' )->text() );
		}

		global $sesRealNameRequired;
		$this->mRealname = $this->getUserDataValue( 'wpRealName', $sesRealNameRequired ? 'norealname' : null );

		$this->mPassword = $this->getUserDataValue( 'wpPassword' );
		$retype = $this->getUserDataValue( 'wpRetype' );
		if ( strcmp( $this->mPassword, $retype ) )
			$this->error( wfMessage( 'ses-nopwdmatch' )->text() );

		$this->mDomain = $this->getUserDataValue( 'wpDomain' );

		global $wgEmailConfirmToEdit;
		$this->mEmail = $this->getUserDataValue( 'wpEmail', $wgEmailConfirmToEdit ? 'noemailtitle' : null );

		$this->mLanguage = $this->getUserDataValue( 'uselang' );

		global $wgRequest;
		$this->mRemember = $wgRequest->getCheck( 'wpRemember' );
	}

}


1		<?php
2
3		namespace SES;
4
5		use User;
6		use Sanitizer;
7		use Exception;
8
9		/**
10		* @license GNU GPL v3+
11		* @since 1.0
12		*
13		* @author Serhii Kutnii
14		*/
15		class UserAccountDataChecker extends DataChecker {
16
17		public $mUsername = '';
18		public $mPassword = '';
19		public $mEmail = '';
20		public $mRealname = '';
21		public $mDomain = '';
22		public $mLanguage = '';
23		public $mRemember = false;
24		public $mUser = null;
25
26	1	public function __construct() {
27	1	$that = $this;
28	1	$this->addCheck( array( &$that, 'checkDomainValidity' ), array() );
29	1	$this->addCheck( array( &$that, 'checkDomainUser' ), array() );
30	1	$this->addCheck( array( &$that, 'checkCreatePermissions' ), array() );
31	1	$this->addCheck( array( &$that, 'checkSorbs' ), array() );
32	1	$this->addCheck( array( &$that, 'checkUserExists' ), array() );
33	1	$this->addCheck( array( &$that, 'checkPasswordLength' ), array() );
34	1	$this->addCheck( array( &$that, 'checkEmailValidity' ), array() );
35		}
36
37		// Checks
38
39		public function checkDomainValidity() {
40		global $wgAuth;
41
42		if ( !$wgAuth->validDomain( $this->mDomain ) )
43		$this->error( wfMessage( 'wrongpassword' )->text() );
44		}
45
46		public function checkDomainUser() {
47		global $wgAuth;
48
49		if ( ( 'local' != $this->mDomain ) && ( '' != $this->mDomain )
50		&& !$wgAuth->canCreateAccounts() && ( !$wgAuth->userExists( $this->mName ) \|\| !$wgAuth->authenticate( $this->mName, $this->mPassword ) ) )
		0 ignored issues – show Bug introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mName` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51		$this->error( wfMessage( 'wrongpassword' )->text() );
52		}
53
54		public function checkCreatePermissions() {
55		global $wgUser;
56
57		if ( !$wgUser->isAllowed( 'createaccount' ) \|\| $wgUser->isBlockedFromCreateAccount() )
58		$this->error( wfMessage( 'ses-createforbidden' )->text() );
59		}
60
61		public function checkSorbs() {
62		global $wgProxyWhitelist;
63		global $wgEnableSorbs, $wgRequest;
64		$ip = $wgRequest->getIP();
65		if ( $wgEnableSorbs && !in_array( $ip, $wgProxyWhitelist ) &&
66		$wgUser->inSorbsBlacklist( $ip ) )
		0 ignored issues – show Bug introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$wgUser` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
67		$this->error( wfMessage( 'sorbs_create_account_reason' )->text() );
68		}
69
70		public function checkUserExists() {
71		if ( $this->mUser->idForName() )
72		$this->error( wfMessage( 'ses-userexists' )->text() );
73		}
74
75		public function checkPasswordLength() {
76		if ( !$this->mUser->isValidPassword( $this->mPassword ) )
77		{
78		global $wgMinimalPasswordLength;
79		$this->error( wfMessage( 'passwordtooshort' )->numParams( $wgMinimalPasswordLength )->text() );
80		}
81		}
82
83		public function checkEmailValidity() {
84		global $wgEnableEmail;
85		if ( $wgEnableEmail && $this->mEmail !== '' && !Sanitizer::validateEmail( $this->mEmail ) ) {
86		$this->error( wfMessage( 'invalidemailaddress' )->text() );
87		}
88		}
89
90		protected function populateData() {
91		$this->mUsername = $this->getUserDataValue( 'wpName', 'nousername' );
92		$name = trim( $this->mUsername );
93		$this->mUser = User::newFromName( $name, 'creatable' );
94		if ( !$this->mUser ) {
95		$this->error( wfMessage( 'ses-noname' )->text() );
96		}
97
98		global $sesRealNameRequired;
99		$this->mRealname = $this->getUserDataValue( 'wpRealName', $sesRealNameRequired ? 'norealname' : null );
100
101		$this->mPassword = $this->getUserDataValue( 'wpPassword' );
102		$retype = $this->getUserDataValue( 'wpRetype' );
103		if ( strcmp( $this->mPassword, $retype ) )
104		$this->error( wfMessage( 'ses-nopwdmatch' )->text() );
105
106		$this->mDomain = $this->getUserDataValue( 'wpDomain' );
107
108		global $wgEmailConfirmToEdit;
109		$this->mEmail = $this->getUserDataValue( 'wpEmail', $wgEmailConfirmToEdit ? 'noemailtitle' : null );
110
111		$this->mLanguage = $this->getUserDataValue( 'uselang' );
112
113		global $wgRequest;
114		$this->mRemember = $wgRequest->getCheck( 'wpRemember' );
115		}
116
117		}
118

SemanticMediaWiki / SemanticSignup

Issues (21)

Security Analysis no request data

src/UserAccountDataChecker.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like