Issues in SignupFieldsParserFunction.php (master) - Issues in master - SemanticMediaWiki/SemanticSignup - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SignupFieldsParserFunction.php (2 issues)

Labels

Bug 2

Severity

mwjames 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SES;

use Parser;

/**
 * @license GNU GPL v3+
 * @since 1.0
 *
 * @author Serhii Kutnii
 */
class SignupFieldsParserFunction {

	/**
	 * @var UserFieldsCreateTemplate
	 */
	private $userFieldsCreateTemplate;

	/**
	 * @since 1.0
	 *
	 * @param UserFieldsCreateTemplate $userFieldsTemplate
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 */
	public function __construct( UserFieldsCreateTemplate $userFieldsCreateTemplate ) {
		$this->userFieldsCreateTemplate = $userFieldsCreateTemplate;
	}

	/**
	 * @since 1.0
	 *
	 * @param array $arguments
	 */
	public function parse( $arguments ) {

		$parser = array_shift( $arguments );

		$text = $parser instanceOf Parser && $parser->getTitle() !== null ? $this->createUserFieldsTemplateFields() : '';


		return array(
			$text,
			'noparse' => true,
			'isHTML' => true
		);
	}

	private function createUserFieldsTemplateFields() {
		global $wgEnableEmail, $wgHiddenPrefs, $wgEmailConfirmToEdit, $wgAuth, $wgUser, $wgLoginLanguageSelector;

		// Deprecated $wgAllowRealName https://www.mediawiki.org/wiki/Manual:$wgAllowRealName
		$allowRealName = true;
		if ( in_array( 'realname', $wgHiddenPrefs ) ) {
			$allowRealName = false;
		}

		$this->userFieldsCreateTemplate->set( 'link', '' ); // TODO
		$this->userFieldsCreateTemplate->set( 'email', '' ); // TODO
		$this->userFieldsCreateTemplate->set( 'createemail', $wgEnableEmail && $wgUser->isLoggedIn() );
		$this->userFieldsCreateTemplate->set( 'userealname', $allowRealName );
		$this->userFieldsCreateTemplate->set( 'useemail', $wgEnableEmail );
		$this->userFieldsCreateTemplate->set( 'emailrequired', $wgEmailConfirmToEdit );
		$this->userFieldsCreateTemplate->set( 'canreset', $wgAuth->allowPasswordChange() );
		// $this->userFieldsCreateTemplate->set( 'remember', $wgUser->getOption( 'rememberpassword' )  );

		# Prepare language selection links as needed

		// FIXME
		//
		// Plain incorrect, makeLanguageSelector is not part of this class
		// see LoginForm::makeLanguageSelector
		// if ( $wgLoginLanguageSelector ) {
		//	$this->userFieldsCreateTemplate->set( 'languages', $this->makeLanguageSelector() ); // FIXME: $this is not accessible in a static context
		// }

		// Give authentication and captcha plugins a chance to modify the form
		$type = 'signup';
		$wgAuth->modifyUITemplate( $this->userFieldsCreateTemplate, $type );

		if( Settings::get( 'useCaptcha' ) && isset( $GLOBALS['wgCaptchaClass'] ) ) {
			$captchaObject = new $GLOBALS['wgCaptchaClass'];
			$captchaObject->injectUserCreate( $this->userFieldsCreateTemplate );
		}

		ob_start();
		$this->userFieldsCreateTemplate->execute();
		$text = ob_get_clean();

		return $text;
	}

}


1		<?php
2
3		namespace SES;
4
5		use Parser;
6
7		/**
8		* @license GNU GPL v3+
9		* @since 1.0
10		*
11		* @author Serhii Kutnii
12		*/
13		class SignupFieldsParserFunction {
14
15		/**
16		* @var UserFieldsCreateTemplate
17		*/
18		private $userFieldsCreateTemplate;
19
20		/**
21		* @since 1.0
22		*
23		* @param UserFieldsCreateTemplate $userFieldsTemplate
		0 ignored issues – show Bug introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$userFieldsTemplate`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
24		*/
25	2	public function __construct( UserFieldsCreateTemplate $userFieldsCreateTemplate ) {
26	2	$this->userFieldsCreateTemplate = $userFieldsCreateTemplate;
27	2	}
28
29		/**
30		* @since 1.0
31		*
32		* @param array $arguments
33		*/
34	1	public function parse( $arguments ) {
35
36	1	$parser = array_shift( $arguments );
37
38	1	$text = $parser instanceOf Parser && $parser->getTitle() !== null ? $this->createUserFieldsTemplateFields() : '';
		0 ignored issues – show Bug introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Parser` does not exist. Is this class maybe located in a folder that is not analyzed, or in a newer version of your dependencies than listed in your composer.lock/composer.json? Loading history...
39
40		return array(
41	1	$text,
42	1	'noparse' => true,
43		'isHTML' => true
44	1	);
45		}
46
47		private function createUserFieldsTemplateFields() {
48		global $wgEnableEmail, $wgHiddenPrefs, $wgEmailConfirmToEdit, $wgAuth, $wgUser, $wgLoginLanguageSelector;
49
50		// Deprecated $wgAllowRealName https://www.mediawiki.org/wiki/Manual:$wgAllowRealName
51		$allowRealName = true;
52		if ( in_array( 'realname', $wgHiddenPrefs ) ) {
53		$allowRealName = false;
54		}
55
56		$this->userFieldsCreateTemplate->set( 'link', '' ); // TODO
57		$this->userFieldsCreateTemplate->set( 'email', '' ); // TODO
58		$this->userFieldsCreateTemplate->set( 'createemail', $wgEnableEmail && $wgUser->isLoggedIn() );
59		$this->userFieldsCreateTemplate->set( 'userealname', $allowRealName );
60		$this->userFieldsCreateTemplate->set( 'useemail', $wgEnableEmail );
61		$this->userFieldsCreateTemplate->set( 'emailrequired', $wgEmailConfirmToEdit );
62		$this->userFieldsCreateTemplate->set( 'canreset', $wgAuth->allowPasswordChange() );
63		// $this->userFieldsCreateTemplate->set( 'remember', $wgUser->getOption( 'rememberpassword' ) );
64
65		# Prepare language selection links as needed
66
67		// FIXME
68		//
69		// Plain incorrect, makeLanguageSelector is not part of this class
70		// see LoginForm::makeLanguageSelector
71		// if ( $wgLoginLanguageSelector ) {
72		// $this->userFieldsCreateTemplate->set( 'languages', $this->makeLanguageSelector() ); // FIXME: $this is not accessible in a static context
73		// }
74
75		// Give authentication and captcha plugins a chance to modify the form
76		$type = 'signup';
77		$wgAuth->modifyUITemplate( $this->userFieldsCreateTemplate, $type );
78
79		if( Settings::get( 'useCaptcha' ) && isset( $GLOBALS['wgCaptchaClass'] ) ) {
80		$captchaObject = new $GLOBALS['wgCaptchaClass'];
81		$captchaObject->injectUserCreate( $this->userFieldsCreateTemplate );
82		}
83
84		ob_start();
85		$this->userFieldsCreateTemplate->execute();
86		$text = ob_get_clean();
87
88		return $text;
89		}
90
91		}
92

SemanticMediaWiki / SemanticSignup

Issues (21)

Security Analysis no request data

src/SignupFieldsParserFunction.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like