Issues (166)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

formats/tree/TreeNode.php (3 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

namespace SRF\Formats\Tree;
use Cdb\Exception;
use Tree\Node\Node;
use Tree\Node\NodeInterface;
use Tree\Node\NodeTrait;
class TreeNode extends Node {
	 * SRFTreeElement constructor.
	 * @param \SMWResultArray[] | null $row
17 5
	public function __construct( $row = null ) {
18 5
		parent::__construct( $row );
19 5
	 * @return string
24 5
	public function getHash() {
26 5
		$resultSubject = $this->getResultSubject();
28 5
		if ( $resultSubject !== null ) {
29 5
			return $resultSubject->getSerialization();
32 5
		return '';
	 * @return null|\SMWDIWikiPage
38 5
	public function getResultSubject() {
		/** @var \SMWResultArray[] | null $row */
40 5
		$row = $this->getValue();
42 5
		if ( $row !== null ) {
43 5
			return $row[0]->getResultSubject();
46 5
		return null;
	 * @param NodeInterface $child
	 * @return NodeTrait
0 ignored issues
Comprehensibility Bug introduced by Stephan Gambke
The return type NodeTrait is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting?

In PHP traits cannot be used for type-hinting as they do not define a well-defined structure. This is because any class that uses a trait can rename that trait’s methods.

If you would like to return an object that has a guaranteed set of methods, you could create a companion interface that lists these methods explicitly.

Loading history...
	 * @throws Exception
55 5
	public function addChild( NodeInterface $child ) {
57 5
		foreach ( $this->getAncestorsAndSelf() as $ancestor ) {
58 5
			if ( $ancestor->getHash() === $child->getHash() ) {
0 ignored issues
It seems like you code against a concrete implementation and not the interface Tree\Node\NodeInterface as the method getHash() does only exist in the following implementations of said interface: SRF\Formats\Tree\TreeNode.

Let’s take a look at an example:

interface User
    /** @return string */
    public function getPassword();

class MyUser implements User
    public function getPassword()
        // return something

    public function getDisplayName()
        // return some name.

class AuthSystem
    public function authenticate(User $user)
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
        public function authenticate(MyUser $user) { /* ... */ }
  2. Add an additional type-check:

    class AuthSystem
        public function authenticate(User $user)
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
        /** @return string */
        public function getPassword();
        /** @return string */
        public function getDisplayName();
Loading history...
59 1
				throw new Exception( 'srf-tree-circledetected' );
63 5
		return parent::addChild( $child );
0 ignored issues
Bug Best Practice introduced by Stephan Gambke
The return type of return parent::addChild($child); (SRF\Formats\Tree\TreeNode) is incompatible with the return type of the parent method Tree\Node\Node::addChild of type Tree\Node\NodeTrait.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;

    public function getName() {
        return $this->name;

abstract class Post {
    public function getAuthor() {
        return 'Johannes';

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...