MathFormats - Code Metrics - Inspection of "adding statistical result formats" - SemanticMediaWiki/SemanticResultFormats - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#604)

unknown

created 2020-07-31 09:21 UTC

MathFormats A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	257
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

12.83%

Importance

Changes

Metric	Value
wmc	36
lcom	1
cbo	0
dl	0
loc	257
ccs	14
cts	109
cp	0.1283
rs	9.52
c	0
b	0
f	0

19 Methods

Rating	Name	Size	Complexity
A	max_function()	5	1
A	min_function()	5	1
A	sum_function()	5	1
A	pruduct_function()	5	1
A	average_function()	5	1
A	median_function()	8	1
A	variance_function()	13	2
A	samplevariance_function()	13	2
A	standarddeviation_function()	13	2
A	samplestandarddeviation_function()	13	2
A	range_function()	4	1
A	quartillower_inc_function()	17	2
A	quartilupper_inc_function()	17	2
A	quartillower_exc_function()	17	2
A	quartilupper_exc_function()	17	2
A	interquartilerange_inc_function()	4	1
A	interquartilerange_exc_function()	4	1
A	mode_function()	29	5
B	interquartilemean_function()	42	6

<?php

/**
 * Various mathematical functions - sum, product, average, min and max.
 *
 * @licence GNU GPL v3+
 *
 * @author Jeroen De Dauw < [email protected] >
 * @author Yaron Koren
 * @author Nathan Yergler
 */

class MathFormats
{
	public static function max_function(array $numbers)
	{
		// result
		return max($numbers);
	}

	public static function min_function(array $numbers)
	{
		// result
		return min($numbers);
	}

	public static function sum_function(array $numbers)
	{
		// result
		return array_sum($numbers);
	}

	public static function pruduct_function(array $numbers)
	{
		// result
		return array_product($numbers);
	}

	public static function average_function(array $numbers)
	{
		// result
		return array_sum($numbers) / count($numbers);
	}

	public static function median_function(array $numbers)
	{
		sort( $numbers, SORT_NUMERIC );
		// get position
		$position = (count($numbers) + 1 ) / 2 - 1;
		// result
		return ( $numbers[ceil($position)] + $numbers[floor($position)]) / 2;
	}

	public static function variance_function(array $numbers)
	{
		// average
		$average = MathFormats::average_function($numbers);
		// space
		$space = NULL;
		for($i = 0; $i < count($numbers); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$space += pow($numbers[$i], 2);
		}
		// result
		return ($space / count($numbers) - pow($average, 2));
	}

	public static function samplevariance_function(array $numbers)
	{
		// average
		$average = MathFormats::average_function($numbers);
		// space
		$space = NULL;
		for($i = 0; $i < count($numbers); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$space += pow(($numbers[$i] - $average), 2);
		}
		// result
		return ($space / (count($numbers) - 1));
	}

	public static function standarddeviation_function(array $numbers)
	{
		// average
		$average = MathFormats::average_function($numbers);
		// space
		$space = NULL;
		for($i = 0; $i < count($numbers); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$space += pow(($numbers[$i] - $average), 2);
		}
		// result
		return sqrt($space / (count($numbers) - 1));
	}

	public static function samplestandarddeviation_function(array $numbers)
	{
		// average
		$average = MathFormats::average_function($numbers);
		// space
		$space = NULL;
		for($i = 0; $i < count($numbers); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$space += pow($numbers[$i], 2);
		}
		// result
		return sqrt($space / count($numbers) - pow($average, 2));
	}

	public static function range_function(array $numbers)
	{
		return (max($numbers) - min($numbers));
	}

	public static function quartillower_inc_function(array $numbers)
	{
		sort($numbers, SORT_NUMERIC);
		// get position
		$Q1_position = ((sizeof($numbers) - 1) * 0.25);
		// check if position is between two numbers
		if(is_float($Q1_position) == TRUE)

		{
			$Q1_position_y = floor($Q1_position);
			$Q1_position_x = ceil($Q1_position);
			return ($numbers[$Q1_position_y] + ($numbers[$Q1_position_x] - $numbers[$Q1_position_y]) * 0.25);
		}
		else
		{
			return $numbers[$Q1_position];
		}
	}

	public static function quartilupper_inc_function(array $numbers)
	{
		sort($numbers, SORT_NUMERIC);
		// get position
		$Q3_position = ((sizeof($numbers) - 1) * 0.75);
		// check if position is between two numbers
		if(is_float($Q3_position) == TRUE)

		{
			$Q3_position_y = floor($Q3_position);
			$Q3_position_x = ceil($Q3_position);
			return ($numbers[$Q3_position_y] + ($numbers[$Q3_position_x] - $numbers[$Q3_position_y]) * 0.75);
		}
		else
		{
			return $numbers[$Q3_position];
		}
	}

	public static function quartillower_exc_function(array $numbers)
	{
		sort($numbers, SORT_NUMERIC);
		// get position
		$Q1_position = ((sizeof($numbers) + 1) * 0.25);
		// check if position is between two numbers
		if(is_float($Q1_position) == TRUE)

		{
			$Q1_position_y = floor($Q1_position)-1;
			$Q1_position_x = ceil($Q1_position)-1;
			return ($numbers[$Q1_position_y] + ($numbers[$Q1_position_x] - $numbers[$Q1_position_y]) * 0.75);
		}
		else
		{
			return $numbers[$Q1_position];
		}
	}

	public static function quartilupper_exc_function(array $numbers)
	{
		sort($numbers, SORT_NUMERIC);
		// get position
		$Q3_position = ((sizeof($numbers) + 1) * 0.75);
		// check if position is between two numbers
		if(is_float($Q3_position) == TRUE)

		{
			$Q3_position_y = floor($Q3_position)-1;
			$Q3_position_x = ceil($Q3_position)-1;
			return ($numbers[$Q3_position_y] + ($numbers[$Q3_position_x] - $numbers[$Q3_position_y]) * 0.25);
		}
		else
		{
			return $numbers[$Q3_position];
		}
	}

	public static function interquartilerange_inc_function(array $numbers)
	{
		return MathFormats::quartilupper_inc_function($numbers) - MathFormats::quartillower_inc_function($numbers);
	}

	public static function interquartilerange_exc_function(array $numbers)
	{
		return MathFormats::quartilupper_exc_function($numbers) - MathFormats::quartillower_exc_function($numbers);
	}

	public static function mode_function(array $numbers)
	{
		// array temp
		$array_temp = array();
		// convert array
		for($i = 0; $i < sizeof($numbers); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$converted_value = strval($numbers[$i]);
			$array_temp += [$i => $converted_value];
		}
		$array_counted_values = array_count_values($array_temp);
		// max
		$max = max($array_counted_values);
		// count
		$count = NULL;
		// filter
		for($i = 0; $i < sizeof($array_counted_values); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			if ($array_counted_values[array_keys($array_counted_values)[$i]] == $max)
			{
				$count += 1;
			}
		}
		// check if there are more than one max
		if($count == 1)
		{
			return $max;
		}
	}

	public static function interquartilemean_function(array $numbers)
	{
		// sort numbers
		sort($numbers,SORT_NUMERIC);
		// check if size of numbers is divisble by 4
		if(sizeof($numbers)%4 == 0)
		{
			// split array into 4 groups (2D array)
			$array_split = (array_chunk($numbers, sizeof($numbers)/4));
			// creating store_string
			$store_string = NULL;
			for($i = 0; $i < sizeof($array_split[1]); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
			{
				$store_string += $array_split[1][$i];
			}
			for($i = 0; $i < sizeof($array_split[2]); $i++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
			{
				$store_string += $array_split[2][$i];
			}
			return $store_string/(sizeof($array_split[1])+sizeof($array_split[2]));
		}
		else
		{
			// get positon of split
			$position = sizeof($numbers)/4;
			// remove values out of split
			for($i = 0; $i < floor($position); $i++)
			{
				unset($numbers[$i]);
				array_pop($numbers);
			}
			// reset array keys
			$store_array = array_merge($numbers);
			// add values
			$store_values = NULL;
			for($i = 1; $i < sizeof($store_array)-1; $i++)
			{
				$store_values += $store_array[$i];
			}
			return ($store_values + ((ceil($position) - $position) * ($store_array[0] + $store_array[sizeof($store_array)-1]))) / ($position*2);
		}
	}
}

class SRFMath extends SMWResultPrinter {

	/**
	 * (non-PHPdoc)
	 * @see SMWResultPrinter::getName()
	 */
	public function getName() {
		// Give grep a chance to find the usages:
		// srf_printername_max, srf_printername_min, srf_printername_sum,
		// srf_printername_product, srf_printername_average, srf_printername_median
		return wfMessage( 'srf_printername_' . $this->mFormat )->text();
	}

	/**
	 * @see SMWResultPrinter::buildResult
	 *
	 * @since 1.8
	 *
	 * @param SMWQueryResult $results
	 *
	 * @return string
	 */
	protected function buildResult( SMWQueryResult $results ) {

		$number = $this->getResultText( $results, SMW_OUTPUT_HTML );

		if ( count( $results->getPrintRequests() ) > 1 ) {
			$outputformat = $results->getPrintRequests()[1]->getOutputFormat();
		} else {
			// no mainlabel
			$outputformat = $results->getPrintRequests()[0]->getOutputFormat();
		}

		// if raw-format ("-") than skip formatNum()
		if ( $outputformat != "-" ) {
			$dataValue = \SMW\DataValueFactory::getInstance()->newDataValueByType( '_num' );
			$number = $dataValue->getLocalizedFormattedNumber( $number );
		}

		return (string)$number;
	}

	/**
	 * @see SMWResultPrinter::getResultText()
	 */
	protected function getResultText( SMWQueryResult $res, $outputmode ) {
		$numbers = $this->getNumbers( $res );

		if ( count( $numbers ) == 0 ) {
			return $this->params['default'];
		}

		switch ( $this->mFormat ) {
			case 'max':
				return MathFormats::max_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'min':
				return MathFormats::min_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'sum':
				return MathFormats::sum_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'product':
				return MathFormats::pruduct_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'average':
				return MathFormats::average_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'median':
				return MathFormats::median_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'variance':
				return MathFormats::variance_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'samplevariance':
				return MathFormats::samplevariance_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'samplestandarddeviation':
				return MathFormats::samplestandarddeviation_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'standarddeviation':
				return MathFormats::standarddeviation_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'range':
				return MathFormats::range_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'quartillower':
				return MathFormats::quartillower_inc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'quartilupper';
				return MathFormats::quartilupper_inc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'quartillower.exc';
				return MathFormats::quartillower_exc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'quartilupper.exc';
				return MathFormats::quartilupper_exc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'interquartilerange':
				return MathFormats::interquartilerange_inc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'interquartilerange.exc';
				return MathFormats::interquartilerange_exc_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'mode';
				return MathFormats::mode_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'interquartilemean';
				return MathFormats::interquartilemean_function($numbers);
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}
	}

	/**
	 * @param SMWQueryResult $res
	 *
	 * @return float[]
	 */
	private function getNumbers( SMWQueryResult $res ) {
		$numbers = [];

		while ( $row = $res->getNext() ) {
			foreach ( $row as $resultArray ) {
				foreach ( $resultArray->getContent() as $dataItem ) {
					self::addNumbersForDataItem( $dataItem, $numbers );
				}
			}
		}

		return $numbers;
	}

	/**
	 * @param SMWDataItem $dataItem
	 * @param float[] $numbers
	 */
	private function addNumbersForDataItem( SMWDataItem $dataItem, array &$numbers ) {
		switch ( $dataItem->getDIType() ) {
			case SMWDataItem::TYPE_NUMBER:
				$numbers[] = $dataItem->getNumber();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
				break;
			case SMWDataItem::TYPE_CONTAINER:
				foreach ( $dataItem->getDataItems() as $di ) {

					self::addNumbersForDataItem( $di, $numbers );
				}
				break;
			default:
		}
	}

}


1		<?php
2
3		/**
4		* Various mathematical functions - sum, product, average, min and max.
5		*
6		* @licence GNU GPL v3+
7		*
8		* @author Jeroen De Dauw < [email protected] >
9		* @author Yaron Koren
10		* @author Nathan Yergler
11		*/
12
13		class MathFormats
14		{
15	1	public static function max_function(array $numbers)
16		{
17		// result
18	1	return max($numbers);
19		}
20
21	1	public static function min_function(array $numbers)
22		{
23		// result
24	1	return min($numbers);
25		}
26
27	1	public static function sum_function(array $numbers)
28		{
29		// result
30	1	return array_sum($numbers);
31		}
32
33	1	public static function pruduct_function(array $numbers)
34		{
35		// result
36	1	return array_product($numbers);
37		}
38
39	1	public static function average_function(array $numbers)
40		{

SemanticMediaWiki / SemanticResultFormats

Pull Request — master (#604)

MathFormats A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

19 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like