Issues in NotificationGroupValueTest.php (master) - Issues in master - SemanticMediaWiki/SemanticNotifications - Measure and Improve Code Quality continuously with Scrutinizer

Issues (49)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Unit/DataValues/NotificationGroupValueTest.php (13 issues)

Labels

Documentation 13

Severity

Minor 13

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\Notifications\Tests;

use SMW\Notifications\DataValues\NotificationGroupValue;
use SMW\Notifications\PropertyRegistry;
use SMW\DataValueFactory;
use SMW\DIWikiPage;
use SMW\DIProperty;
use SMWDIBlob as DIBlob;
use SMW\Tests\TestEnvironment;

/**
 * @covers \SMW\Notifications\DataValues\NotificationGroupValue
 * @group semantic-notifications
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class NotificationGroupValueTest extends \PHPUnit_Framework_TestCase {

	private $store;
	private $testEnvironment;
	private $dataValueFactory;

	protected function setUp() {

		$this->store = $this->getMockBuilder( '\SMW\Store' )
			->disableOriginalConstructor()
			->getMockForAbstractClass();

		$this->testEnvironment = new TestEnvironment();
		$this->testEnvironment->registerObject( 'Store', $this->store );
		$this->dataValueFactory = DataValueFactory::getInstance();
	}

	protected function tearDown() {
		$this->testEnvironment->tearDown();
	}

	public function testCanConstruct() {

		$this->assertInstanceOf(
			NotificationGroupValue::class,
			new NotificationGroupValue( '' )
		);
	}

	public function testSpecialGroup() {

		$this->assertSame(
			'entity specification change group',
			NotificationGroupValue::getSpecialGroupName( 'en' )
		);
	}

	public function testTryToSetUserValueOnMissingContext() {

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
		$instance->setUserValue( 'Foo' );

		$this->assertSame(
			'Foo',
			$instance->getWikiValue()
		);
	}

	public function testTryToSetUserValueOnMissingUserContext() {

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$instance->setContextPage(
			DIWikiPage::newFromText( __METHOD__ )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$instance->setUserValue( 'Foo' );

		$this->assertSame(
			'error',
			$instance->getWikiValue()
		);
	}

	public function testSetUserValueWithSpecialGroup() {

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
		$instance->setUserValue( NotificationGroupValue::getSpecialGroupName( 'en' ) );

		$this->assertSame(
			NotificationGroupValue::getSpecialGroupName( 'en' ),
			$instance->getWikiValue()
		);
	}

	public function testSetUserValueWithValidUserContext() {

		$property = new DIProperty(
			PropertyRegistry::NOTIFICATIONS_TO_GROUP
		);

		$this->store->expects( $this->once() )
			->method( 'getPropertySubjects' )
			->with(
				$this->equalTo( $property ),
				$this->anything() )
			->will( $this->returnValue( array( 'OnlyCompareWhetherItIsAvailableOrNot' ) ) );

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$instance->setContextPage(
			DIWikiPage::newFromText( __METHOD__, NS_USER )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$instance->setUserValue( 'Foo' );

		$this->assertSame(
			'Foo',
			$instance->getWikiValue()
		);
	}

	public function testTryToSetUserValueOnUnknownGroup() {

		$property = new DIProperty(
			PropertyRegistry::NOTIFICATIONS_TO_GROUP
		);

		$this->store->expects( $this->once() )
			->method( 'getPropertySubjects' )
			->with(
				$this->equalTo( $property ),
				$this->anything() )
			->will( $this->returnValue( array() ) );

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$instance->setContextPage(
			DIWikiPage::newFromText( __METHOD__, NS_USER )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$instance->setUserValue( 'Foo' );

		$this->assertSame(
			'error',
			$instance->getWikiValue()
		);
	}

	public function testSetUserValueWithValidUserContextAndNotNullLinker() {

		$this->store->expects( $this->once() )
			->method( 'getPropertySubjects' )
			->will( $this->returnValue( array( 'WasMentionedAsGroup' ) ) );

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$instance->setContextPage(
			DIWikiPage::newFromText( __METHOD__, NS_USER )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$instance->setUserValue( 'Foo bar' );
		$instance->setCaption( false );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$this->assertContains(
			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
			$instance->getShortWikiText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
			$instance->getLongWikiText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			'value=Foo+bar',
			$instance->getShortHTMLText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			'value=Foo+bar',
			$instance->getLongHTMLText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);
	}

	public function testSetDataItem() {

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$instance->setDataItem(
			new DIBlob( 'Foo' )
		);

		$this->assertContains(
			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
			$instance->getShortWikiText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
			$instance->getLongWikiText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			'value=Foo',
			$instance->getShortHTMLText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertContains(
			'value=Foo',
			$instance->getLongHTMLText( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);
	}

	public function testEmptyDataValue() {

		$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );

		$this->assertEmpty(
			'',
			$instance->getShortWikiText()
		);

		$this->assertEmpty(
			'',
			$instance->getShortHTMLText()
		);
	}

}


1			<?php
2
3			namespace SMW\Notifications\Tests;
4
5			use SMW\Notifications\DataValues\NotificationGroupValue;
6			use SMW\Notifications\PropertyRegistry;
7			use SMW\DataValueFactory;
8			use SMW\DIWikiPage;
9			use SMW\DIProperty;
10			use SMWDIBlob as DIBlob;
11			use SMW\Tests\TestEnvironment;
12
13			/**
14			* @covers \SMW\Notifications\DataValues\NotificationGroupValue
15			* @group semantic-notifications
16			*
17			* @license GNU GPL v2+
18			* @since 1.0
19			*
20			* @author mwjames
21			*/
22			class NotificationGroupValueTest extends \PHPUnit_Framework_TestCase {
23
24			private $store;
25			private $testEnvironment;
26			private $dataValueFactory;
27
28			protected function setUp() {
29
30			$this->store = $this->getMockBuilder( '\SMW\Store' )
31			->disableOriginalConstructor()
32			->getMockForAbstractClass();
33
34			$this->testEnvironment = new TestEnvironment();
35			$this->testEnvironment->registerObject( 'Store', $this->store );
36			$this->dataValueFactory = DataValueFactory::getInstance();
37			}
38
39			protected function tearDown() {
40			$this->testEnvironment->tearDown();
41			}
42
43			public function testCanConstruct() {
44
45			$this->assertInstanceOf(
46			NotificationGroupValue::class,
47			new NotificationGroupValue( '' )
48			);
49			}
50
51			public function testSpecialGroup() {
52
53			$this->assertSame(
54			'entity specification change group',
55			NotificationGroupValue::getSpecialGroupName( 'en' )
56			);
57			}
58
59			public function testTryToSetUserValueOnMissingContext() {
60
61			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
62			$instance->setUserValue( 'Foo' );
63
64			$this->assertSame(
65			'Foo',
66			$instance->getWikiValue()
67			);
68			}
69
70			public function testTryToSetUserValueOnMissingUserContext() {
71
72			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
73
74			$instance->setContextPage(
75			DIWikiPage::newFromText( __METHOD__ )
			0 ignored issues – show Documentation introduced 2016-06-19 04:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\SMW\DIWikiPage::newFromText(__METHOD__)` is of type `object<SMW\DIWikiPage>`, but the function expects a `null\|object<SMWDIWikiPage>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76			);
77
78			$instance->setUserValue( 'Foo' );
79
80			$this->assertSame(
81			'error',
82			$instance->getWikiValue()
83			);
84			}
85
86			public function testSetUserValueWithSpecialGroup() {
87
88			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
89			$instance->setUserValue( NotificationGroupValue::getSpecialGroupName( 'en' ) );
90
91			$this->assertSame(
92			NotificationGroupValue::getSpecialGroupName( 'en' ),
93			$instance->getWikiValue()
94			);
95			}
96
97			public function testSetUserValueWithValidUserContext() {
98
99			$property = new DIProperty(
100			PropertyRegistry::NOTIFICATIONS_TO_GROUP
101			);
102
103			$this->store->expects( $this->once() )
104			->method( 'getPropertySubjects' )
105			->with(
106			$this->equalTo( $property ),
107			$this->anything() )
108			->will( $this->returnValue( array( 'OnlyCompareWhetherItIsAvailableOrNot' ) ) );
109
110			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
111
112			$instance->setContextPage(
113			DIWikiPage::newFromText( __METHOD__, NS_USER )
			0 ignored issues – show Documentation introduced 2016-06-19 04:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\SMW\DIWikiPage::newFromText(__METHOD__, NS_USER)` is of type `object<SMW\DIWikiPage>`, but the function expects a `null\|object<SMWDIWikiPage>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114			);
115
116			$instance->setUserValue( 'Foo' );
117
118			$this->assertSame(
119			'Foo',
120			$instance->getWikiValue()
121			);
122			}
123
124			public function testTryToSetUserValueOnUnknownGroup() {
125
126			$property = new DIProperty(
127			PropertyRegistry::NOTIFICATIONS_TO_GROUP
128			);
129
130			$this->store->expects( $this->once() )
131			->method( 'getPropertySubjects' )
132			->with(
133			$this->equalTo( $property ),
134			$this->anything() )
135			->will( $this->returnValue( array() ) );
136
137			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
138
139			$instance->setContextPage(
140			DIWikiPage::newFromText( __METHOD__, NS_USER )
			0 ignored issues – show Documentation introduced 2016-06-19 04:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\SMW\DIWikiPage::newFromText(__METHOD__, NS_USER)` is of type `object<SMW\DIWikiPage>`, but the function expects a `null\|object<SMWDIWikiPage>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
141			);
142
143			$instance->setUserValue( 'Foo' );
144
145			$this->assertSame(
146			'error',
147			$instance->getWikiValue()
148			);
149			}
150
151			public function testSetUserValueWithValidUserContextAndNotNullLinker() {
152
153			$this->store->expects( $this->once() )
154			->method( 'getPropertySubjects' )
155			->will( $this->returnValue( array( 'WasMentionedAsGroup' ) ) );
156
157			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
158
159			$instance->setContextPage(
160			DIWikiPage::newFromText( __METHOD__, NS_USER )
			0 ignored issues – show Documentation introduced 2016-06-19 04:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\SMW\DIWikiPage::newFromText(__METHOD__, NS_USER)` is of type `object<SMW\DIWikiPage>`, but the function expects a `null\|object<SMWDIWikiPage>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
161			);
162
163			$instance->setUserValue( 'Foo bar' );
164			$instance->setCaption( false );
			0 ignored issues – show Documentation introduced 2016-06-19 04:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
165
166			$this->assertContains(
167			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
168			$instance->getShortWikiText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
169			);
170
171			$this->assertContains(
172			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo%20bar',
173			$instance->getLongWikiText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
174			);
175
176			$this->assertContains(
177			'value=Foo+bar',
178			$instance->getShortHTMLText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
179			);
180
181			$this->assertContains(
182			'value=Foo+bar',
183			$instance->getLongHTMLText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
184			);
185			}
186
187			public function testSetDataItem() {
188
189			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
190
191			$instance->setDataItem(
192			new DIBlob( 'Foo' )
193			);
194
195			$this->assertContains(
196			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
197			$instance->getShortWikiText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
198			);
199
200			$this->assertContains(
201			SMW_NOTIFICATIONS_TO_GROUP . '/' . 'Foo',
202			$instance->getLongWikiText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
203			);
204
205			$this->assertContains(
206			'value=Foo',
207			$instance->getShortHTMLText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
208			);
209
210			$this->assertContains(
211			'value=Foo',
212			$instance->getLongHTMLText( '' )
			0 ignored issues – show Documentation introduced 2019-04-25 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `''` is of type `string`, but the function expects a `object<Linker>\|null\|boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
213			);
214			}
215
216			public function testEmptyDataValue() {
217
218			$instance = $this->dataValueFactory->newDataValueByType( NotificationGroupValue::TYPE_ID );
219
220			$this->assertEmpty(
221			'',
222			$instance->getShortWikiText()
223			);
224
225			$this->assertEmpty(
226			'',
227			$instance->getShortHTMLText()
228			);
229			}
230
231			}
232

SemanticMediaWiki / SemanticNotifications

Issues (49)

Security Analysis no request data

Unit/DataValues/NotificationGroupValueTest.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like