ChangeNotificationFilter - Code Metrics - Inspection of "Add ChangeNotificationDetectionPropertyExemptionLi..." - SemanticMediaWiki/SemanticNotifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by mw

created 2016-11-19 03:22 UTC

ChangeNotificationFilter B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	341
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

96.09%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	43
lcom	1
cbo	8
dl	0
loc	341
rs	8.3157
c	1
b	0
f	0
ccs	123
cts	128
cp	0.9609

13 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	setAgent()	3	1
A	setPropertyExemptionList()	5	1
A	isCommandLineMode()	3	1
A	findChangeEvent()	9	2
A	getEventRecord()	20	4
B	hasChangeToNotifyAbout()	39	6
A	getFixedPropertyValueBy()	3	2
A	getDataItemById()	3	2
C	doFilterOnFieldChangeOps()	38	8
B	doCompareNotificationsOnValuesWithOps()	36	4
A	doCompareOnPropertyValues()	5	2
C	doCompareFields()	53	9

How to fix Complexity

<?php

namespace SMW\Notifications\ChangeNotification;

use SMW\Store;
use SMW\ApplicationFactory;
use SMW\DataValueFactory;
use SMW\DIWikiPage;
use SMW\DIProperty;
use SMW\SQLStore\CompositePropertyTableDiffIterator;
use SMW\Notifications\PropertyRegistry;
use User;
use Hooks;

/**
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class ChangeNotificationFilter {

	const VALUE_CHANGE = 'smw-value-change';
	const SPECIFICATION_CHANGE = 'smw-specification-change';

	/**
	 * @var DIWikiPage
	 */
	private $subject;

	/**
	 * @var Store
	 */
	private $store;

	/**
	 * @var DataValueFactory
	 */
	private $dataValueFactory;

	/**
	 * @var array
	 */
	private $detectedProperties = array();

	/**
	 * In case detection matrix was stored as subobject on a property then match
	 * its pairs of property => subobjectKey so that later the Locator can find
	 * out which subobject contains the group that needs to be notified.
	 *
	 * @var array
	 */
	private $subSemanticDataMatch = array();

	/**
	 * @var string|null
	 */
	private $type = null;

	/**
	 * @var User|null
	 */
	private $agent = null;

	/**
	 * @var boolean
	 */
	private $canNotify = false;

	/**
	 * @var array
	 */
	private $propertyExemptionList = array();

	/**
	 * @var boolean
	 */
	private $isCommandLineMode = false;

	/**
	 * @since 1.0
	 *
	 * @param DIWikiPage $subject
	 * @param Store $store
	 */
	public function __construct( DIWikiPage $subject, Store $store ) {
		$this->subject = $subject;
		$this->store = $store;
		$this->dataValueFactory = DataValueFactory::getInstance();
	}

	/**
	 * @since 1.0
	 *
	 * @param User $agent
	 */
	public function setAgent( User $agent ) {
		$this->agent = $agent;
	}

	/**
	 * @since 1.0
	 *
	 * @param array $propertyExemptionList
	 */
	public function setPropertyExemptionList( array $propertyExemptionList ) {
		$this->propertyExemptionList = array_flip(
			str_replace( ' ', '_', $propertyExemptionList )
		);
	}

	/**
	 * @since 1.0
	 *
	 * @param boolean $isCommandLineMode
	 */
	public function isCommandLineMode( $isCommandLineMode ) {
		$this->isCommandLineMode = $isCommandLineMode;
	}

	/**
	 * @since 1.0
	 *
	 * @param CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator
	 *
	 * @return array
	 */
	public function findChangeEvent( CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator ) {

		// Avoid notification when run from the commandLine
		if ( $this->isCommandLineMode ) {
			return array();
		}

		return $this->getEventRecord( $this->hasChangeToNotifyAbout( $compositePropertyTableDiffIterator ) );
	}

	/**
	 * @see EchoEvent::create
	 *
	 * @since 1.0
	 *
	 * @param boolean|null $hasChangeToNotifyAbout
	 *
	 * @return array
	 */
	public function getEventRecord( $hasChangeToNotifyAbout = false ) {

		if ( $this->subject === null || $this->type === null || !$hasChangeToNotifyAbout ) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
			wfDebugLog( 'smw', 'EchoEvent was not triggered' );
			return array();
		}

		return array(
			'agent' => $this->agent,
			'extra' => array(
				'notifyAgent' => false,
				'revid'       => $this->subject->getTitle()->getLatestRevID(),
				'properties'  => $this->detectedProperties,
				'subSemanticDataMatch' => $this->subSemanticDataMatch,
				'subject'     => $this->subject
			),
			'title' => $this->subject->getTitle(),
			'type'  => $this->type
		);
	}

	/**
	 * @since 1.0
	 *
	 * @param CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator
	 *
	 * @return boolean|null
	 */
	public function hasChangeToNotifyAbout( CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator ) {

		$start = microtime( true );
		$this->type = self::VALUE_CHANGE;

		$property = new DIProperty(
			PropertyRegistry::NOTIFICATIONS_ON
		);

		if (
			$this->subject->getNamespace() === SMW_NS_PROPERTY ||
			$this->subject->getNamespace() === NS_CATEGORY ||
			$this->subject->getNamespace() === SMW_NS_CONCEPT ) {
			$this->type = self::SPECIFICATION_CHANGE;
		}

		foreach ( $compositePropertyTableDiffIterator->getTableChangeOps() as $tableChangeOp ) {

			if ( isset( $this->propertyExemptionList[$this->getFixedPropertyValueBy( $tableChangeOp, 'key' )] ) ) {
				continue;
			}

			$this->doFilterOnFieldChangeOps(
				$property,
				$tableChangeOp,
				$tableChangeOp->getFieldChangeOps( 'insert' )
			);

			$this->doFilterOnFieldChangeOps(
				$property,
				$tableChangeOp,
				$tableChangeOp->getFieldChangeOps( 'delete' )
			);
		}

		wfDebugLog( 'smw', __METHOD__ . ' ' .  $this->subject->getHash() . ' in procTime (sec): ' . round( ( microtime( true ) - $start ), 7 ) );

		return $this->canNotify;
	}

	// 2.4 compat
	private function getFixedPropertyValueBy( $tableChangeOp, $key ) {
		return method_exists( $tableChangeOp, 'getFixedPropertyValueFor' ) ? $tableChangeOp->getFixedPropertyValueFor( $key ) : $tableChangeOp->getFixedPropertyValueBy( $key );
	}

	// 2.4 compat
	private function getDataItemById( $id ) {
		return method_exists( $this->store->getObjectIds(), 'getDataItemForId' ) ?  $this->store->getObjectIds()->getDataItemForId( $id ) : $this->store->getObjectIds()->getDataItemById( $id );
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	private function doFilterOnFieldChangeOps( $property, $tableChangeOp, $fieldChangeOps ) {

		foreach ( $fieldChangeOps as $fieldChangeOp ) {

			// _INST is special since the p_id doesn't play a role
			// in determining the category page involved
			if ( $tableChangeOp->isFixedPropertyOp() ) {
				if ( $this->getFixedPropertyValueBy( $tableChangeOp, 'key' ) === '_INST' ) {
					$fieldChangeOp->set( 'p_id', $fieldChangeOp->get( 'o_id' ) );
				} else {
					$fieldChangeOp->set( 'p_id', $this->getFixedPropertyValueBy( $tableChangeOp, 'p_id' ) );
				}
			}

			// Get DI representation to build a DataValues that allows
			// to match/compare values to its serialization form
			$dataItem = $this->getDataItemById(
				$fieldChangeOp->get( 'p_id' )
			);

			if ( $dataItem === null || $dataItem->getDBKey() === '' || isset( $this->propertyExemptionList[$dataItem->getDBKey()] ) ) {
				continue;
			}

			// Shortcut! we know changes occurred on a property itself
			if ( $this->type === self::SPECIFICATION_CHANGE ) {
				$this->detectedProperties[$dataItem->getHash()] = $dataItem;
				$this->canNotify = true;
				continue;
			}

			$this->doCompareNotificationsOnValuesWithOps(
				$property,
				$dataItem,
				$fieldChangeOp
			);
		}
	}

	private function doCompareNotificationsOnValuesWithOps( $property, $dataItem, $fieldChangeOp ) {

		$cachedPropertyValuesPrefetcher = ApplicationFactory::getInstance()->getCachedPropertyValuesPrefetcher();

		// Don't mix !!
		// Either use the plain annotation style via [[Notifications on:: ...]] OR
		// in case one wants to have a detection matrix use:
		//
		// {{#subobject:
		//  |Notifications on=...
		//  |Notifications to group=...
		// }}
		if ( ( $pv = $cachedPropertyValuesPrefetcher->getPropertyValues( $dataItem, $property ) ) !== array() ) {
			return $this->doCompareOnPropertyValues( $dataItem, $pv, $fieldChangeOp );
		}

		// Get the whole property definitions and compare on subobjects that
		// contain `Notifications on:: ...` declarations
		$semanticData = $this->store->getSemanticData(
			$dataItem
		);

		// If matched then remember the subobjectName to later during the UserLocator
		// process to find out which groups on a particular SOBJ are to be
		// addressed
		foreach ( $semanticData->getSubSemanticData() as $subSemanticData ) {
			if ( $subSemanticData->hasProperty( $property ) ) {
				$this->doCompareOnPropertyValues(
					$dataItem,
					$subSemanticData->getPropertyValues( $property ),
					$fieldChangeOp,
					$subSemanticData->getSubject()->getSubobjectName()
				);
			}
		}
	}

	private function doCompareOnPropertyValues( $dataItem, $propertyValues, $fieldChangeOp, $subobjectName = null ) {
		foreach ( $propertyValues as $val ) {
			$this->doCompareFields( $val->getString(), $fieldChangeOp, $dataItem, $subobjectName );
		}
	}

	private function doCompareFields( $value, $fieldChangeOp, $dataItem, $subobjectName ) {

		$hash = $dataItem->getHash();

		// Any value
		if ( $value === '+' ) {
			$this->detectedProperties[$hash] = $dataItem;
			$this->subSemanticDataMatch[$hash][] = $subobjectName;
			$this->canNotify = true;
		} elseif ( $fieldChangeOp->has( 'o_serialized' ) || $fieldChangeOp->has( 'o_blob' ) ) {

			// Literal object entities
			if ( $fieldChangeOp->has( 'o_serialized' ) ) {
				$string = $fieldChangeOp->get( 'o_serialized' );
			} elseif ( $fieldChangeOp->get( 'o_blob' ) ) {
				$string = $fieldChangeOp->get( 'o_blob' );
			} else {
				$string = $fieldChangeOp->get( 'o_hash' );
			}

			$dataValue = $this->dataValueFactory->newDataValueByProperty(
				DIProperty::newFromUserLabel( $dataItem->getDBKey() ),
				$value
			);

/*

			if ( Hooks::run( 'SMW::Notifications::CanCreateNotificationEventOnDistinctValueChange', array( $this->subject, $this->agent, $value, $dataValue->getDataItem() ) ) === false ) {
				return;
			}
*/
			if ( $string === $dataValue->getDataItem()->getSerialization() ) {
				$this->detectedProperties[$hash] = $dataItem;
				$this->subSemanticDataMatch[$hash][] = $subobjectName;
				$this->canNotify = true;
			}
		} elseif ( $fieldChangeOp->has( 'o_id' ) ) {

			// Page object entities
			$oDataItem = $this->getDataItemById(
				$fieldChangeOp->get( 'o_id' )
			);
/*

			if ( Hooks::run( 'SMW::Notifications::CanCreateNotificationEventOnDistinctValueChange', array( $this->subject, $this->agent, $value, $oDataItem ) ) === false ) {
				return;
			}
*/
			if ( $value === str_replace( '_', ' ', $oDataItem->getDBKey() ) ) {
				$this->detectedProperties[$hash] = $dataItem;
				$this->subSemanticDataMatch[$hash][] = $subobjectName;
				$this->canNotify = true;
			}
		}
	}

}


Pull Request — master (#20)

ChangeNotificationFilter B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

13 Methods

How to fix Complexity

Complex Class

Available Fixes

1		<?php
2
3		namespace SMW\Notifications\ChangeNotification;
4
5		use SMW\Store;
6		use SMW\ApplicationFactory;
7		use SMW\DataValueFactory;
8		use SMW\DIWikiPage;
9		use SMW\DIProperty;
10		use SMW\SQLStore\CompositePropertyTableDiffIterator;
11		use SMW\Notifications\PropertyRegistry;
12		use User;
13		use Hooks;
14
15		/**
16		* @license GNU GPL v2+
17		* @since 1.0
18		*
19		* @author mwjames
20		*/
21		class ChangeNotificationFilter {
22
23		const VALUE_CHANGE = 'smw-value-change';
24		const SPECIFICATION_CHANGE = 'smw-specification-change';
25
26		/**
27		* @var DIWikiPage
28		*/
29		private $subject;
30
31		/**
32		* @var Store
33		*/
34		private $store;
35
36		/**
37		* @var DataValueFactory
38		*/
39		private $dataValueFactory;
40
41		/**
42		* @var array
43		*/
44		private $detectedProperties = array();
45
46		/**
47		* In case detection matrix was stored as subobject on a property then match
48		* its pairs of property => subobjectKey so that later the Locator can find
49		* out which subobject contains the group that needs to be notified.
50		*
51		* @var array
52		*/
53		private $subSemanticDataMatch = array();
54
55		/**
56		* @var string\|null
57		*/
58		private $type = null;
59
60		/**
61		* @var User\|null
62		*/
63		private $agent = null;
64
65		/**
66		* @var boolean
67		*/
68		private $canNotify = false;
69
70		/**
71		* @var array
72		*/
73		private $propertyExemptionList = array();
74
75		/**
76	8	* @var boolean
77	8	*/
78	8	private $isCommandLineMode = false;
79	8
80	8	/**
81		* @since 1.0
82		*
83		* @param DIWikiPage $subject
84		* @param Store $store
85		*/
86		public function __construct( DIWikiPage $subject, Store $store ) {
87	4	$this->subject = $subject;
88	4	$this->store = $store;
89	4	$this->dataValueFactory = DataValueFactory::getInstance();
90		}
91
92		/**
93		* @since 1.0
94		*
95		* @param User $agent
96		*/
97		public function setAgent( User $agent ) {
98		$this->agent = $agent;
99		}
100	2
101		/**
102	2	* @since 1.0
103	1	*
104	1	* @param array $propertyExemptionList
105		*/
106		public function setPropertyExemptionList( array $propertyExemptionList ) {
107		$this->propertyExemptionList = array_flip(
108	1	str_replace( ' ', '_', $propertyExemptionList )
109		);
110	1	}
111	1
112	1	/**
113	1	* @since 1.0
114	1	*
115	1	* @param boolean $isCommandLineMode
116	1	*/
117	1	public function isCommandLineMode( $isCommandLineMode ) {
118	1	$this->isCommandLineMode = $isCommandLineMode;
119		}
120
121		/**
122		* @since 1.0
123		*
124		* @param CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator
125		*
126		* @return array
127		*/
128	6	public function findChangeEvent( CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator ) {
129
130	6	// Avoid notification when run from the commandLine
131	6	if ( $this->isCommandLineMode ) {
132		return array();
133	6	}
134
135	6	return $this->getEventRecord( $this->hasChangeToNotifyAbout( $compositePropertyTableDiffIterator ) );
136		}
137
138	6	/**
139	5	* @see EchoEvent::create
140	6	*
141	1	* @since 1.0
142	1	*
143		* @param boolean\|null $hasChangeToNotifyAbout
144	6	*
145		* @return array
146		*/
147		public function getEventRecord( $hasChangeToNotifyAbout = false ) {
148	6
149	6	if ( $this->subject === null \|\| $this->type === null \|\| !$hasChangeToNotifyAbout ) {
		0 ignored issues – show Bug Best Practice introduced 2016-10-05 08:39 UTC by Report Bug Copy Issue Report The expression `$hasChangeToNotifyAbout` of type `boolean\|null` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
150	1	wfDebugLog( 'smw', 'EchoEvent was not triggered' );
151		return array();
152		}
153	5
154	5	return array(
155	5	'agent' => $this->agent,
156	5	'extra' => array(
157	5	'notifyAgent' => false,
158		'revid' => $this->subject->getTitle()->getLatestRevID(),
159	5	'properties' => $this->detectedProperties,
160	5	'subSemanticDataMatch' => $this->subSemanticDataMatch,
161	5	'subject' => $this->subject
162	5	),
163	5	'title' => $this->subject->getTitle(),
164	6	'type' => $this->type
165		);
166	6	}
167
168	6	/**
169		* @since 1.0
170		*
171		* @param CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator
172	6	*
173	6	* @return boolean\|null
174		*/
175		public function hasChangeToNotifyAbout( CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator ) {
176	5
177		$start = microtime( true );
178	5	$this->type = self::VALUE_CHANGE;
179
180		$property = new DIProperty(
181		PropertyRegistry::NOTIFICATIONS_ON
182	5	);
183	3
184		if (
185		$this->subject->getNamespace() === SMW_NS_PROPERTY \|\|
186	3	$this->subject->getNamespace() === NS_CATEGORY \|\|
187		$this->subject->getNamespace() === SMW_NS_CONCEPT ) {
188	3	$this->type = self::SPECIFICATION_CHANGE;
189		}
190
191		foreach ( $compositePropertyTableDiffIterator->getTableChangeOps() as $tableChangeOp ) {
192	5
193	5	if ( isset( $this->propertyExemptionList[$this->getFixedPropertyValueBy( $tableChangeOp, 'key' )] ) ) {
194	5	continue;
195		}
196	5
197		$this->doFilterOnFieldChangeOps(
198		$property,
199		$tableChangeOp,
200		$tableChangeOp->getFieldChangeOps( 'insert' )
201	5	);
202	1
203	1	$this->doFilterOnFieldChangeOps(
204	1	$property,
205		$tableChangeOp,
206		$tableChangeOp->getFieldChangeOps( 'delete' )
207	4	);
208	4	}
209	4
210		wfDebugLog( 'smw', __METHOD__ . ' ' . $this->subject->getHash() . ' in procTime (sec): ' . round( ( microtime( true ) - $start ), 7 ) );
211	4
212	5	return $this->canNotify;
213	5	}
214
215	4	// 2.4 compat
216		private function getFixedPropertyValueBy( $tableChangeOp, $key ) {
217	4	return method_exists( $tableChangeOp, 'getFixedPropertyValueFor' ) ? $tableChangeOp->getFixedPropertyValueFor( $key ) : $tableChangeOp->getFixedPropertyValueBy( $key );
218		}
219
220		// 2.4 compat
221		private function getDataItemById( $id ) {
222		return method_exists( $this->store->getObjectIds(), 'getDataItemForId' ) ? $this->store->getObjectIds()->getDataItemForId( $id ) : $this->store->getObjectIds()->getDataItemById( $id );
		0 ignored issues – show Bug introduced 2016-11-05 23:39 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `SMW\Store` as the method `getObjectIds()` does only exist in the following sub-classes of `SMW\Store`: `SMWSQLStore3`, `SMWSparqlStore`, `SMW\SPARQLStore\SPARQLStore`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
223		}
224
225		private function doFilterOnFieldChangeOps( $property, $tableChangeOp, $fieldChangeOps ) {
226
227	4	foreach ( $fieldChangeOps as $fieldChangeOp ) {
228	3
229		// _INST is special since the p_id doesn't play a role
230		// in determining the category page involved
231		if ( $tableChangeOp->isFixedPropertyOp() ) {
232		if ( $this->getFixedPropertyValueBy( $tableChangeOp, 'key' ) === '_INST' ) {
233	1	$fieldChangeOp->set( 'p_id', $fieldChangeOp->get( 'o_id' ) );
234		} else {
235	1	$fieldChangeOp->set( 'p_id', $this->getFixedPropertyValueBy( $tableChangeOp, 'p_id' ) );
236		}
237		}
238
239		// Get DI representation to build a DataValues that allows
240	1	// to match/compare values to its serialization form
241	1	$dataItem = $this->getDataItemById(
242	1	$fieldChangeOp->get( 'p_id' )
243	1	);
244	1
245	1	if ( $dataItem === null \|\| $dataItem->getDBKey() === '' \|\| isset( $this->propertyExemptionList[$dataItem->getDBKey()] ) ) {
246	1	continue;
247	1	}
248	1
249	1	// Shortcut! we know changes occurred on a property itself
250	1	if ( $this->type === self::SPECIFICATION_CHANGE ) {
251		$this->detectedProperties[$dataItem->getHash()] = $dataItem;
252	4	$this->canNotify = true;
253	4	continue;
254	4	}
255	4
256	4	$this->doCompareNotificationsOnValuesWithOps(
257		$property,
258	4	$dataItem,
259		$fieldChangeOp
260	4	);
261		}
262		}
263	4
264	1	private function doCompareNotificationsOnValuesWithOps( $property, $dataItem, $fieldChangeOp ) {
265	1
266	1	$cachedPropertyValuesPrefetcher = ApplicationFactory::getInstance()->getCachedPropertyValuesPrefetcher();
267	4
268		// Don't mix !!
269		// Either use the plain annotation style via [[Notifications on:: ...]] OR
270	1	// in case one wants to have a detection matrix use:
271		//
272	1	// {{#subobject:
273	1	// \|Notifications on=...
274	1	// \|Notifications to group=...
275		// }}
276		if ( ( $pv = $cachedPropertyValuesPrefetcher->getPropertyValues( $dataItem, $property ) ) !== array() ) {
277		return $this->doCompareOnPropertyValues( $dataItem, $pv, $fieldChangeOp );
278	1	}
279	1
280		// Get the whole property definitions and compare on subobjects that
281	1	// contain `Notifications on:: ...` declarations
282		$semanticData = $this->store->getSemanticData(
283		$dataItem
284		);
285
286		// If matched then remember the subobjectName to later during the UserLocator
287		// process to find out which groups on a particular SOBJ are to be
288	1	// addressed
289	1	foreach ( $semanticData->getSubSemanticData() as $subSemanticData ) {
290	1	if ( $subSemanticData->hasProperty( $property ) ) {
291	1	$this->doCompareOnPropertyValues(
292	1	$dataItem,
293	3	$subSemanticData->getPropertyValues( $property ),
294		$fieldChangeOp,
295		$subSemanticData->getSubject()->getSubobjectName()
296	2	);
297	2	}
298	2	}
299		}
300
301		private function doCompareOnPropertyValues( $dataItem, $propertyValues, $fieldChangeOp, $subobjectName = null ) {
302		foreach ( $propertyValues as $val ) {
303		$this->doCompareFields( $val->getString(), $fieldChangeOp, $dataItem, $subobjectName );
304	2	}
305	2	}
306	2
307	2	private function doCompareFields( $value, $fieldChangeOp, $dataItem, $subobjectName ) {
308	2
309	2	$hash = $dataItem->getHash();
310	4
311		// Any value
312		if ( $value === '+' ) {
313		$this->detectedProperties[$hash] = $dataItem;
314		$this->subSemanticDataMatch[$hash][] = $subobjectName;
315		$this->canNotify = true;
316		} elseif ( $fieldChangeOp->has( 'o_serialized' ) \|\| $fieldChangeOp->has( 'o_blob' ) ) {
317
318		// Literal object entities
319		if ( $fieldChangeOp->has( 'o_serialized' ) ) {
320		$string = $fieldChangeOp->get( 'o_serialized' );
321		} elseif ( $fieldChangeOp->get( 'o_blob' ) ) {
322		$string = $fieldChangeOp->get( 'o_blob' );
323		} else {
324		$string = $fieldChangeOp->get( 'o_hash' );
325		}
326
327		$dataValue = $this->dataValueFactory->newDataValueByProperty(
328		DIProperty::newFromUserLabel( $dataItem->getDBKey() ),
329		$value
330		);
331
332		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-19 03:39 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
333		if ( Hooks::run( 'SMW::Notifications::CanCreateNotificationEventOnDistinctValueChange', array( $this->subject, $this->agent, $value, $dataValue->getDataItem() ) ) === false ) {
334		return;
335		}
336		*/
337		if ( $string === $dataValue->getDataItem()->getSerialization() ) {
338		$this->detectedProperties[$hash] = $dataItem;
339		$this->subSemanticDataMatch[$hash][] = $subobjectName;
340		$this->canNotify = true;
341		}
342		} elseif ( $fieldChangeOp->has( 'o_id' ) ) {
343
344		// Page object entities
345		$oDataItem = $this->getDataItemById(
346		$fieldChangeOp->get( 'o_id' )
347		);
348		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-19 03:39 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
349		if ( Hooks::run( 'SMW::Notifications::CanCreateNotificationEventOnDistinctValueChange', array( $this->subject, $this->agent, $value, $oDataItem ) ) === false ) {
350		return;
351		}
352		*/
353		if ( $value === str_replace( '_', ' ', $oDataItem->getDBKey() ) ) {
354		$this->detectedProperties[$hash] = $dataItem;
355		$this->subSemanticDataMatch[$hash][] = $subobjectName;
356		$this->canNotify = true;
357		}
358		}
359		}
360
361		}
362

SemanticMediaWiki / SemanticNotifications

Pull Request — master (#20)

ChangeNotificationFilter B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

13 Methods

How to fix Complexity

Complex Class

Available Fixes

Duplication Side-by-Side

Filter issues like