SemanticMediaWiki / SemanticMediaWiki

src/MediaWiki/Hooks/HookHandler.php

Doc Comments +3 added lines

@@ -55,6 +55,9 @@
 		$this->logger = $logger;
 	}
 
+	/**
+	 * @param string $message
+	 */
 	protected function log( $message, $context = array() ) {
 
 		if ( $this->logger === null ) {

src/PropertyAnnotatorFactory.php

Doc Comments -7 removed lines

@@ -36,7 +36,6 @@ 
 	/**
 	 * @since 2.0
 	 *
-	 * @param SemanticData $semanticData
 	 * @param RedirectTargetFinder $redirectTargetFinder
 	 *
 	 * @return RedirectPropertyAnnotator
@@ -51,7 +50,6 @@ 
 	/**
 	 * @since 2.0
 	 *
-	 * @param SemanticData $semanticData
 	 * @param PageInfo $pageInfo
 	 *
 	 * @return PredefinedPropertyAnnotator
@@ -73,7 +71,6 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @param SemanticData $semanticData
 	 * @param Title $title
 	 *
 	 * @return EditProtectedPropertyAnnotator
@@ -95,7 +92,6 @@ 
 	/**
 	 * @since 2.0
 	 *
-	 * @param SemanticData $semanticData
 	 * @param string $sortkey
 	 *
 	 * @return SortKeyPropertyAnnotator
@@ -110,7 +106,6 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @param SemanticData $semanticData
 	 * @param string|false $displayTitle
 	 * @param string $defaultSort
 	 *
@@ -134,7 +129,6 @@ 
 	/**
 	 * @since 2.0
 	 *
-	 * @param SemanticData $semanticData
 	 * @param array $categories
 	 *
 	 * @return CategoryPropertyAnnotator
@@ -164,7 +158,6 @@ 
 	/**
 	 * @since 2.2
 	 *
-	 * @param SemanticData $semanticData
 	 *
 	 * @return MandatoryTypePropertyAnnotator
 	 */

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use SMW\PropertyAnnotators\RedirectPropertyAnnotator;
 use SMW\PropertyAnnotators\SortKeyPropertyAnnotator;
 use SMW\PropertyAnnotators\EditProtectedPropertyAnnotator;
-use SMW\Store;
 use Title;
 
 /**

src/PropertyAnnotators/EditProtectedPropertyAnnotator.php

Doc Comments +3 added lines

@@ -132,6 +132,9 @@
 		return isset( $restrictions[$this->editProtectionRight] );
 	}
 
+	/**
+	 * @param \SMW\DIProperty $property
+	 */
 	private function isEnabledProtection( $property ) {
 
 		if ( !$this->getSemanticData()->hasProperty( $property ) ) {

src/Protection/EditProtectionUpdater.php

Doc Comments +6 added lines

@@ -128,6 +128,9 @@ 
 		$this->doUpdateRestrictions( $isEditProtected );
 	}
 
+	/**
+	 * @param SemanticData $semanticData
+	 */
 	private function fetchEditProtectedInfo( $semanticData ) {
 
 		// Whether or not the update was invoked by the ArticleProtectComplete hook
@@ -195,6 +198,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $message
+	 */
 	private function log( $message, $context = array() ) {
 
 		if ( $this->logger === null ) {

src/DataValues/Time/JulianDay.php

Doc Comments +11 added lines, -11 removed lines

@@ -34,7 +34,7 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @param integer $calendarmodel
+	 * @param integer $calendarModel
 	 * @param integer $year
 	 * @param integer $month
 	 * @param integer $day
@@ -68,10 +68,10 @@ 
 	 * calendar model. This calculation assumes that neither calendar
 	 * has a year 0.
 	 *
-	 * @param $year integer representing the year
-	 * @param $month integer representing the month
-	 * @param $day integer representing the day
-	 * @param $calendarmodel integer either CM_GREGORIAN or CM_JULIAN
+	 * @param integer $year integer representing the year
+	 * @param integer $month integer representing the month
+	 * @param integer $day integer representing the day
+	 * @param integer $calendarmodel integer either CM_GREGORIAN or CM_JULIAN
 	 *
 	 * @return float Julian Day number
 	 * @throws RuntimeException
@@ -97,9 +97,9 @@ 
 	 * Compute the offset for the Julian Day number from a given time.
 	 * This computation is the same for all calendar models.
 	 *
-	 * @param $hours integer representing the hour
-	 * @param $minutes integer representing the minutes
-	 * @param $seconds integer representing the seconds
+	 * @param integer $hours integer representing the hour
+	 * @param integer $minutes integer representing the minutes
+	 * @param integer $seconds integer representing the seconds
 	 *
 	 * @return float offset for a Julian Day number to get this time
 	 */
@@ -114,8 +114,8 @@ 
 	 * conversion to Gregorian needs positive JD. If this happens, wrong
 	 * values will be returned. Avoid date conversions before 10000 BCE.
 	 *
-	 * @param $jdValue float number of Julian Days
-	 * @param $calendarModel integer either CM_GREGORIAN or CM_JULIAN
+	 * @param double $jdValue float number of Julian Days
+	 * @param integer $calendarModel integer either CM_GREGORIAN or CM_JULIAN
 	 *
 	 * @return array( calendarModel, yearnumber, monthnumber, daynumber )
 	 * @throws RuntimeException
@@ -166,7 +166,7 @@ 
 	 * Extract the time from a Julian Day number and return it as a string.
 	 * This conversion is the same for all calendar models.
 	 *
-	 * @param $jdvalue float number of Julian Days
+	 * @param double $jdvalue float number of Julian Days
 	 * @return array( hours, minutes, seconds )
 	 */
 	public static function JD2Time( $jdvalue ) {

src/DataValues/Time/Timezone.php

Doc Comments +3 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
 	 *
 	 * @param string $identifer
 	 *
-	 * @return false|integer
+	 * @return string
 	 */
 	public static function getIdByAbbreviation( $identifer ) {
 
@@ -208,7 +208,7 @@ 
 	 *
 	 * @param integer $identifer
 	 *
-	 * @return false|string
+	 * @return string
 	 */
 	public static function getTimezoneLiteralById( $identifer ) {
 
@@ -350,7 +350,7 @@ 
 	 * @since 2.5
 	 *
 	 * @param DateTime &$dateTime
-	 * @param string|integer $identifer
+	 * @param integer $identifer
 	 *
 	 * @return string
 	 */

tests/phpunit/Unit/DataValues/Time/TimezoneTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SMW\Tests\DataValues\Time;
 
-use SMW\DataItemFactory;
 use SMW\DataValues\Time\Timezone;
 
 /**

src/Query/QueryToken.php

Doc Comments +7 added lines, -1 removed lines

@@ -108,7 +108,6 @@ 
 	 *
 	 * @since 2.5
 	 *
-	 * @param string $text
 	 */
 	public function canHighlight( $canHighlight ) {
 		$this->canHighlight = strpos( strtolower( $canHighlight ), '-hl' ) !== false;
@@ -131,6 +130,10 @@ 
 		return $this->doHighlight( $text, $type, array_keys( $this->tokens ) );
 	}
 
+	/**
+	 * @param string $text
+	 * @param string $type
+	 */
 	private function doHighlight( $text, $type, $tokens ) {
 
 		if ( $type === self::HL_BOLD ) {
@@ -150,6 +153,9 @@ 
 		return preg_replace( $pattern, $replacement, $text );
 	}
 
+	/**
+	 * @param string $text
+	 */
 	private function addTokensFromText( $text ) {
 
 		// Remove query related chars

tests/phpunit/Integration/JSONScript/JsonTestCaseScriptRunnerTest.php

Doc Comments +18 added lines

@@ -153,6 +153,9 @@ 
 		$this->doRunQueryTests( $jsonTestCaseFileHandler );
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function prepareTest( $jsonTestCaseFileHandler ) {
 
 		$permittedSettings = array(
@@ -206,6 +209,9 @@ 
 		);
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function doRunBeforeTest( $jsonTestCaseFileHandler ) {
 
 		foreach ( $jsonTestCaseFileHandler->findTaskBeforeTestExecutionByType( 'maintenance-run' ) as $runner => $options ) {
@@ -224,6 +230,9 @@ 
 		}
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function doRunParserTests( $jsonTestCaseFileHandler ) {
 
 		$this->parserTestCaseProcessor->setDebugMode(
@@ -240,6 +249,9 @@ 
 		}
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function doRunSpecialTests( $jsonTestCaseFileHandler ) {
 
 		$this->specialPageTestCaseProcessor->setDebugMode(
@@ -256,6 +268,9 @@ 
 		}
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function doRunRdfTests( $jsonTestCaseFileHandler ) {
 
 		// For some reason there are some random failures where
@@ -276,6 +291,9 @@ 
 		}
 	}
 
+	/**
+	 * @param JsonTestCaseFileHandler $jsonTestCaseFileHandler
+	 */
 	private function doRunQueryTests( $jsonTestCaseFileHandler ) {
 
 		// Set query parser late to ensure that expected settings are adjusted

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SMW\PropertySpecificationLookup;
 use SMW\Tests\JsonTestCaseScriptRunner;
 use SMW\Tests\JsonTestCaseFileHandler;
-use SMW\Tests\Utils\UtilityFactory;
 
 /**
  * @group semantic-mediawiki