Completed
Push — master ( 07dd29...2a8480 )
by mw
409:44 queued 374:41
created
src/SQLStore/SQLStoreFactory.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	/**
60 60
 	 * @since 2.2
61 61
 	 *
62
-	 * @return QueryEngine
62
+	 * @return QueryEngine\QueryEngine
63 63
 	 */
64 64
 	public function newMasterQueryEngine() {
65 65
 		return $this->queryEngineFactory->newQueryEngine();
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	/**
69 69
 	 * @since 2.2
70 70
 	 *
71
-	 * @return QueryEngine
71
+	 * @return QueryEngine\QueryEngine
72 72
 	 */
73 73
 	public function newSlaveQueryEngine() {
74 74
 		return $this->newMasterQueryEngine();
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
 	/**
422 422
 	 * @since 2.5
423 423
 	 *
424
-	 * @return LoggerInterface
424
+	 * @return \Psr\Log\LoggerInterface
425 425
 	 */
426 426
 	public function getLogger() {
427 427
 		return ApplicationFactory::getInstance()->getMediaWikiLogger();
Please login to merge, or discard this patch.
src/SQLStore/ConceptCache.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,6 @@
 block discarded – undo
38 38
 	 * @since 2.2
39 39
 	 *
40 40
 	 * @param SMWSQLStore3 $store
41
-	 * @param ConceptQuerySegmentBuilder $conceptQueryResolver
42 41
 	 */
43 42
 	public function __construct( SMWSQLStore3 $store, ConceptQuerySegmentBuilder $conceptQuerySegmentBuilder ) {
44 43
 		$this->store = $store;
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/QuerySegmentListBuildManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	/**
67 67
 	 * @since 2.5
68 68
 	 *
69
-	 * @return array
69
+	 * @return string[]
70 70
 	 */
71 71
 	public function getErrors() {
72 72
 		return $this->errors;
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	/**
76 76
 	 * @since 2.5
77 77
 	 *
78
-	 * @return array
78
+	 * @return QuerySegment[]
79 79
 	 */
80 80
 	public function getQuerySegmentList() {
81 81
 		return $this->querySegmentList;
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SMW\SQLStore\QueryEngine;
4 4
 
5
-use SMW\DIWikiPage;
6 5
 use SMWQuery as Query;
7 6
 use SMW\MediaWiki\Database;
8 7
 use SMW\SQLStore\SQLStore;
Please login to merge, or discard this patch.
tests/phpunit/TestEnvironment.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 	/**
184 184
 	 * @since 2.5
185 185
 	 *
186
-	 * @param $originalClassName
186
+	 * @param string $originalClassName
187 187
 	 * @param array $configuration
188 188
 	 *
189 189
 	 * @return PHPUnit_Framework_MockObject_MockObject
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 	 * @since 2.5
229 229
 	 *
230 230
 	 * @param integer $index
231
-	 * @param string $url
231
+	 * @param string $text
232 232
 	 *
233 233
 	 * @return string
234 234
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SMW\ApplicationFactory;
6 6
 use SMW\DataValueFactory;
7 7
 use SMW\DeferredCallableUpdate;
8
-use SMW\Store;
9 8
 use SMW\Localizer;
10 9
 use SMW\Tests\Utils\UtilityFactory;
11 10
 use SMW\Tests\Utils\Mock\ConfigurableStub;
Please login to merge, or discard this patch.
includes/dataitems/SMW_DI_Property.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -307,6 +307,7 @@  discard block
 block discarded – undo
307 307
 	/**
308 308
 	 * @since  2.0
309 309
 	 *
310
+	 * @param string $propertyTypeId
310 311
 	 * @return self
311 312
 	 * @throws PropertyDataTypeLookupExeption
312 313
 	 * @throws InvalidArgumentException
@@ -460,6 +461,7 @@  discard block
 block discarded – undo
460 461
 
461 462
 	/**
462 463
 	 * @deprecated since 2.1, use PropertyRegistry::findPropertyIdByLabel
464
+	 * @param string $label
463 465
 	 */
464 466
 	public static function findPropertyID( $label, $useAlias = true ) {
465 467
 		return PropertyRegistry::getInstance()->findPropertyIdByLabel( $label, $useAlias );
@@ -493,6 +495,9 @@  discard block
 block discarded – undo
493 495
 		PropertyRegistry::getInstance()->registerPropertyAlias( $id, $label );
494 496
 	}
495 497
 
498
+	/**
499
+	 * @param string $subobjectName
500
+	 */
496 501
 	private function newDIWikiPage( $dbkey, $subobjectName ) {
497 502
 
498 503
 		// If an inverse marker is present just omit the marker so a normal
Please login to merge, or discard this patch.
includes/dataitems/SMW_DI_Time.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 	 *
336 336
 	 * @param string $timestamp must be in format
337 337
 	 *
338
-	 * @return SMWDITime|false
338
+	 * @return SMWDataItem
339 339
 	 */
340 340
 	public static function newFromTimestamp( $timestamp ) {
341 341
 		$timestamp = wfTimestamp( TS_MW, (string)$timestamp );
@@ -508,10 +508,10 @@  discard block
 block discarded – undo
508 508
 	 * calendar model, presicion.
509 509
 	 *
510 510
 	 * @param double $jdValue
511
-	 * @param integer|null $calendarmodel
511
+	 * @param integer|null $calendarModel
512 512
 	 * @param integer|null $precision
513 513
 	 *
514
-	 * @return DITime object
514
+	 * @return SMWDITime object
515 515
 	 */
516 516
 	public static function newFromJD( $jdValue, $calendarModel = null, $precision = null, $timezone = false ) {
517 517
 
@@ -593,6 +593,11 @@  discard block
 block discarded – undo
593 593
 		return $this->m_day > self::getDayNumberForMonth( $this->m_month, $this->m_year, $this->m_model );
594 594
 	}
595 595
 
596
+	/**
597
+	 * @param boolean $month
598
+	 * @param boolean $day
599
+	 * @param boolean $hour
600
+	 */
596 601
 	private function setPrecisionLevelBy( $month, $day, $hour ) {
597 602
 		if ( $month === false ) {
598 603
 			$this->m_precision = self::PREC_Y;
Please login to merge, or discard this patch.
includes/datavalues/SMW_DV_URI.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@  discard block
 block discarded – undo
45 45
 	 */
46 46
 	private $showUrlContextInRawFormat = true;
47 47
 
48
+	/**
49
+	 * @param string $typeid
50
+	 */
48 51
 	public function __construct( $typeid ) {
49 52
 		parent::__construct( $typeid );
50 53
 		switch ( $typeid ) {
@@ -182,6 +185,7 @@  discard block
 block discarded – undo
182 185
 	 * Returns true if the argument is a valid RFC 3966 phone number.
183 186
 	 * Only global phone numbers are supported, and no full validation
184 187
 	 * of parameters (appended via ;param=value) is performed.
188
+	 * @param string $s
185 189
 	 */
186 190
 	protected static function isValidTelURI( $s ) {
187 191
 		$tel_uri_regex = '<^tel:\+[0-9./-]*[0-9][0-9./-]*(;[0-9a-zA-Z-]+=(%[0-9a-zA-Z][0-9a-zA-Z]|[0-9a-zA-Z._~:/?#[\]@!$&\'()*+,;=-])*)*$>';
@@ -340,6 +344,9 @@  discard block
 block discarded – undo
340 344
 		return str_replace( ':', '&#58;', $url );
341 345
 	}
342 346
 
347
+	/**
348
+	 * @param string $context
349
+	 */
343 350
 	private function decodeUriContext( $context, $linker ) {
344 351
 
345 352
 		// Prior to decoding turn any `-` into an internal representation to avoid
Please login to merge, or discard this patch.
includes/query/SMW_QueryParser.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -142,6 +142,7 @@  discard block
 block discarded – undo
142 142
 	 * but just controls query generation. For general effect, the default namespaces
143 143
 	 * should be set to NULL.
144 144
 	 *
145
+	 * @param boolean $setNS
145 146
 	 * @return Description|null
146 147
 	 */
147 148
 	private function getSubqueryDescription( &$setNS ) {
@@ -250,6 +251,7 @@  discard block
 block discarded – undo
250 251
 	 * be the content of "[[ ... ]]". Returns NULL upon error.
251 252
 	 *
252 253
 	 * Parameters $setNS has the same use as in getSubqueryDescription().
254
+	 * @param boolean $setNS
253 255
 	 */
254 256
 	private function getLinkDescription( &$setNS ) {
255 257
 		// This method is called when we encountered an opening '[['. The following
@@ -433,6 +435,7 @@  discard block
 block discarded – undo
433 435
 	 * a category or property) and create a suitable description.
434 436
 	 * The first chunk behind the "[[" has already been read and is
435 437
 	 * passed as a parameter.
438
+	 * @param string $firstChunk
436 439
 	 */
437 440
 	private function getArticleDescription( $firstChunk, &$setNS ) {
438 441
 		$chunk = $firstChunk;
@@ -478,6 +481,10 @@  discard block
 block discarded – undo
478 481
 		return $this->finishLinkDescription( $chunk, true, $result, $setNS );
479 482
 	}
480 483
 
484
+	/**
485
+	 * @param boolean $hasNamespaces
486
+	 * @param Description|null $result
487
+	 */
481 488
 	private function finishLinkDescription( $chunk, $hasNamespaces, $result, &$setNS ) {
482 489
 		if ( is_null( $result ) ) { // no useful information or concrete error found
483 490
 			$this->descriptionProcessor->addErrorWithMsgKey( 'smw_unexpectedpart', $chunk ); // was smw_badqueryatom
@@ -574,6 +581,7 @@  discard block
 block discarded – undo
574 581
 	/**
575 582
 	 * Enter a new subblock in the query, which must at some time be terminated by the
576 583
 	 * given $endstring delimiter calling popDelimiter();
584
+	 * @param string $endstring
577 585
 	 */
578 586
 	private function pushDelimiter( $endstring ) {
579 587
 		array_push( $this->separatorStack, $endstring );
@@ -583,6 +591,7 @@  discard block
 block discarded – undo
583 591
 	 * Exit a subblock in the query ending with the given delimiter.
584 592
 	 * If the delimiter does not match the top-most open block, false
585 593
 	 * will be returned. Otherwise return true.
594
+	 * @param string $endstring
586 595
 	 */
587 596
 	private function popDelimiter( $endstring ) {
588 597
 		$topdelim = array_pop( $this->separatorStack );
Please login to merge, or discard this patch.
includes/queryprinters/CategoryResultPrinter.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -224,6 +224,10 @@
 block discarded – undo
224 224
 		return ByLanguageCollationMapper::getInstance()->findFirstLetterForCategory( $sortKey );
225 225
 	}
226 226
 
227
+	/**
228
+	 * @param SMWQueryResult $res
229
+	 * @param boolean $first_col
230
+	 */
227 231
 	private function addRowFieldsToTemplate( $res, $row, &$first_col, $templateRenderer ) {
228 232
 
229 233
 		// explicitly number parameters for more robust parsing (values may contain "=")
Please login to merge, or discard this patch.