SemanticMediaWiki / SemanticMediaWiki

includes/storage/SQLStore/SMW_SQLStore3_Writers.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SMW\MediaWiki\Jobs\JobBase;
 use SMW\MediaWiki\Jobs\UpdateJob;
 use SMW\SemanticData;
-use SMW\SQLStore\PropertyStatisticsTable;
 use SMW\SQLStore\PropertyTableRowDiffer;
 use SMW\SQLStore\EntityStore\EntitySubobjectListIterator;
 use SMW\SQLStore\TableBuilder\FieldType;

Doc Comments +7 added lines, -1 removed lines

@@ -103,6 +103,10 @@ 
 		\Hooks::run( 'SMW::SQLStore::AfterDeleteSubjectComplete', array( $this->store, $title ) );
 	}
 
+	/**
+	 * @param DIWikiPage $subject
+	 * @param SMW\Iterators\MappingIterator $subobjects
+	 */
 	private function doDelete( $id, $subject, $subobjects ) {
 
 		if ( $subject->getNamespace() === SMW_NS_CONCEPT ) { // make sure to clear caches
@@ -142,7 +146,6 @@ 
 	 * @see SMWStore::doDataUpdate
 	 *
 	 * @since 1.8
-	 * @param SMWSemanticData $data
 	 */
 	public function doDataUpdate( SMWSemanticData $semanticData ) {
 		\Hooks::run( 'SMWSQLStore3::updateDataBefore', array( $this->store, $semanticData ) );
@@ -955,6 +958,9 @@ 
 		return ( $new_tid == 0 ) ? $sid : $new_tid;
 	}
 
+	/**
+	 * @param integer $redirectId
+	 */
 	private function addToDeferredUpdate( $oldTitle, $newTitle, $redirectId ) {
 
 		$jobFactory = ApplicationFactory::getInstance()->newJobFactory();

includes/storage/SQLStore/SMW_SQLStore3_Readers.php

Doc Comments +5 added lines, -2 removed lines

@@ -40,6 +40,9 @@ 
 	 */
 	private static $in_getSemanticData = 0;
 
+	/**
+	 * @param SQLStoreFactory $factory
+	 */
 	public function __construct( SMWSQLStore3 $parentStore, $factory ) {
 		$this->store = $parentStore;
 		$this->factory = $factory;
@@ -198,7 +201,7 @@ 
 	 *
 	 * @since 1.8
 	 *
-	 * @param $subject mixed DIWikiPage or null
+	 * @param null|SMWDataItem $subject mixed DIWikiPage or null
 	 * @param $property SMWDIProperty
 	 * @param $requestOptions SMWRequestOptions
 	 *
@@ -684,7 +687,7 @@ 
 	 * @param SMWDataItem $value
 	 * @param SMWRequestOptions|null $requestOptions
 	 *
-	 * @return array of SMWWikiPageValue
+	 * @return SMWDataItem[] of SMWWikiPageValue
 	 */
 	public function getInProperties( SMWDataItem $value, SMWRequestOptions $requestOptions = null ) {
 

src/MediaWiki/Hooks/ArticleDelete.php

Doc Comments +4 added lines, -1 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @param Wikipage $wikiPage
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public function process( $wikiPage ) {
 
@@ -95,6 +95,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $message
+	 */
 	private function log( $message, $context = array() ) {
 
 		if ( $this->logger === null ) {

src/SQLStore/QueryDependency/DependencyLinksTableUpdater.php

Doc Comments +3 added lines, -1 removed lines

@@ -110,7 +110,6 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @param array $dependencyList
 	 */
 	public function deleteDependenciesFromList( array $deleteIdList ) {
 
@@ -243,6 +242,9 @@ 
 		return $id;
 	}
 
+	/**
+	 * @param string $message
+	 */
 	private function log( $message, $context = array() ) {
 
 		if ( $this->logger === null ) {

src/SQLStore/SQLStoreFactory.php

Doc Comments +3 added lines, -3 removed lines

@@ -59,7 +59,7 @@ 
 	/**
 	 * @since 2.2
 	 *
-	 * @return QueryEngine
+	 * @return QueryEngine\QueryEngine
 	 */
 	public function newMasterQueryEngine() {
 		return $this->queryEngineFactory->newQueryEngine();
@@ -68,7 +68,7 @@ 
 	/**
 	 * @since 2.2
 	 *
-	 * @return QueryEngine
+	 * @return QueryEngine\QueryEngine
 	 */
 	public function newSlaveQueryEngine() {
 		return $this->newMasterQueryEngine();
@@ -421,7 +421,7 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @return LoggerInterface
+	 * @return \Psr\Log\LoggerInterface
 	 */
 	public function getLogger() {
 		return ApplicationFactory::getInstance()->getMediaWikiLogger();

src/SQLStore/ConceptCache.php

Doc Comments -1 removed lines

@@ -38,7 +38,6 @@
 	 * @since 2.2
 	 *
 	 * @param SMWSQLStore3 $store
-	 * @param ConceptQuerySegmentBuilder $conceptQueryResolver
 	 */
 	public function __construct( SMWSQLStore3 $store, ConceptQuerySegmentBuilder $conceptQuerySegmentBuilder ) {
 		$this->store = $store;

src/SQLStore/QueryEngine/QuerySegmentListBuildManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public function getErrors() {
 		return $this->errors;
@@ -75,7 +75,7 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @return array
+	 * @return QuerySegment[]
 	 */
 	public function getQuerySegmentList() {
 		return $this->querySegmentList;

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SMW\SQLStore\QueryEngine;
 
-use SMW\DIWikiPage;
 use SMWQuery as Query;
 use SMW\MediaWiki\Database;
 use SMW\SQLStore\SQLStore;

tests/phpunit/TestEnvironment.php

Doc Comments +2 added lines, -2 removed lines

@@ -183,7 +183,7 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @param $originalClassName
+	 * @param string $originalClassName
 	 * @param array $configuration
 	 *
 	 * @return PHPUnit_Framework_MockObject_MockObject
@@ -228,7 +228,7 @@ 
 	 * @since 2.5
 	 *
 	 * @param integer $index
-	 * @param string $url
+	 * @param string $text
 	 *
 	 * @return string
 	 */

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SMW\ApplicationFactory;
 use SMW\DataValueFactory;
 use SMW\DeferredCallableUpdate;
-use SMW\Store;
 use SMW\Localizer;
 use SMW\Tests\Utils\UtilityFactory;
 use SMW\Tests\Utils\Mock\ConfigurableStub;

includes/dataitems/SMW_DI_Property.php

Doc Comments +5 added lines

@@ -307,6 +307,7 @@ 
 	/**
 	 * @since  2.0
 	 *
+	 * @param string $propertyTypeId
 	 * @return self
 	 * @throws PropertyDataTypeLookupExeption
 	 * @throws InvalidArgumentException
@@ -460,6 +461,7 @@ 
 
 	/**
 	 * @deprecated since 2.1, use PropertyRegistry::findPropertyIdByLabel
+	 * @param string $label
 	 */
 	public static function findPropertyID( $label, $useAlias = true ) {
 		return PropertyRegistry::getInstance()->findPropertyIdByLabel( $label, $useAlias );
@@ -493,6 +495,9 @@ 
 		PropertyRegistry::getInstance()->registerPropertyAlias( $id, $label );
 	}
 
+	/**
+	 * @param string $subobjectName
+	 */
 	private function newDIWikiPage( $dbkey, $subobjectName ) {
 
 		// If an inverse marker is present just omit the marker so a normal