SemanticMediaWiki / SemanticMediaWiki

src/PropertySpecificationLookup.php

Doc Comments +16 added lines, -1 removed lines

@@ -77,7 +77,7 @@ 
 	 *
 	 * @param DIProperty $property
 	 *
-	 * @return false|DataItem
+	 * @return \SMWDataItem
 	 */
 	public function getFieldListBy( DIProperty $property ) {
 
@@ -383,6 +383,10 @@ 
 		return $localPropertyDescription;
 	}
 
+	/**
+	 * @param DIProperty $property
+	 * @param string $languageCode
+	 */
 	private function getPredefinedPropertyDescription( $property, $linker, $languageCode ) {
 
 		$description = '';
@@ -411,6 +415,10 @@ 
 		return $message;
 	}
 
+	/**
+	 * @param DIProperty $property
+	 * @param string $languageCode
+	 */
 	private function findLocalPropertyDescription( $property, $linker, $languageCode ) {
 
 		$text = '';
@@ -428,6 +436,10 @@ 
 		return $text;
 	}
 
+	/**
+	 * @param DIProperty $property
+	 * @param string $languageCode
+	 */
 	private function findPreferredPropertyLabel( $property, $languageCode ) {
 
 		$text = '';
@@ -445,6 +457,9 @@ 
 		return $text;
 	}
 
+	/**
+	 * @param DIProperty $property
+	 */
 	private function findTextValueByLanguage( $dataItems, $property, $languageCode ) {
 
 		if ( $dataItems === null || $dataItems === array() ) {

src/SQLStore/QueryEngine/OrderConditionsComplementor.php

Doc Comments +11 added lines, -1 removed lines

@@ -77,7 +77,7 @@ 
 	/**
 	 * @since 2.5
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public function getErrors() {
 		return $this->querySegmentListBuilder->getErrors();
@@ -120,6 +120,9 @@ 
 		return $this->querySegmentListBuilder->getQuerySegmentList();
 	}
 
+	/**
+	 * @param QuerySegment $querySegment
+	 */
 	private function collectExtraDescriptionsFromSortKeys( $querySegment ) {
 
 		$extraDescriptions = array();
@@ -138,6 +141,10 @@ 
 		return $extraDescriptions;
 	}
 
+	/**
+	 * @param string $label
+	 * @param string $order
+	 */
 	private function findExtraDescriptionBy( $querySegment, $label, $order ) {
 
 		$description = null;
@@ -171,6 +178,9 @@ 
 		return $description;
 	}
 
+	/**
+	 * @param QuerySegment $querySegment
+	 */
 	private function addConjunctionFromExtraDescriptions( $querySegment, array $extraDescriptions ) {
 
 		$this->querySegmentListBuilder->setSortKeys(

tests/phpunit/Integration/JSONScript/version2TestCaseConverter.php

Doc Comments +14 added lines

@@ -62,6 +62,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $contents
+	 */
 	private function replaceSpaceIndent( $contents ) {
 
 		// Change the four-space indent to a tab indent
@@ -118,6 +121,9 @@ 
 		return json_encode( $contents, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function findAndReplaceEntity( $name, &$entities ) {
 
 		if ( !isset( $this->contents[$name] ) || $this->contents[$name] === array() ) {
@@ -140,6 +146,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 * @param string $type
+	 */
 	private function findAndReplaceTestCases( $name, $type, &$tests ) {
 
 		if ( !isset( $this->contents[$name] ) || $this->contents[$name] === array() ) {
@@ -159,6 +169,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string $path
+	 * @param string $extension
+	 */
 	private function findFilesFor( $path, $extension ) {
 
 		$files = array();

tests/phpunit/JsonTestCaseContentHandler.php

Doc Comments +4 added lines, -1 removed lines

@@ -117,7 +117,6 @@ 
 	 * @since 2.5
 	 *
 	 * @param array $page
-	 * @param integer $defaultNamespace
 	 */
 	public function createPage( array $page, $namespace ) {
 
@@ -176,6 +175,10 @@ 
 	}
 
 	// http://php.net/manual/en/function.file-get-contents.php
+
+	/**
+	 * @param string $file
+	 */
 	private function getFileContentsWithEncodingDetection( $file ) {
 		$content = file_get_contents( $file );
 		return mb_convert_encoding( $content, 'UTF-8', mb_detect_encoding( $content, 'UTF-8, ISO-8859-1, ISO-8859-2', true ) );

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SMW\Tests;
 
-use SMW\ApplicationFactory;
 use SMW\Message;
 use SMW\Tests\Utils\File\LocalFileUpload;
 use SMW\Tests\Utils\PageCreator;

tests/phpunit/JsonTestCaseScriptRunner.php

Doc Comments +1 added lines, -1 removed lines

@@ -178,7 +178,7 @@
 	/**
 	 * @since 2.2
 	 *
-	 * @param mixed $key
+	 * @param string $key
 	 * @param mixed $value
 	 */
 	protected function changeGlobalSettingTo( $key, $value ) {

Unused Use Statements -3 removed lines

@@ -2,10 +2,7 @@
 
 namespace SMW\Tests;
 
-use SMW\ApplicationFactory;
 use SMW\Tests\Utils\UtilityFactory;
-use SMW\Message;
-use Title;
 
 /**
  * The JsonTestCaseScriptRunner is a convenience provider for `Json` formatted

src/Libs/Time/Timezone.php

Doc Comments +3 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
 	 *
 	 * @param string $identifer
 	 *
-	 * @return false|integer
+	 * @return string
 	 */
 	public static function getIdByAbbreviation( $identifer ) {
 
@@ -208,7 +208,7 @@ 
 	 *
 	 * @param integer $identifer
 	 *
-	 * @return false|string
+	 * @return string
 	 */
 	public static function getTimezoneLiteralById( $identifer ) {
 
@@ -350,7 +350,7 @@ 
 	 * @since 2.5
 	 *
 	 * @param DateTime &$dateTime
-	 * @param string|integer $identifer
+	 * @param integer $identifer
 	 *
 	 * @return string
 	 */

includes/query/SMW_Query.php

Doc Comments +4 added lines, -1 removed lines

@@ -228,6 +228,9 @@ 
 		$this->errors = array_merge( $this->errors, $errors );
 	}
 
+	/**
+	 * @param string $querystring
+	 */
 	public function setQueryString( $querystring ) {
 		$this->queryString = $querystring;
 	}
@@ -322,7 +325,7 @@ 
 	 *
 	 * @param integer $limit
 	 *
-	 * @return Query
+	 * @return SMWQuery
 	 */
 	public function setUnboundLimit( $limit ) {
 		$this->limit = (int)$limit;

tests/phpunit/Unit/Query/Language/SomePropertyTest.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SMW\Query\Language\SomeProperty;
 use SMW\Query\Language\ThingDescription;
 use SMW\Query\Language\ValueDescription;
-use SMW\Query\Language\Conjunction;
 
 /**
  * @covers \SMW\Query\Language\SomeProperty

src/DataValues/ValueValidators/UniquenessConstraintValueValidator.php

Doc Comments +6 added lines

@@ -161,6 +161,9 @@ 
 		return $dataValue instanceof DataValue && $dataValue->getProperty() !== null && $dataValue->getContextPage() !== null && $dataValue->isEnabledFeature( SMW_DV_PVUC );
 	}
 
+	/**
+	 * @param string $hash
+	 */
 	private function tryFindMatchResultFor( $hash, $dataValue ) {
 
 		$descriptionFactory = $this->queryFactory->newDescriptionFactory();
@@ -209,6 +212,9 @@ 
 		return $page;
 	}
 
+	/**
+	 * @param string $valueHash
+	 */
 	private function isKnownBy( $valueHash, $dataValue  ) {
 
 		$contextPage = $dataValue->getContextPage();