Completed
Push — master ( 5f9e66...1f3475 )
by mw
123:57 queued 89:01
created
tests/phpunit/Integration/Query/SortableQueryDBIntegrationTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -122,6 +122,9 @@  discard block
 block discarded – undo
122 122
 		);
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param DIProperty $property
127
+	 */
125 128
 	public function createQueryForSamplePagesThatContain( $property, array &$expectedSubjects ) {
126 129
 
127 130
 		foreach ( $expectedSubjects as $key => $expectedSubject ) {
@@ -159,6 +162,9 @@  discard block
 block discarded – undo
159 162
 		return $query;
160 163
 	}
161 164
 
165
+	/**
166
+	 * @param \SMWDIWikiPage[] $results
167
+	 */
162 168
 	private function assertResultOrder( $expected, $results ) {
163 169
 
164 170
 		$hasSameOrder = true;
Please login to merge, or discard this patch.
src/SQLStore/PropertyTableDefinitionBuilder.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	/**
35 35
 	 * @since 1.9
36 36
 	 *
37
-	 * @param array $diType
37
+	 * @param array $diTypes
38 38
 	 * @param array $specialProperties
39 39
 	 * @param array $userDefinedFixedProperties
40 40
 	 */
@@ -148,6 +148,9 @@  discard block
 block discarded – undo
148 148
 		}
149 149
 	}
150 150
 
151
+	/**
152
+	 * @param string $fixedPropertyTablePrefix
153
+	 */
151 154
 	private function addTableDefinitionForFixedProperties( array $properties, $fixedPropertyTablePrefix ) {
152 155
 		foreach( $properties as $propertyKey => $propetyTableSuffix ) {
153 156
 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Hooks;
6 6
 use SMW\DataTypeRegistry;
7 7
 use SMW\DIProperty;
8
-use SMWDataItem as DataItem;
9 8
 
10 9
 /**
11 10
  * @private
Please login to merge, or discard this patch.
src/ParserParameterProcessor.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @since 1.9
65 65
 	 *
66
-	 * @param mixed $error
66
+	 * @param string $error
67 67
 	 */
68 68
 	public function addError( $error ) {
69 69
 		$this->errors = array_merge( (array)$error === $error ? $error : array( $error ), $this->errors );
@@ -239,6 +239,11 @@  discard block
 block discarded – undo
239 239
 		return $this->parseFromJson( $results );
240 240
 	}
241 241
 
242
+	/**
243
+	 * @param boolean $pipe
244
+	 *
245
+	 * @return string
246
+	 */
242 247
 	private function lookAheadOnNextElement( &$params, &$pipe ) {
243 248
 
244 249
 		$separator = '';
Please login to merge, or discard this patch.
tests/phpunit/JsonTestCaseFileHandler.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -120,6 +120,7 @@  discard block
 block discarded – undo
120 120
 	/**
121 121
 	 * @since 2.2
122 122
 	 *
123
+	 * @param string $version
123 124
 	 * @return boolean
124 125
 	 */
125 126
 	public function requiredToSkipForJsonVersion( $version ) {
@@ -305,6 +306,11 @@  discard block
 block discarded – undo
305 306
 		} );
306 307
 	}
307 308
 
309
+	/**
310
+	 * @param string $index
311
+	 *
312
+	 * @return string
313
+	 */
308 314
 	private function getFileContentsFor( $index ) {
309 315
 
310 316
 		$contents = $this->fileReader->read();
Please login to merge, or discard this patch.
tests/phpunit/Integration/MediaWiki/Hooks/FileUploadIntegrationTest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -5,9 +5,6 @@
 block discarded – undo
5 5
 use SMW\DIWikiPage;
6 6
 use SMW\Localizer;
7 7
 use SMW\Tests\MwDBaseUnitTestCase;
8
-use SMW\Tests\Utils\UtilityFactory;
9
-use SMW\Tests\TestEnvironment;
10
-use Title;
11 8
 
12 9
 /**
13 10
  * @group SMW
Please login to merge, or discard this patch.
includes/storage/SMW_Store.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,8 +90,8 @@
 block discarded – undo
90 90
 	/**
91 91
 	 * @see EntityLookup::getInProperties
92 92
 	 *
93
-	 * @param DataItem $object
94
-	 * @param RequestOptions|null $requestOptions
93
+	 * @param SMWDataItem $object
94
+	 * @param RequestOptions|null $requestoptions
95 95
 	 *
96 96
 	 * @return DataItem[]|[]
97 97
 	 */
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use SMW\DataTypeRegistry;
4 3
 use SMW\DIConcept;
5 4
 use SMW\DIProperty;
6 5
 use SMW\DIWikiPage;
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -198,12 +198,15 @@  discard block
 block discarded – undo
198 198
 		return $this->reader;
199 199
 	}
200 200
 
201
+	/**
202
+	 * @return SemanticData
203
+	 */
201 204
 	public function getSemanticData( DIWikiPage $subject, $filter = false ) {
202 205
 		return $this->getEntityLookup()->getSemanticData( $subject, $filter );
203 206
 	}
204 207
 
205 208
 	/**
206
-	 * @param mixed $subject
209
+	 * @param DIWikiPage $subject
207 210
 	 * @param DIProperty $property
208 211
 	 * @param null $requestOptions
209 212
 	 *
@@ -334,7 +337,7 @@  discard block
 block discarded – undo
334 337
 	/**
335 338
 	 * @param RequestOptions|null $requestOptions
336 339
 	 *
337
-	 * @return CachedListLookup
340
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
338 341
 	 */
339 342
 	public function getPropertiesSpecial( $requestOptions = null ) {
340 343
 		return $this->factory->newPropertyUsageCachedListLookup( $requestOptions );
@@ -343,7 +346,7 @@  discard block
 block discarded – undo
343 346
 	/**
344 347
 	 * @param RequestOptions|null $requestOptions
345 348
 	 *
346
-	 * @return CachedListLookup
349
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
347 350
 	 */
348 351
 	public function getUnusedPropertiesSpecial( $requestOptions = null ) {
349 352
 		return $this->factory->newUnusedPropertyCachedListLookup( $requestOptions );
@@ -352,7 +355,7 @@  discard block
 block discarded – undo
352 355
 	/**
353 356
 	 * @param RequestOptions|null $requestOptions
354 357
 	 *
355
-	 * @return CachedListLookup
358
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
356 359
 	 */
357 360
 	public function getWantedPropertiesSpecial( $requestOptions = null ) {
358 361
 		return $this->factory->newUndeclaredPropertyCachedListLookup( $requestOptions );
@@ -445,7 +448,7 @@  discard block
 block discarded – undo
445 448
 	 * @since 1.8
446 449
 	 *
447 450
 	 * @param SMWRequestOptions|null $requestOptions
448
-	 * @param string $valuecol
451
+	 * @param string $valueCol
449 452
 	 *
450 453
 	 * @return array
451 454
 	 */
Please login to merge, or discard this patch.
src/EntityLookup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	 * @since 2.5
28 28
 	 *
29 29
 	 * @param DIWikiPage $subject
30
-	 * @param string[]|bool $filter
30
+	 * @param boolean $filter
31 31
 	 *
32 32
 	 * @return SemanticData
33 33
 	 */
@@ -70,7 +70,6 @@  discard block
 block discarded – undo
70 70
 	 *
71 71
 	 * @since 2.5
72 72
 	 *
73
-	 * @param DIWikiPage|null $subject
74 73
 	 * @param DIProperty $property
75 74
 	 * @param RequestOptions|null $requestOptions
76 75
 	 *
@@ -110,6 +109,7 @@  discard block
 block discarded – undo
110 109
 	 * @since 2.5
111 110
 	 *
112 111
 	 * @param DIWikiPage|null $subject
112
+	 * @return void
113 113
 	 */
114 114
 	public function resetCacheBy( DIWikiPage $subject = null );
115 115
 
Please login to merge, or discard this patch.
src/SQLStore/EntityStore/DataItemHandlerDispatcher.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
 		return $this->handlers[$type] = $this->newHandlerByType( $type );
59 59
 	}
60 60
 
61
+	/**
62
+	 * @param string $type
63
+	 */
61 64
 	private function newHandlerByType( $type ) {
62 65
 
63 66
 		switch ( $type ) {
Please login to merge, or discard this patch.