SemanticMediaWiki / SemanticMediaWiki

src/EventListenerRegistry.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SMW;
 
 use Onoi\EventDispatcher\EventListenerCollection;
-use Onoi\EventDispatcher\EventDispatcherFactory;
 use SMWExporter as Exporter;
 use SMW\Query\QueryComparator;
 

src/Exporter/DataItemToElementEncoder.php

Doc Comments +4 added lines, -1 removed lines

@@ -30,7 +30,7 @@ 
 	 * @since 2.2
 	 *
 	 * @param integer $dataItemType
-	 * @param Closure $dataItemEncoder
+	 * @param \Closure $dataItemEncoder
 	 */
 	public function registerDataItemEncoder( $dataItemType, \Closure $dataItemEncoder ) {
 		$this->dataItemEncoderMap[$dataItemType] = $dataItemEncoder;
@@ -61,6 +61,9 @@ 
 		throw new RuntimeException( 'Encoder did not return a valid element' );
 	}
 
+	/**
+	 * @param DataItem $dataItem
+	 */
 	private function tryToEncodeDataItem( $dataItem ) {
 
 		foreach ( $this->dataItemEncoderMap as $dataItemType => $dataItemEncoder ) {

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace SMW\Exporter;
 
 use SMW\Exporter\Element\ExpResource;
-use SMW\Exporter\Element\ExpNsResource;
-use SMW\Exporter\Element\ExpElement;
 use SMW\Exporter\Element\ExpLiteral;
 use SMW\Exporter\Element;
 use SMWExporter as Exporter;

src/Exporter/DataItemToExpResourceEncoder.php

Unused Use Statements -4 removed lines

@@ -10,13 +10,9 @@
 use SMW\DIProperty;
 use SMW\Store;
 use SMW\DataValueFactory;
-use SMW\ApplicationFactory;
-use Onoi\Cache\Cache;
-
 use SMWExporter as Exporter;
 use SMWDataItem as DataItem;
 use RuntimeException;
-use Title;
 
 /**
  * @license GNU GPL v2+

Doc Comments +7 added lines

@@ -177,6 +177,10 @@ 
 		return $resource;
 	}
 
+	/**
+	 * @param DIWikiPage $diWikiPage
+	 * @param string $modifier
+	 */
 	private function newExpNsResource( $diWikiPage, $modifier ) {
 
 		 $importDataItem = $this->tryToFindImportDataItem( $diWikiPage, $modifier );
@@ -254,6 +258,9 @@ 
 		);
 	}
 
+	/**
+	 * @return DataItem
+	 */
 	private function tryToFindImportDataItem( DIWikiPage $diWikiPage, $modifier ) {
 
 		$importDataItems = null;

src/Factbox/CachedFactbox.php

Doc Comments +2 added lines, -1 removed lines

@@ -45,7 +45,7 @@ 
 	 * @since 1.9
 	 *
 	 * @param Cache|null $cache
-	 * @param stdClass $cacheOptions
+	 * @param \stdClass $cacheOptions
 	 */
 	public function __construct( Cache $cache = null, \stdClass $cacheOptions ) {
 		$this->cache = $cache;
@@ -251,6 +251,7 @@ 
 	/**
 	 * Cached content is serialized in an associative array following:
 	 * { 'revId' => $revisionId, 'text' => (...) }
+	 * @param string $key
 	 */
 	private function saveToCache( $key, array $content ) {
 

src/Factbox/Factbox.php

Doc Comments +6 added lines, -5 removed lines

@@ -136,7 +136,7 @@ 
 	 *
 	 * @since 1.9
 	 *
-	 * @return string|null
+	 * @return string
 	 */
 	public function getContent() {
 		return $this->content;
@@ -193,7 +193,7 @@ 
 	 *
 	 * @since 1.9
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getModules() {
 		return array(
@@ -211,9 +211,10 @@ 
 	 *
 	 * @since 1.9
 	 *
-	 * @return integer $showFactbox
+	 * @param string|null $showFactbox
+	 * @return string $showFactbox
 	 *
-	 * @return string|null
+	 * @return string
 	 */
 	protected function fetchContent( $showFactbox = SMW_FACTBOX_NONEMPTY ) {
 
@@ -270,7 +271,7 @@ 
 	 *
 	 * @param SMWSemanticData $semanticData
 	 *
-	 * @return string|null
+	 * @return string
 	 */
 	protected function createTable( SemanticData $semanticData ) {
 

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use SMW\MediaWiki\HtmlTableRenderer;
 use SMW\MediaWiki\MessageBuilder;
 use SMW\ParserData;
-use SMW\Profiler;
 use SMW\SemanticData;
 use SMW\Store;
 use SMWInfolink;

src/HashBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
 	 *
 	 * @param string
 	 *
-	 * @return DIWikiPage|null
+	 * @return DIWikiPage
 	 */
 	public static function newDiWikiPageFromHash( $hash ) {
 

src/Maintenance/ConceptCacheRebuilder.php

Doc Comments +9 added lines

@@ -199,6 +199,9 @@ 
 		return $skip;
 	}
 
+	/**
+	 * @return string
+	 */
 	private function performAction( Title $title, DIConcept $concept ) {
 		$this->reportMessage( "($this->lines) " );
 
@@ -256,6 +259,9 @@ 
 		return $titleLookup->selectByIdRange( $this->startId, $endId );
 	}
 
+	/**
+	 * @param string $key
+	 */
 	private function hasOption( $key ) {
 		return isset( $this->options[$key] );
 	}
@@ -266,6 +272,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $date
+	 */
 	private function getCacheDateInfo( $date ) {
 		return date( 'Y-m-d H:i:s', $date ) . ' (' . floor( ( strtotime( 'now' ) - $date ) / 60 ) . ' minutes old), ';
 	}

src/Maintenance/DataRebuilder.php

Doc Comments +14 added lines, -1 removed lines

@@ -160,6 +160,9 @@ 
 		return $this->rebuildCount;
 	}
 
+	/**
+	 * @param string $message
+	 */
 	private function doRebuildPagesFor( $message ) {
 
 		$this->reportMessage( $message  . "\n" );
@@ -305,6 +308,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param double $byIdDataRebuildDispatcher
+	 */
 	private function deleteMarkedSubjects( $byIdDataRebuildDispatcher ) {
 
 		$matches = array();
@@ -338,6 +344,9 @@ 
 		$this->reportMessage( "\n\n{$matchesCount} IDs removed.\n\n" );
 	}
 
+	/**
+	 * @param string $startIdFile
+	 */
 	private function idFileIsWritable( $startIdFile ) {
 
 		if ( !is_writable( file_exists( $startIdFile ) ? $startIdFile : dirname( $startIdFile ) ) ) {
@@ -354,7 +363,7 @@ 
 	}
 
 	/**
-	 * @param array $options
+	 * @param Options $options
 	 */
 	private function setFiltersFromOptions( Options $options ) {
 		$this->filters = array();
@@ -439,6 +448,10 @@ 
 		}
 	}
 
+	/**
+	 * @param boolean $verbose
+	 * @param string $progress
+	 */
 	private function doPrintDotProgressIndicator( $verbose, $progress ) {
 
 		if ( ( $this->rebuildCount - 1 ) % 60 === 0 ) {

src/MediaWiki/Api/ApiRequestParameterFormatter.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 	 *
 	 * @since 1.9
 	 *
-	 * @return ObjectDictionary
+	 * @return SimpleDictionary
 	 */
 	protected function formatAskArgs() {