Completed
Push — master ( 944e8c...873a6a )
by mw
32:14
created
includes/storage/SQLStore/SMW_SQLStore3.php 1 patch
Doc Comments   +10 added lines, -7 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return $this->reader;
237 237
 	}
238 238
 
239
+	/**
240
+	 * @return SemanticData
241
+	 */
239 242
 	public function getSemanticData( DIWikiPage $subject, $filter = false ) {
240 243
 
241 244
 		$result = $this->cachedValueLookupStore->getSemanticData(
@@ -247,9 +250,9 @@  discard block
 block discarded – undo
247 250
 	}
248 251
 
249 252
 	/**
250
-	 * @param mixed $subject
253
+	 * @param DIWikiPage $subject
251 254
 	 * @param DIProperty $property
252
-	 * @param null $requestoptions
255
+	 * @param null $requestOptions
253 256
 	 *
254 257
 	 * @return SMWDataItem[]
255 258
 	 */
@@ -386,7 +389,7 @@  discard block
 block discarded – undo
386 389
 	/**
387 390
 	 * @param RequestOptions|null $requestOptions
388 391
 	 *
389
-	 * @return CachedListLookup
392
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
390 393
 	 */
391 394
 	public function getPropertiesSpecial( $requestOptions = null ) {
392 395
 		return $this->factory->newPropertyUsageCachedListLookup( $requestOptions );
@@ -395,7 +398,7 @@  discard block
 block discarded – undo
395 398
 	/**
396 399
 	 * @param RequestOptions|null $requestOptions
397 400
 	 *
398
-	 * @return CachedListLookup
401
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
399 402
 	 */
400 403
 	public function getUnusedPropertiesSpecial( $requestOptions = null ) {
401 404
 		return $this->factory->newUnusedPropertyCachedListLookup( $requestOptions );
@@ -404,7 +407,7 @@  discard block
 block discarded – undo
404 407
 	/**
405 408
 	 * @param RequestOptions|null $requestOptions
406 409
 	 *
407
-	 * @return CachedListLookup
410
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
408 411
 	 */
409 412
 	public function getWantedPropertiesSpecial( $requestOptions = null ) {
410 413
 		return $this->factory->newUndeclaredPropertyCachedListLookup( $requestOptions );
@@ -452,7 +455,7 @@  discard block
 block discarded – undo
452 455
 	 *
453 456
 	 * @since 1.8
454 457
 	 * @param Title $concept
455
-	 * @return array of error strings (empty if no errors occurred)
458
+	 * @return string[] of error strings (empty if no errors occurred)
456 459
 	 */
457 460
 	public function refreshConceptCache( Title $concept ) {
458 461
 		return $this->factory->newMasterConceptCache()->refreshConceptCache( $concept );
@@ -494,7 +497,7 @@  discard block
 block discarded – undo
494 497
 	 * @since 1.8
495 498
 	 *
496 499
 	 * @param SMWRequestOptions|null $requestOptions
497
-	 * @param string $valuecol
500
+	 * @param string $valueCol
498 501
 	 *
499 502
 	 * @return array
500 503
 	 */
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3_Readers.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	 *
186 186
 	 * @since 1.8
187 187
 	 *
188
-	 * @param $subject mixed DIWikiPage or null
188
+	 * @param null|DataItem $subject mixed DIWikiPage or null
189 189
 	 * @param $property SMWDIProperty
190 190
 	 * @param $requestOptions SMWRequestOptions
191 191
 	 *
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
654 654
 	 * @param SMWDataItem $value
655 655
 	 * @param SMWRequestOptions|null $requestOptions
656 656
 	 *
657
-	 * @return array of SMWWikiPageValue
657
+	 * @return DataItem[] of SMWWikiPageValue
658 658
 	 */
659 659
 	public function getInProperties( SMWDataItem $value, SMWRequestOptions $requestOptions = null ) {
660 660
 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 use SMW\DataTypeRegistry;
4 4
 use SMW\DIWikiPage;
5 5
 use SMW\SQLStore\TableDefinition;
6
-use SMWDataItem as DataItem;
7 6
 
8 7
 /**
9 8
  * Class to provide all basic read methods for SMWSQLStore3.
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -243,6 +243,7 @@
 block discarded – undo
243 243
 	 * Create some initial DB entries for important built-in properties. Having the DB contents predefined
244 244
 	 * allows us to safe DB calls when certain data is needed. At the same time, the entries in the DB
245 245
 	 * make sure that DB-based functions work as with all other properties.
246
+	 * @param boolean $verbose
246 247
 	 */
247 248
 	protected function setupPredefinedProperties( $verbose, DatabaseBase $db ) {
248 249
 		global $wgDBtype;
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use SMW\MediaWiki\Jobs\UpdateJob;
4
-use SMW\MediaWiki\Jobs\JobBase;
5
-
6 3
 use Onoi\MessageReporter\MessageReporter;
7 4
 
8 5
 /**
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3_Writers.php 2 patches
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,6 +95,9 @@  discard block
 block discarded – undo
95 95
 		wfRunHooks( 'SMW::SQLStore::AfterDeleteSubjectComplete', array( $this->store, $title ) );
96 96
 	}
97 97
 
98
+	/**
99
+	 * @param DIWikiPage $subject
100
+	 */
98 101
 	private function doDeleteReferencesFor( $id, $subject, $subobjects ) {
99 102
 
100 103
 		if ( $subject->getNamespace() === SMW_NS_CONCEPT ) { // make sure to clear caches
@@ -134,7 +137,6 @@  discard block
 block discarded – undo
134 137
 	 * @see SMWStore::doDataUpdate
135 138
 	 *
136 139
 	 * @since 1.8
137
-	 * @param SMWSemanticData $data
138 140
 	 */
139 141
 	public function doDataUpdate( SMWSemanticData $semanticData ) {
140 142
 		wfRunHooks( 'SMWSQLStore3::updateDataBefore', array( $this->store, $semanticData ) );
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use SMW\DIWikiPage;
6 6
 use SMW\SemanticData;
7
-
8 7
 use Title;
9
-
10 8
 use RuntimeException;
11 9
 
12 10
 /**
Please login to merge, or discard this patch.
src/ApplicationFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
 	/**
203 203
 	 * @since 2.0
204 204
 	 *
205
-	 * @return Cache
205
+	 * @return string
206 206
 	 */
207 207
 	public function getCache() {
208 208
 		return $this->callbackLoader->singleton( 'Cache' );
Please login to merge, or discard this patch.
src/DeferredRequestDispatchManager.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -109,6 +109,9 @@  discard block
 block discarded – undo
109 109
 		return true;
110 110
 	}
111 111
 
112
+	/**
113
+	 * @param string $type
114
+	 */
112 115
 	private function getDispatchableCallbackJobFor( $type ) {
113 116
 
114 117
 		$jobFactory = ApplicationFactory::getInstance()->newJobFactory();
@@ -139,6 +142,9 @@  discard block
 block discarded – undo
139 142
 		return $callback;
140 143
 	}
141 144
 
145
+	/**
146
+	 * @param string $type
147
+	 */
142 148
 	private function doPreliminaryCheckForType( $type, array $parameters ) {
143 149
 
144 150
 		if ( $type !== 'SMW\ParserCachePurgeJob' && $type !== 'SMW\UpdateJob' ) {
@@ -163,6 +169,10 @@  discard block
 block discarded – undo
163 169
 		return self::$canConnectToUrl = $this->httpRequest->ping();
164 170
 	}
165 171
 
172
+	/**
173
+	 * @param string $type
174
+	 * @param \Closure $dispatchableCallbackJob
175
+	 */
166 176
 	private function doDispatchAsyncJobFor( $type, $title, $parameters, $dispatchableCallbackJob ) {
167 177
 
168 178
 		$parameters['async-job'] = array(
Please login to merge, or discard this patch.
DVDescriptionDeserializer/RecordValueDescriptionDeserializer.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -93,6 +93,9 @@
 block discarded – undo
93 93
 		}
94 94
 	}
95 95
 
96
+	/**
97
+	 * @param integer $propertyIndex
98
+	 */
96 99
 	private function getDescriptionForProperty( $diProperty, $values, &$valueIndex, $propertyIndex ) {
97 100
 
98 101
 		$values[$valueIndex] = str_replace( "-3B", ";", $values[$valueIndex] );
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SMW\SPARQLStore\QueryEngine\QueryEngine;
6 6
 use SMW\SPARQLStore\QueryEngine\EngineOptions;
7 7
 use SMW\SPARQLStore\QueryEngine\QueryResultFactory;
8
-use SMW\DIProperty;
9 8
 use SMWQuery as Query;
10 9
 
11 10
 /**
Please login to merge, or discard this patch.
DVDescriptionDeserializer/TimeValueDescriptionDeserializer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -91,6 +91,9 @@
 block discarded – undo
91 91
 		return $description;
92 92
 	}
93 93
 
94
+	/**
95
+	 * @param \SMWDataItem $dataItem
96
+	 */
94 97
 	private function getUpperLimit( $dataItem ) {
95 98
 
96 99
 		$prec = $dataItem->getPrecision();
Please login to merge, or discard this patch.
src/Deserializers/ExpDataDeserializer.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@
 block discarded – undo
50 50
 		return new ExpData( ExpElement::newFromSerialization( $subject ) );
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param ExpData $expData
55
+	 */
53 56
 	private function doDeserialize( $serialization, $expData ) {
54 57
 
55 58
 		foreach ( $serialization['data'] as $data ) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,9 @@
 block discarded – undo
3 3
 namespace SMW\Deserializers;
4 4
 
5 5
 use Deserializers\Deserializer;
6
-use SMW\Serializers\ExpDataSerializer;
7 6
 use SMW\Exporter\Element\ExpElement;
8 7
 use SMWExpData as ExpData;
9 8
 use OutOfBoundsException;
10
-use RuntimeException;
11 9
 
12 10
 /**
13 11
  * @license GNU GPL v2+
Please login to merge, or discard this patch.