SemanticMediaWiki / SemanticMediaWiki

tests/phpunit/Utils/MwApiFactory.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use ImportReporter;
 use WikiImporter;
 use RequestContext;
-
 use RuntimeException;
 
 /**

tests/phpunit/Utils/MwDatabaseTableBuilder.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use SMW\DIWikiPage;
 use SMW\SemanticData;
-
 use Title;
-
 use RuntimeException;
 
 /**

tests/phpunit/Utils/PageDeleter.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use ImportReporter;
 use WikiImporter;
 use RequestContext;
-
 use RuntimeException;
 
 /**

includes/query/SMW_QueryParser.php

Doc Comments +9 added lines

@@ -134,6 +134,7 @@ 
 	 * but just controls query generation. For general effect, the default namespaces
 	 * should be set to NULL.
 	 *
+	 * @param boolean $setNS
 	 * @return Description|null
 	 */
 	private function getSubqueryDescription( &$setNS ) {
@@ -242,6 +243,7 @@ 
 	 * be the content of "[[ ... ]]". Returns NULL upon error.
 	 *
 	 * Parameters $setNS has the same use as in getSubqueryDescription().
+	 * @param boolean $setNS
 	 */
 	private function getLinkDescription( &$setNS ) {
 		// This method is called when we encountered an opening '[['. The following
@@ -424,6 +426,7 @@ 
 	 * a category or property) and create a suitable description.
 	 * The first chunk behind the "[[" has already been read and is
 	 * passed as a parameter.
+	 * @param string $firstChunk
 	 */
 	private function getArticleDescription( $firstChunk, &$setNS ) {
 		$chunk = $firstChunk;
@@ -469,6 +472,10 @@ 
 		return $this->finishLinkDescription( $chunk, true, $result, $setNS );
 	}
 
+	/**
+	 * @param boolean $hasNamespaces
+	 * @param Description|null $result
+	 */
 	private function finishLinkDescription( $chunk, $hasNamespaces, $result, &$setNS ) {
 		if ( is_null( $result ) ) { // no useful information or concrete error found
 			$this->descriptionProcessor->addErrorForMsgCode( 'smw_unexpectedpart', $chunk ); // was smw_badqueryatom
@@ -565,6 +572,7 @@ 
 	/**
 	 * Enter a new subblock in the query, which must at some time be terminated by the
 	 * given $endstring delimiter calling popDelimiter();
+	 * @param string $endstring
 	 */
 	private function pushDelimiter( $endstring ) {
 		array_push( $this->separatorStack, $endstring );
@@ -574,6 +582,7 @@ 
 	 * Exit a subblock in the query ending with the given delimiter.
 	 * If the delimiter does not match the top-most open block, false
 	 * will be returned. Otherwise return true.
+	 * @param string $endstring
 	 */
 	private function popDelimiter( $endstring ) {
 		$topdelim = array_pop( $this->separatorStack );

Unused Use Statements -3 removed lines

@@ -2,13 +2,10 @@
 
 use SMW\Query\Language\ClassDescription;
 use SMW\Query\Language\ConceptDescription;
-use SMW\Query\Language\Conjunction;
 use SMW\Query\Language\Description;
-use SMW\Query\Language\Disjunction;
 use SMW\Query\Language\NamespaceDescription;
 use SMW\Query\Language\SomeProperty;
 use SMW\Query\Language\ThingDescription;
-use SMW\Query\Language\ValueDescription;
 use SMW\Query\Parser\DescriptionProcessor;
 
 /**

tests/phpunit/includes/parserhooks/SubobjectParserFunctionTest.php

Unused Use Statements -3 removed lines

@@ -3,7 +3,6 @@ 
 namespace SMW\Tests;
 
 use SMW\Tests\Utils\UtilityFactory;
-
 use SMW\SubobjectParserFunction;
 use SMW\Subobject;
 use SMW\ParserParameterFormatter;
@@ -11,8 +10,6 @@ 
 use SMW\ParserData;
 use SMW\DIProperty;
 use SMW\Localizer;
-
-use SMWDataItem;
 use Title;
 use ParserOutput;
 

src/Query/Parser/DescriptionProcessor.php

Doc Comments +5 added lines

@@ -166,6 +166,7 @@ 
 	 *
 	 * The return value is the expected combined description. The object $currentDescription will
 	 * also be changed (if it was non-NULL).
+	 * @param integer $compoundType
 	 */
 	private function getCompoundDescription( Description $currentDescription = null, Description $newDescription = null, $compoundType = SMW_CONJUNCTION_QUERY ) {
 
@@ -201,6 +202,10 @@ 
 		}
 	}
 
+	/**
+	 * @param Description $currentDescription
+	 * @param Description $newDescription
+	 */
 	private function newCompoundDescriptionFor( $compoundType, $currentDescription, $newDescription ) {
 
 		if ( ( ( $compoundType & SMW_CONJUNCTION_QUERY ) != 0 && ( $currentDescription instanceof Conjunction ) ) ||

src/InTextAnnotationParser.php

Doc Comments +4 added lines, -4 removed lines

@@ -145,7 +145,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return text
+	 * @return string
 	 */
 	public static function decodeSquareBracket( $text ) {
 		return str_replace( array( '%5B', '%5D' ), array( '[', ']' ), $text );
@@ -156,7 +156,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return text
+	 * @return string
 	 */
 	public static function obscureAnnotation( $text ) {
 		return preg_replace_callback(
@@ -173,7 +173,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return text
+	 * @return string
 	 */
 	public static function removeAnnotation( $text ) {
 		return preg_replace_callback(
@@ -230,7 +230,7 @@ 
 	 *
 	 * @since 1.9
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	protected function getModules() {
 		return array(

includes/articlepages/SMW_OrderedListPage.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 	/**
 	 * @since 1.9
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public function process() {
 

src/Deserializers/DVDescriptionDeserializer/MonolingualTextValueDescriptionDeserializer.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SMW\SPARQLStore\QueryEngine\QueryEngine;
 use SMW\SPARQLStore\QueryEngine\EngineOptions;
 use SMW\SPARQLStore\QueryEngine\QueryResultFactory;
-use SMW\DIProperty;
 use SMWQuery as Query;
 
 /**

Doc Comments +3 added lines

@@ -91,6 +91,9 @@
 		return new Conjunction( $subdescriptions );
 	}
 
+	/**
+	 * @param \SMWDataValue $dataValue
+	 */
 	private function newSubdescription( $dataValue, $comparator ) {
 
 		$description = new ValueDescription(