Inspection of "Merge pull request #1388 from SemanticMediaWiki/fo..." - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 944e8c...873a6a )

by mw

created 2016-01-24 23:29 UTC

Status

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -5,8 +5,6 @@
 block discarded – undo
 use SMW\SQLStore\ByIdDataRebuildDispatcher;
 use SMW\ApplicationFactory;
 use SMW\SQLStore\SQLStore;
-use SMW\DIWikiPage;
-use SMW\SemanticData;
 
 /**
  * @covers \SMW\SQLStore\ByIdDataRebuildDispatcher

Please login to merge, or discard this patch.

tests/phpunit/Unit/SQLStore/PropertyTableOutdatedReferenceDisposerTest.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -3,7 +3,6 @@
 block discarded – undo
 namespace SMW\Tests\SQLStore;
 
 use SMW\SQLStore\PropertyTableOutdatedReferenceDisposer;
-use Title;
 
 /**
  * @covers \SMW\SQLStore\PropertyTableOutdatedReferenceDisposer

Please login to merge, or discard this patch.

Unit/SQLStore/QueryEngine/Interpreter/ConceptDescriptionInterpreterTest.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -7,7 +7,6 @@
 block discarded – undo
 use SMW\SQLStore\QueryEngine\QuerySegmentListBuilder;
 use SMW\Query\Language\ConceptDescription;
 use SMW\DIWikiPage;
-use SMWDIBlob as DIBlob;
 
 /**
  * @covers \SMW\SQLStore\QueryEngine\Interpreter\ConceptDescriptionInterpreter

Please login to merge, or discard this patch.

Unit/SQLStore/QueryEngine/Interpreter/ValueDescriptionInterpreterTest.php 1 patch

Unused Use Statements -4 removed lines patch added patch discarded remove patch

@@ -3,14 +3,10 @@
 block discarded – undo
 namespace SMW\Tests\SQLStore\QueryEngine\Interpreter;
 
 use SMW\Tests\Utils\UtilityFactory;
-
 use SMW\SQLStore\QueryEngine\Interpreter\ValueDescriptionInterpreter;
 use SMW\SQLStore\QueryEngine\QuerySegmentListBuilder;
-
 use SMW\Query\Language\ValueDescription;
-
 use SMW\DIWikiPage;
-use SMWDIBlob as DIBlob;
 
 /**
  * @covers \SMW\SQLStore\QueryEngine\Interpreter\ValueDescriptionInterpreter

Please login to merge, or discard this patch.

tests/phpunit/Unit/SQLStore/SQLStoreFactoryTest.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -3,7 +3,6 @@
 block discarded – undo
 namespace SMW\Tests\SQLStore;
 
 use SMW\SQLStore\SQLStoreFactory;
-use SMW\Store;
 use SMWSQLStore3;
 
 /**

Please login to merge, or discard this patch.

tests/phpunit/Utils/ByPageSemanticDataFinder.php 2 patches

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Store $store
 	 *
-	 * @return PageDataFetcher
+	 * @return ByPageSemanticDataFinder
 	 */
 	public function setStore( Store $store ) {
 		$this->store = $store;
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Title $title
 	 *
-	 * @return PageDataFetcher
+	 * @return ByPageSemanticDataFinder
 	 */
 	public function setTitle( Title $title ) {
 		$this->title = $title;

Please login to merge, or discard this patch.

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -4,9 +4,7 @@
 block discarded – undo
 
 use SMW\DIWikiPage;
 use SMW\SemanticData;
-
 use Title;
-
 use RuntimeException;
 
 /**

Please login to merge, or discard this patch.

tests/phpunit/Utils/Fixtures/Facts/BerlinFactsheet.php 2 patches

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -97,7 +97,7 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAreaValue() {
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getFoundedValue() {
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAverageHighTemperatureValue() {
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationValue() {
 
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationDensityValue() {
 

Please login to merge, or discard this patch.

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -10,13 +10,10 @@
 block discarded – undo
 use SMW\Tests\Utils\Fixtures\Properties\PopulationDensityProperty;
 use SMW\Tests\Utils\Fixtures\Properties\CityCategory;
 use SMW\Tests\Utils\Fixtures\Properties\LocatedInProperty;
-
 use SMW\DIWikiPage;
-use SMW\DIProperty;
 use SMW\DataValueFactory;
 use SMW\Subobject;
 use SMW\SemanticData;
-
 use RuntimeException;
 
 /**

Please login to merge, or discard this patch.

tests/phpunit/Utils/Fixtures/Facts/FranceFactsheet.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -85,7 +85,7 @@
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 

Please login to merge, or discard this patch.

Unused Use Statements -5 removed lines patch added patch discarded remove patch

@@ -5,15 +5,10 @@
 block discarded – undo
 use SMW\Tests\Utils\UtilityFactory;
 use SMW\Tests\Utils\Fixtures\Properties\CountryCategory;
 use SMW\Tests\Utils\Fixtures\Properties\LocatedInProperty;
-
 use SMW\DIWikiPage;
-use SMW\DIProperty;
 use SMW\DataValueFactory;
-use SMW\Subobject;
 use SMW\SemanticData;
 
-use RuntimeException;
-
 /**
  * @license GNU GPL v2+
  * @since 2.1

Please login to merge, or discard this patch.

tests/phpunit/Utils/Fixtures/Facts/ParisFactsheet.php 2 patches

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAreaValue() {
 
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAverageHighTemperatureValue() {
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Paris
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationValue() {
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Paris
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationDensityValue() {
 

Please login to merge, or discard this patch.

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -10,13 +10,10 @@
 block discarded – undo
 use SMW\Tests\Utils\Fixtures\Properties\PopulationDensityProperty;
 use SMW\Tests\Utils\Fixtures\Properties\CityCategory;
 use SMW\Tests\Utils\Fixtures\Properties\LocatedInProperty;
-
 use SMW\DIWikiPage;
-use SMW\DIProperty;
 use SMW\DataValueFactory;
 use SMW\Subobject;
 use SMW\SemanticData;
-
 use RuntimeException;
 
 /**

Please login to merge, or discard this patch.

		@@ -97,7 +97,7 @@ discard block
		block discarded – undo
97	97	/**
98	98	* @since 2.1
99	99	*
100		- * @return DataValue
	100	+ * @return \SMWDataValue
101	101	*/
102	102	public function getLocatedInValue() {
103	103
		@@ -114,7 +114,7 @@ discard block
		block discarded – undo
114	114	*
115	115	* @see https://en.wikipedia.org/wiki/Berlin
116	116	*
117		- * @return DataValue
	117	+ * @return \SMWDataValue
118	118	*/
119	119	public function getAreaValue() {
120	120
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	*
132	132	* @see https://en.wikipedia.org/wiki/Berlin
133	133	*
134		- * @return DataValue
	134	+ * @return \SMWDataValue
135	135	*/
136	136	public function getFoundedValue() {
137	137
		@@ -148,7 +148,7 @@ discard block
		block discarded – undo
148	148	*
149	149	* @see https://en.wikipedia.org/wiki/Berlin
150	150	*
151		- * @return DataValue
	151	+ * @return \SMWDataValue
152	152	*/
153	153	public function getAverageHighTemperatureValue() {
154	154
		@@ -166,7 +166,7 @@ discard block
		block discarded – undo
166	166	*
167	167	* @see https://en.wikipedia.org/wiki/Berlin
168	168	*
169		- * @return DataValue
	169	+ * @return \SMWDataValue
170	170	*/
171	171	public function getPopulationValue() {
172	172
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	*
184	184	* @see https://en.wikipedia.org/wiki/Demographics_of_Berlin
185	185	*
186		- * @return DataValue
	186	+ * @return \SMWDataValue
187	187	*/
188	188	public function getPopulationDensityValue() {
189	189

		@@ -5,8 +5,6 @@
		block discarded – undo
5	5	use SMW\SQLStore\ByIdDataRebuildDispatcher;
6	6	use SMW\ApplicationFactory;
7	7	use SMW\SQLStore\SQLStore;
8		-use SMW\DIWikiPage;
9		-use SMW\SemanticData;
10	8
11	9	/**
12	10	* @covers \SMW\SQLStore\ByIdDataRebuildDispatcher

		@@ -3,7 +3,6 @@
		block discarded – undo
3	3	namespace SMW\Tests\SQLStore;
4	4
5	5	use SMW\SQLStore\PropertyTableOutdatedReferenceDisposer;
6		-use Title;
7	6
8	7	/**
9	8	* @covers \SMW\SQLStore\PropertyTableOutdatedReferenceDisposer

		@@ -7,7 +7,6 @@
		block discarded – undo
7	7	use SMW\SQLStore\QueryEngine\QuerySegmentListBuilder;
8	8	use SMW\Query\Language\ConceptDescription;
9	9	use SMW\DIWikiPage;
10		-use SMWDIBlob as DIBlob;
11	10
12	11	/**
13	12	* @covers \SMW\SQLStore\QueryEngine\Interpreter\ConceptDescriptionInterpreter

		@@ -3,14 +3,10 @@
		block discarded – undo
3	3	namespace SMW\Tests\SQLStore\QueryEngine\Interpreter;
4	4
5	5	use SMW\Tests\Utils\UtilityFactory;
6		-
7	6	use SMW\SQLStore\QueryEngine\Interpreter\ValueDescriptionInterpreter;
8	7	use SMW\SQLStore\QueryEngine\QuerySegmentListBuilder;
9		-
10	8	use SMW\Query\Language\ValueDescription;
11		-
12	9	use SMW\DIWikiPage;
13		-use SMWDIBlob as DIBlob;
14	10
15	11	/**
16	12	* @covers \SMW\SQLStore\QueryEngine\Interpreter\ValueDescriptionInterpreter

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	*
34	34	* @param Store $store
35	35	*
36		- * @return PageDataFetcher
	36	+ * @return ByPageSemanticDataFinder
37	37	*/
38	38	public function setStore( Store $store ) {
39	39	$this->store = $store;
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	*
46	46	* @param Title $title
47	47	*
48		- * @return PageDataFetcher
	48	+ * @return ByPageSemanticDataFinder
49	49	*/
50	50	public function setTitle( Title $title ) {
51	51	$this->title = $title;

		@@ -4,9 +4,7 @@
		block discarded – undo
4	4
5	5	use SMW\DIWikiPage;
6	6	use SMW\SemanticData;
7		-
8	7	use Title;
9		-
10	8	use RuntimeException;
11	9
12	10	/**

		@@ -10,13 +10,10 @@
		block discarded – undo
10	10	use SMW\Tests\Utils\Fixtures\Properties\PopulationDensityProperty;
11	11	use SMW\Tests\Utils\Fixtures\Properties\CityCategory;
12	12	use SMW\Tests\Utils\Fixtures\Properties\LocatedInProperty;
13		-
14	13	use SMW\DIWikiPage;
15		-use SMW\DIProperty;
16	14	use SMW\DataValueFactory;
17	15	use SMW\Subobject;
18	16	use SMW\SemanticData;
19		-
20	17	use RuntimeException;
21	18
22	19	/**

		@@ -85,7 +85,7 @@
		block discarded – undo
85	85	/**
86	86	* @since 2.1
87	87	*
88		- * @return DataValue
	88	+ * @return \SMWDataValue
89	89	*/
90	90	public function getLocatedInValue() {
91	91

		@@ -5,15 +5,10 @@
		block discarded – undo
5	5	use SMW\Tests\Utils\UtilityFactory;
6	6	use SMW\Tests\Utils\Fixtures\Properties\CountryCategory;
7	7	use SMW\Tests\Utils\Fixtures\Properties\LocatedInProperty;
8		-
9	8	use SMW\DIWikiPage;
10		-use SMW\DIProperty;
11	9	use SMW\DataValueFactory;
12		-use SMW\Subobject;
13	10	use SMW\SemanticData;
14	11
15		-use RuntimeException;
16		-
17	12	/**
18	13	* @license GNU GPL v2+
19	14	* @since 2.1

		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	/**
96	96	* @since 2.1
97	97	*
98		- * @return DataValue
	98	+ * @return \SMWDataValue
99	99	*/
100	100	public function getLocatedInValue() {
101	101
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	*
113	113	* @see https://en.wikipedia.org/wiki/Berlin
114	114	*
115		- * @return DataValue
	115	+ * @return \SMWDataValue
116	116	*/
117	117	public function getAreaValue() {
118	118
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	*
131	131	* @see https://en.wikipedia.org/wiki/Berlin
132	132	*
133		- * @return DataValue
	133	+ * @return \SMWDataValue
134	134	*/
135	135	public function getAverageHighTemperatureValue() {
136	136
		@@ -148,7 +148,7 @@ discard block
		block discarded – undo
148	148	*
149	149	* @see https://en.wikipedia.org/wiki/Demographics_of_Paris
150	150	*
151		- * @return DataValue
	151	+ * @return \SMWDataValue
152	152	*/
153	153	public function getPopulationValue() {
154	154
		@@ -165,7 +165,7 @@ discard block
		block discarded – undo
165	165	*
166	166	* @see https://en.wikipedia.org/wiki/Demographics_of_Paris
167	167	*
168		- * @return DataValue
	168	+ * @return \SMWDataValue
169	169	*/
170	170	public function getPopulationDensityValue() {
171	171

SemanticMediaWiki / SemanticMediaWiki

Push — master ( 944e8c...873a6a )

Status

Category

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements -4 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements -5 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch