Completed
Push — master ( 944e8c...873a6a )
by mw
32:14
created
src/ParserFunctions/DocumentationParserFunction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	 * @param Parser $parser
23 23
 	 * @param ProcessingResult $result
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string
26 26
 	 */
27 27
 	public function handle( Parser $parser, ProcessingResult $result ) {
28 28
 		$parameters = $result->getParameters();
Please login to merge, or discard this patch.
src/SQLStore/Lookup/PropertyUsageListLookup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 	 *
41 41
 	 * @param Store $store
42 42
 	 * @param PropertyStatisticsStore $propertyStatisticsStore
43
-	 * @param RequestOptions $requestOptions|null
43
+	 * @param RequestOptions $requestOptions
44 44
 	 */
45 45
 	public function __construct( Store $store, PropertyStatisticsStore $propertyStatisticsStore, RequestOptions $requestOptions = null ) {
46 46
 		$this->store = $store;
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/ConceptQueryResolver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@
 block discarded – undo
177 177
 	/**
178 178
 	 * @since 2.2
179 179
 	 *
180
-	 * @return array
180
+	 * @return string[]
181 181
 	 */
182 182
 	public function getErrors() {
183 183
 		return $this->errors;
Please login to merge, or discard this patch.
tests/phpunit/includes/GlobalFunctionsTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	/**
44 44
 	 * Returns the name of the class to be tested
45 45
 	 *
46
-	 * @return string|false
46
+	 * @return boolean
47 47
 	 */
48 48
 	public function getClass() {
49 49
 		return false;
Please login to merge, or discard this patch.
tests/phpunit/includes/querypages/PropertiesQueryPageTest.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 class UnusedPropertiesQueryPageTest extends SemanticMediaWikiTestCase {
24 24
 
25 25
 	/**
26
-	 * @return string|false
26
+	 * @return string
27 27
 	 */
28 28
 	public function getClass() {
29 29
 		return '\SMW\UnusedPropertiesQueryPage';
@@ -55,6 +55,7 @@  discard block
 block discarded – undo
55 55
 	/**
56 56
 	 * @since 1.9
57 57
 	 *
58
+	 * @param string $result
58 59
 	 * @return UnusedPropertiesQueryPage
59 60
 	 */
60 61
 	private function newInstance( $result = null, $values = array() ) {
Please login to merge, or discard this patch.
tests/phpunit/includes/querypages/QueryPageTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 	/**
36 36
 	 * Returns the name of the class to be tested
37 37
 	 *
38
-	 * @return string|false
38
+	 * @return string
39 39
 	 */
40 40
 	public function getClass() {
41 41
 		return '\SMW\AggregatablePrinter';
Please login to merge, or discard this patch.
includes/query/SMW_QueryParser.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -134,6 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * but just controls query generation. For general effect, the default namespaces
135 135
 	 * should be set to NULL.
136 136
 	 *
137
+	 * @param boolean $setNS
137 138
 	 * @return Description|null
138 139
 	 */
139 140
 	private function getSubqueryDescription( &$setNS ) {
@@ -242,6 +243,7 @@  discard block
 block discarded – undo
242 243
 	 * be the content of "[[ ... ]]". Returns NULL upon error.
243 244
 	 *
244 245
 	 * Parameters $setNS has the same use as in getSubqueryDescription().
246
+	 * @param boolean $setNS
245 247
 	 */
246 248
 	private function getLinkDescription( &$setNS ) {
247 249
 		// This method is called when we encountered an opening '[['. The following
@@ -424,6 +426,7 @@  discard block
 block discarded – undo
424 426
 	 * a category or property) and create a suitable description.
425 427
 	 * The first chunk behind the "[[" has already been read and is
426 428
 	 * passed as a parameter.
429
+	 * @param string $firstChunk
427 430
 	 */
428 431
 	private function getArticleDescription( $firstChunk, &$setNS ) {
429 432
 		$chunk = $firstChunk;
@@ -469,6 +472,10 @@  discard block
 block discarded – undo
469 472
 		return $this->finishLinkDescription( $chunk, true, $result, $setNS );
470 473
 	}
471 474
 
475
+	/**
476
+	 * @param boolean $hasNamespaces
477
+	 * @param Description|null $result
478
+	 */
472 479
 	private function finishLinkDescription( $chunk, $hasNamespaces, $result, &$setNS ) {
473 480
 		if ( is_null( $result ) ) { // no useful information or concrete error found
474 481
 			$this->descriptionProcessor->addErrorForMsgCode( 'smw_unexpectedpart', $chunk ); // was smw_badqueryatom
@@ -565,6 +572,7 @@  discard block
 block discarded – undo
565 572
 	/**
566 573
 	 * Enter a new subblock in the query, which must at some time be terminated by the
567 574
 	 * given $endstring delimiter calling popDelimiter();
575
+	 * @param string $endstring
568 576
 	 */
569 577
 	private function pushDelimiter( $endstring ) {
570 578
 		array_push( $this->separatorStack, $endstring );
@@ -574,6 +582,7 @@  discard block
 block discarded – undo
574 582
 	 * Exit a subblock in the query ending with the given delimiter.
575 583
 	 * If the delimiter does not match the top-most open block, false
576 584
 	 * will be returned. Otherwise return true.
585
+	 * @param string $endstring
577 586
 	 */
578 587
 	private function popDelimiter( $endstring ) {
579 588
 		$topdelim = array_pop( $this->separatorStack );
Please login to merge, or discard this patch.
src/Query/Parser/DescriptionProcessor.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -166,6 +166,7 @@  discard block
 block discarded – undo
166 166
 	 *
167 167
 	 * The return value is the expected combined description. The object $currentDescription will
168 168
 	 * also be changed (if it was non-NULL).
169
+	 * @param integer $compoundType
169 170
 	 */
170 171
 	private function getCompoundDescription( Description $currentDescription = null, Description $newDescription = null, $compoundType = SMW_CONJUNCTION_QUERY ) {
171 172
 
@@ -201,6 +202,10 @@  discard block
 block discarded – undo
201 202
 		}
202 203
 	}
203 204
 
205
+	/**
206
+	 * @param Description $currentDescription
207
+	 * @param Description $newDescription
208
+	 */
204 209
 	private function newCompoundDescriptionFor( $compoundType, $currentDescription, $newDescription ) {
205 210
 
206 211
 		if ( ( ( $compoundType & SMW_CONJUNCTION_QUERY ) != 0 && ( $currentDescription instanceof Conjunction ) ) ||
Please login to merge, or discard this patch.
includes/parserhooks/SubobjectParserFunction.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	/**
85 85
 	 * @since 1.9
86 86
 	 *
87
-	 * @param ParserParameterProcessor $params
87
+	 * @param ParserParameterProcessor $parameters
88 88
 	 *
89
-	 * @return string|null
89
+	 * @return string
90 90
 	 */
91 91
 	public function parse( ParserParameterProcessor $parameters ) {
92 92
 
@@ -172,6 +172,9 @@  discard block
 block discarded – undo
172 172
 		return $parameters->toArray();
173 173
 	}
174 174
 
175
+	/**
176
+	 * @param DIWikiPage $subject
177
+	 */
175 178
 	private function addErrorWithMsg( $subject, $errorMsg ) {
176 179
 
177 180
 		$error = new Error( $subject );
Please login to merge, or discard this patch.