Completed
Push — master ( 944e8c...873a6a )
by mw
32:14
created
src/SQLStore/EmbeddedQueryDependencyListResolver.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -134,6 +134,9 @@
 block discarded – undo
134 134
 		return $dependencySubjectList;
135 135
 	}
136 136
 
137
+	/**
138
+	 * @param DIWikiPage[] $subjects
139
+	 */
137 140
 	private function doResolveDependenciesFromDescription( &$subjects, $description ) {
138 141
 
139 142
 		if ( $description instanceof ValueDescription && $description->getDataItem() instanceof DIWikiPage ) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\Tests\SQLStore;
4 4
 
5 5
 use SMW\SQLStore\SQLStoreFactory;
6
-use SMW\Store;
7 6
 use SMWSQLStore3;
8 7
 
9 8
 /**
Please login to merge, or discard this patch.
src/SQLStore/Lookup/CachedListLookup.php 2 patches
Doc Comments   +13 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 *
52 52
 	 * @param ListLookup $listLookup
53 53
 	 * @param Cache $cache
54
-	 * @param stdClass $cacheOptions
54
+	 * @param \stdClass $cacheOptions
55 55
 	 */
56 56
 	public function __construct( ListLookup $listLookup, Cache $cache, \stdClass $cacheOptions ) {
57 57
 		$this->listLookup = $listLookup;
@@ -149,6 +149,10 @@  discard block
 block discarded – undo
149 149
 		$this->cache->delete( $id );
150 150
 	}
151 151
 
152
+	/**
153
+	 * @param string $key
154
+	 * @param string $optionsKey
155
+	 */
152 156
 	private function tryFetchFromCache( $key, $optionsKey ) {
153 157
 
154 158
 		if ( !$this->cache->contains( $key ) ) {
@@ -167,6 +171,11 @@  discard block
 block discarded – undo
167 171
 		return $data['list'];
168 172
 	}
169 173
 
174
+	/**
175
+	 * @param string $key
176
+	 * @param string $optionsKey
177
+	 * @param integer $time
178
+	 */
170 179
 	private function saveToCache( $key, $optionsKey, $list, $time, $ttl ) {
171 180
 
172 181
 		$this->timestamp = $time;
@@ -185,6 +194,9 @@  discard block
 block discarded – undo
185 194
 		$this->cache->save( $optionsKey, serialize( $data ), $ttl );
186 195
 	}
187 196
 
197
+	/**
198
+	 * @param string $id
199
+	 */
188 200
 	private function getCacheKey( $id ) {
189 201
 
190 202
 		$optionsKey = '';
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use SMW\SPARQLStore\QueryEngine\Interpreter\ThingDescriptionInterpreter;
7 7
 use SMW\SPARQLStore\QueryEngine\CompoundConditionBuilder;
8 8
 use SMW\Query\Language\ThingDescription;
9
-use SMW\DIWikiPage;
10 9
 use SMW\DIProperty;
11 10
 
12 11
 /**
Please login to merge, or discard this patch.
src/SQLStore/Lookup/CachedValueLookupStore.php 2 patches
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,7 +110,6 @@  discard block
 block discarded – undo
110 110
 	 * @since 2.3
111 111
 	 *
112 112
 	 * @param DIWikiPage $subject
113
-	 * @param RequestOptions $requestOptions = null
114 113
 	 *
115 114
 	 * @return array
116 115
 	 */
@@ -272,7 +271,6 @@  discard block
 block discarded – undo
272 271
 	 *
273 272
 	 * @since 2.3
274 273
 	 *
275
-	 * @param DIWikiPage|null $subject
276 274
 	 * @param DIProperty $property
277 275
 	 * @param RequestOptions $requestOptions = null
278 276
 	 *
@@ -419,6 +417,10 @@  discard block
 block discarded – undo
419 417
 		) . $suffix );
420 418
 	}
421 419
 
420
+	/**
421
+	 * @param string $id
422
+	 * @param DIWikiPage $subject
423
+	 */
422 424
 	private function appendToList( $id, $subject ) {
423 425
 
424 426
 		// Store the id with the main subject
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace SMW\SQLStore\Lookup;
4 4
 
5
-use Onoi\Cache\Cache;
6 5
 use Onoi\BlobStore\BlobStore;
7 6
 use SMW\SQLStore\ValueLookupStore;
8 7
 use SMW\Store;
@@ -12,7 +11,6 @@  discard block
 block discarded – undo
12 11
 use SMW\CircularReferenceGuard;
13 12
 use SMWDataItem as DataItem;
14 13
 use SMWRequestOptions as RequestOptions;
15
-use RuntimeException;
16 14
 
17 15
 /**
18 16
  * Intermediary (fast) access to serialized blob values to avoid DB access on
Please login to merge, or discard this patch.
src/SQLStore/Lookup/UndeclaredPropertyListLookup.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 *
40 40
 	 * @param Store $store
41 41
 	 * @param string $defaultPropertyType
42
-	 * @param RequestOptions $requestOptions|null
42
+	 * @param RequestOptions $requestOptions
43 43
 	 */
44 44
 	public function __construct( Store $store, $defaultPropertyType, RequestOptions $requestOptions = null ) {
45 45
 		$this->store = $store;
@@ -152,6 +152,9 @@  discard block
 block discarded – undo
152 152
 		return $property;
153 153
 	}
154 154
 
155
+	/**
156
+	 * @param string $type
157
+	 */
155 158
 	private function getPropertyTableForType( $type ) {
156 159
 
157 160
 		$propertyTables = $this->store->getPropertyTables();
Please login to merge, or discard this patch.
src/SQLStore/Lookup/UnusedPropertyListLookup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 	 *
41 41
 	 * @param Store $store
42 42
 	 * @param PropertyStatisticsStore $propertyStatisticsStore
43
-	 * @param RequestOptions $requestOptions|null
43
+	 * @param RequestOptions $requestOptions
44 44
 	 */
45 45
 	public function __construct( Store $store, PropertyStatisticsStore $propertyStatisticsStore, RequestOptions $requestOptions = null ) {
46 46
 		$this->store = $store;
Please login to merge, or discard this patch.
src/SQLStore/Lookup/UsageStatisticsListLookup.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	/**
102 102
 	 * @since 2.2
103 103
 	 *
104
-	 * @return number
104
+	 * @return integer
105 105
 	 */
106 106
 	public function getImproperValueForCount() {
107 107
 		return $this->propertyStatisticsStore->getUsageCount(
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	/**
113 113
 	 * @since 1.9
114 114
 	 *
115
-	 * @return number
115
+	 * @return integer
116 116
 	 */
117 117
 	public function getQueryCount() {
118 118
 		return $this->count( '_ASK' );
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	/**
122 122
 	 * @since 1.9
123 123
 	 *
124
-	 * @return number
124
+	 * @return integer
125 125
 	 */
126 126
 	public function getQuerySize() {
127 127
 		return $this->count( '_ASKSI' );
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 	/**
131 131
 	 * @since 1.9
132 132
 	 *
133
-	 * @return number
133
+	 * @return integer
134 134
 	 */
135 135
 	public function getConceptCount() {
136 136
 		return $this->count( '_CONC' );
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	/**
140 140
 	 * @since 1.9
141 141
 	 *
142
-	 * @return number
142
+	 * @return integer
143 143
 	 */
144 144
 	public function getSubobjectCount() {
145 145
 		return $this->count( DIProperty::TYPE_SUBOBJECT );
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 	/**
149 149
 	 * @since 1.9
150 150
 	 *
151
-	 * @return number
151
+	 * @return integer
152 152
 	 */
153 153
 	public function getDeclaredPropertiesCount() {
154 154
 		return $this->count( DIProperty::TYPE_HAS_TYPE );
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	 *
223 223
 	 * @since 1.9
224 224
 	 *
225
-	 * @return number
225
+	 * @return integer
226 226
 	 */
227 227
 	public function getPropertyUsageCount() {
228 228
 		$count = 0;
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 	/**
243 243
 	 * @since 1.9
244 244
 	 *
245
-	 * @return number
245
+	 * @return integer
246 246
 	 */
247 247
 	public function getUsedPropertiesCount() {
248 248
 		$count = 0;
Please login to merge, or discard this patch.
src/SQLStore/PropertyStatisticsTable.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 *
208 208
 	 * @since 1.9
209 209
 	 *
210
-	 * @param array $propertyIds
210
+	 * @param integer[] $propertyIds
211 211
 	 *
212 212
 	 * @return array
213 213
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use ImportReporter;
7 7
 use WikiImporter;
8 8
 use RequestContext;
9
-
10 9
 use RuntimeException;
11 10
 
12 11
 /**
Please login to merge, or discard this patch.
src/SQLStore/PropertyTableDefinitionBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	/**
35 35
 	 * @since 1.9
36 36
 	 *
37
-	 * @param array $diType
37
+	 * @param array $diTypes
38 38
 	 * @param array $specialProperties
39 39
 	 * @param array $userDefinedFixedProperties
40 40
 	 */
Please login to merge, or discard this patch.
src/SQLStore/PropertyTableRowDiffer.php 2 patches
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -161,6 +161,9 @@  discard block
 block discarded – undo
161 161
 		return $this->compositePropertyTableDiffIterator;
162 162
 	}
163 163
 
164
+	/**
165
+	 * @param integer $sid
166
+	 */
164 167
 	private function fetchPropertyTableHashesForId( $sid ) {
165 168
 		return $this->store->getObjectIds()->getPropertyTableHashes( $sid );
166 169
 	}
@@ -188,7 +191,6 @@  discard block
 block discarded – undo
188 191
 	 *
189 192
 	 * @since 1.8
190 193
 	 * @param integer $sid
191
-	 * @param TableDefinition $tableDeclaration
192 194
 	 * @return array
193 195
 	 */
194 196
 	private function fetchCurrentContentsForPropertyTable( $sid, TableDefinition $propertyTable ) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SMW\SQLStore;
4 4
 
5
-use SMW\MediaWiki\Database;
6 5
 use SMWStringCondition as StringCondition;
7 6
 use SMWRequestOptions as RequestOptions;
8 7
 use SMW\DIWikiPage;
Please login to merge, or discard this patch.