Issues in RecurringEventsParserFunctionTest.php - All Issues - Inspection of "Merge pull request #1541 from SemanticMediaWiki/ti..." - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d1976...30add5 )

by mw

created 2016-04-29 07:33 UTC

parserhooks/RecurringEventsParserFunctionTest.php (27 issues)

Labels

Severity

Minor 27

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\Test;

use ParserOutput;
use ReflectionClass;
use SMW\MessageFormatter;
use SMW\ParserData;
use SMW\ParserParameterFormatter;
use SMW\RecurringEventsParserFunction;
use SMW\Settings;
use SMW\Subobject;
use Title;

/**
 * @covers \SMW\RecurringEventsParserFunction
 *
 *
 * @group SMW
 * @group SMWExtension
 *
 * @license GNU GPL v2+
 * @since 1.9
 *
 * @author mwjames
 */
class RecurringEventsParserFunctionTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$subobject = new Subobject( Title::newFromText( __METHOD__ ) );

		$settings = $this->getMockBuilder( '\SMW\Settings' )
			->disableOriginalConstructor()
			->getMock();

		$parserData = $this->getMockBuilder( '\SMW\ParserData' )
			->disableOriginalConstructor()
			->getMock();

		$messageFormatter = $this->getMockBuilder( '\SMW\MessageFormatter' )
			->disableOriginalConstructor()
			->getMock();

		$this->assertInstanceOf(
			'\SMW\RecurringEventsParserFunction',
			new RecurringEventsParserFunction(
				$parserData,
				$subobject,
				$messageFormatter,
				$settings
			)
		);
	}

	/**
	 * @dataProvider recurringEventsDataProvider
	 */
	public function testParse( array $params, array $expected ) {

		$instance = $this->acquireInstance(
			Title::newFromText( __METHOD__ ),
			new ParserOutput()
		);

		$result = $instance->parse( new ParserParameterFormatter( $params ) );

		$this->assertTrue( $result !== '' ? $expected['errors'] : !$expected['errors'] );

		$reflector = new ReflectionClass( '\SMW\RecurringEventsParserFunction' );
		$events = $reflector->getProperty( 'events' );
		$events->setAccessible( true );

		$this->assertEquals(
			$expected['parameters'],
			$events->getValue( $instance )->getParameters()
		);
	}

	public function recurringEventsDataProvider() {

		$provider = array();

		// #0
		// {{#set_recurring_event:property=Has birthday
		// |start=01 Feb 1970
		// |has title= Birthday
		// |unit=year
		// |period=12
		// |limit=3
		// }}
		$provider[] = array(
			array(
				'property=Has birthday',
				'start=01 Feb 1970',
				'has title=Birthday',
				'unit=month',
				'period=12',
				'limit=3'
			),
			array(
				'errors' => false,
				'dates' => array(
					'1 February 1970',
					'1 February 1971 00:00:00',
					'1 February 1972 00:00:00',
					'1 February 1973 00:00:00'
				),
				'property' => array(
					'Has birthday',
					'Has title'
				),
				'parameters' => array(
					'has title' => array( 'Birthday' )
				)
			)
		);

		// #1
		// {{#set_recurring_event:property=Has birthday
		// |start=01 Feb 1972 02:00

		// |has title=Test 12
		// |unit=week
		// |period=4
		// |limit=3
		// }}
		$provider[] = array(
			array(
				'property=Has birthday',
				'start=01 Feb 1972 02:00',
				'has title=Test 2',
				'unit=week',
				'period=4',
				'limit=3'
			),
			array(
				'errors' => false,
				'dates' => array(
					'1 February 1972 02:00:00',
					'29 February 1972 02:00:00',
					'28 March 1972 02:00:00',
					'25 April 1972 02:00:00'
				),
				'property' => array(
					'Has birthday',
					'Has title'
				),
				'parameters' => array(
					'has title' => array( 'Test 2' )
				)
			)
		);

		// #2
		// {{#set_recurring_event:property=Has date
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[] = array(
			array(
				'property=Has date',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => false,
				'dates' => array(
					'4 January 2010',
					'11 January 2010 00:00:00',
					'1 February 2010 00:00:00',
					'March 16, 2010',
					'March 23, 2010'
				),
				'property' => 'Has date',
				'parameters' => array()
			)
		);


		// #3
		// {{#set_recurring_event:property=Has date
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010|+sep=;

		// |exclude=January 18, 2010;January 25, 2010|+sep=;

		// }}
		$provider[] = array(
			array(
				'property=Has date',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'+sep=;', 'exclude=January 18, 2010;January 25, 2010',
				'+sep=;'
			),
			array(
				'errors' => false,
				'dates' => array(
					'4 January 2010',
					'11 January 2010 00:00:00',
					'1 February 2010 00:00:00',
					'March 16, 2010',
					'March 23, 2010'
				),
				'property' => 'Has date',
				'parameters' => array()
			)
		);

		// #4 Named page reference pointer
		// {{#set_recurring_event:FooBar
		// |property=Has birthday
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010|+sep=;

		// |exclude=January 18, 2010;January 25, 2010|+sep=;

		// }}
		$provider[] = array(
			array(
				'FooBar',
				'property=Has birthday',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'+sep=;', 'exclude=January 18, 2010;January 25, 2010',
				'+sep=;'
			),
			array(
				'errors' => false,
				'dates' => array(
					'4 January 2010',
					'11 January 2010 00:00:00',
					'1 February 2010 00:00:00',
					'March 16, 2010',
					'March 23, 2010'
				),
				'property' => 'Has birthday',
				'parameters' => array()
			)
		);

		// #5 Simulate first parameter starting being - raising an error
		// {{#set_recurring_event:-
		// property=Has date
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[] = array(
			array(
				'-',
				'property=Has date',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => false,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		// #6 Simulate first parameter starting with - raising an error
		// {{#set_recurring_event:-Foo
		// property=Has date
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[] = array(
			array(
				'-Foo',
				'property=Has date',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => true,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		// #7 Simulate first parameter starting with a underscore raising an error
		// {{#set_recurring_event:_FooBar
		// property=Has date
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[]  = array(
			array(
				'_FooBar',
				'property=Has date',
				'start=January 4, 2010',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => true,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		// #8 Simulate start date has wrong type
		// {{#set_recurring_event:property=Has date
		// |start=???

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[] = array(
			array(
				'property=Has date',
				'start=???',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => true,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		// #9 Simulate missing start date
		// {{#set_recurring_event:property=Has date
		// |start=
		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010

		// |exclude=January 18, 2010;January 25, 2010

		// }}
		$provider[] = array(
			array(
				'property=Has date',
				'start=',
				'unit=week',
				'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'exclude=January 18, 2010;January 25, 2010'
			),
			array(
				'errors' => true,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		// #10 Simulate missing property
		// {{#set_recurring_event:property=
		// |start=January 4, 2010

		// |unit=week
		// |period=1
		// |limit=4
		// |include=March 16, 2010;March 23, 2010|+sep=;

		// |exclude=January 18, 2010;January 25, 2010|+sep=;

		// }}
		$provider[] = array(
			array(
				'property=',
				'start=January 4, 2010',
				'unit=week', 'period=1',
				'limit=4',
				'include=March 16, 2010;March 23, 2010',
				'+sep=;',
				'exclude=January 18, 2010;January 25, 2010',
				'+sep=;'
			),
			array(
				'errors' => true,
				'dates' => array(),
				'property' => '',
				'parameters' => array()
			)
		);

		return $provider;
	}

	/**
	 * @return RecurringEventsParserFunction
	 */
	private function acquireInstance( Title $title, ParserOutput $parserOutput ) {

		$settings = array(
			'smwgDefaultNumRecurringEvents' => 100,
			'smwgMaxNumRecurringEvents' => 100
		);

		return new RecurringEventsParserFunction(
			new ParserData( $title, $parserOutput ),
			new Subobject( $title ),
			new MessageFormatter( \Language::factory( 'en' ) ),
			Settings::newFromArray( $settings )
		);
	}

}


1			<?php
2
3			namespace SMW\Test;
4
5			use ParserOutput;
6			use ReflectionClass;
7			use SMW\MessageFormatter;
8			use SMW\ParserData;
9			use SMW\ParserParameterFormatter;
10			use SMW\RecurringEventsParserFunction;
11			use SMW\Settings;
12			use SMW\Subobject;
13			use Title;
14
15			/**
16			* @covers \SMW\RecurringEventsParserFunction
17			*
18			*
19			* @group SMW
20			* @group SMWExtension
21			*
22			* @license GNU GPL v2+
23			* @since 1.9
24			*
25			* @author mwjames
26			*/
27			class RecurringEventsParserFunctionTest extends \PHPUnit_Framework_TestCase {
28
29			public function testCanConstruct() {
30
31			$subobject = new Subobject( Title::newFromText( __METHOD__ ) );
32
33			$settings = $this->getMockBuilder( '\SMW\Settings' )
34			->disableOriginalConstructor()
35			->getMock();
36
37			$parserData = $this->getMockBuilder( '\SMW\ParserData' )
38			->disableOriginalConstructor()
39			->getMock();
40

SemanticMediaWiki / SemanticMediaWiki

Push — master ( 5d1976...30add5 )

parserhooks/RecurringEventsParserFunctionTest.php (27 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like