Issues in ExportSemanticDataTest.php - All Issues - Inspection of "Merge pull request #1541 from SemanticMediaWiki/ti..." - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d1976...30add5 )

by mw

created 2016-04-29 07:33 UTC

phpunit/includes/export/ExportSemanticDataTest.php (22 issues)

Labels

Severity

Minor 22

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\Tests\Export;

use SMW\DataValueFactory;
use SMW\DIProperty;
use SMW\DIWikiPage;
use SMW\Exporter\Escaper;
use SMW\Subobject;
use SMW\Tests\Utils\Fixtures\FixturesProvider;
use SMW\Tests\Utils\SemanticDataFactory;
use SMW\Tests\Utils\Validators\ExportDataValidator;
use SMWExpNsResource as ExpNsResource;
use SMWExporter as Exporter;
use SMWExpResource as ExpResource;

/**
 * @covers \SMWExporter
 *
 *
 * @group SMW
 * @group SMWExtension
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class ExportSemanticDataTest extends \PHPUnit_Framework_TestCase {

	private $semanticDataFactory;
	private $dataValueFactory;
	private $exportDataValidator;
	private $fixturesProvider;

	protected function setUp() {
		parent::setUp();

		$this->dataValueFactory = DataValueFactory::getInstance();
		$this->semanticDataFactory = new SemanticDataFactory();
		$this->exportDataValidator = new ExportDataValidator();

		$this->fixturesProvider = new FixturesProvider();
	}

	public function testExportRedirect() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$redirectProperty = new DIProperty( '_REDI' );
		$redirectTarget = new DIWikiPage( 'FooRedirectTarget', NS_MAIN, '' );

		$semanticData->addPropertyObjectValue(
			$redirectProperty,
			DIWikiPage::newFromTitle( $redirectTarget->getTitle(), '__red' )
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource( 'swivt', 'redirectsTo' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource(  'owl', 'sameAs' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$expectedResourceElement = new ExpNsResource(
			'FooRedirectTarget',
			Exporter::getInstance()->getNamespaceUri( 'wiki' ),
			'wiki',
			$redirectTarget
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResourceElement,
			Exporter::getInstance()->getSpecialNsResource( 'owl', 'sameAs' ),
			$exportData
		);
	}

	public function testExportPageWithNumericProperty() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$property = new DIProperty( '123' );

		$semanticData->addPropertyObjectValue(
			$property,
			new DIWikiPage( '345', NS_MAIN )
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$expectedProperty = new ExpNsResource(
			Escaper::encodePage( $property->getDiWikiPage() ),
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			Exporter::getInstance()->getNamespaceUri( 'wiki' ),
			'wiki',
			new DIWikiPage( '123', SMW_NS_PROPERTY )
		);

		$this->assertCount(
			1,
			$exportData->getValues( $expectedProperty )
		);

		$this->exportDataValidator->assertThatExportDataContainsProperty(
			$expectedProperty,
			$exportData
		);

		$expectedResourceElement = new ExpNsResource(
			'345',
			Exporter::getInstance()->getNamespaceUri( 'wiki' ),
			'wiki',
			new DIWikiPage( '345', NS_MAIN )
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResourceElement,
			$expectedProperty,
			$exportData
		);
	}

	public function testExportPageWithNonNumericProperty() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$property = new DIProperty( 'A123' );

		$semanticData->addPropertyObjectValue(
			$property,
			new DIWikiPage( '345', NS_MAIN )
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$expectedProperty = new ExpNsResource(
			'A123',
			Exporter::getInstance()->getNamespaceUri( 'property' ),
			'property',
			new DIWikiPage( 'A123', SMW_NS_PROPERTY )
		);

		$this->assertCount(
			1,
			$exportData->getValues( $expectedProperty )
		);

		$this->exportDataValidator->assertThatExportDataContainsProperty(
			$expectedProperty,
			$exportData
		);

		$expectedResource = new ExpNsResource(
			'345',
			Exporter::getInstance()->getNamespaceUri( 'wiki' ),
			'wiki',
			new DIWikiPage( '345', NS_MAIN )
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResource,
			$expectedProperty,
			$exportData
		);
	}

	public function testExportSubproperty() {

		$semanticData = $this->semanticDataFactory
			->setSubject( new DIWikiPage( 'SomeSubproperty', SMW_NS_PROPERTY ) )
			->newEmptySemanticData();

		$semanticData->addDataValue(
			$this->dataValueFactory->newPropertyObjectValue( new DIProperty( '_SUBP' ), 'SomeTopProperty' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource( 'rdfs', 'subPropertyOf' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$expectedResourceElement = new ExpNsResource(
			'SomeTopProperty',
			Exporter::getInstance()->getNamespaceUri( 'property' ),
			'property',
			new DIWikiPage( 'SomeTopProperty', SMW_NS_PROPERTY )
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResourceElement,
			Exporter::getInstance()->getSpecialNsResource( 'rdfs', 'subPropertyOf' ),
			$exportData
		);
	}

	public function testExportCategory() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$semanticData->addDataValue(
			$this->dataValueFactory->newPropertyObjectValue( new DIProperty( '_INST' ), 'SomeCategory' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$this->assertCount(
			2,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource( 'rdf', 'type' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$expectedResourceElement = new ExpNsResource(
			'SomeCategory',
			Exporter::getInstance()->getNamespaceUri( 'category' ),
			'category',
			new DIWikiPage( 'SomeCategory', NS_CATEGORY )
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResourceElement,
			Exporter::getInstance()->getSpecialNsResource( 'rdf', 'type' ),
			$exportData
		);
	}

	public function testExportSubcategory() {

		$semanticData = $this->semanticDataFactory
			->setSubject( new DIWikiPage( 'SomeSubcategory', NS_CATEGORY ) )
			->newEmptySemanticData();

		$semanticData->addDataValue(
			$this->dataValueFactory->newPropertyObjectValue( new DIProperty( '_SUBC' ), 'SomeTopCategory' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource( 'rdfs', 'subClassOf' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$expectedResourceElement = new ExpNsResource(
			'SomeTopCategory',
			Exporter::getInstance()->getNamespaceUri( 'category' ),
			'category',
			new DIWikiPage( 'SomeTopCategory', NS_CATEGORY )
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResourceElement,
			Exporter::getInstance()->getSpecialNsResource( 'rdfs', 'subClassOf' ),
			$exportData
		);
	}

	public function testExportSubobject() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$subobject = new Subobject( $semanticData->getSubject()->getTitle() );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		$subobject->setEmptyContainerForId( 'Foo' );

		$semanticData->addPropertyObjectValue(
			$subobject->getProperty(),
			$subobject->getContainer()
		);

		$exportData = Exporter::getInstance()->makeExportData( $semanticData );


		$expectedProperty = new ExpNsResource(
			$this->transformPropertyLabelToAuxiliary( $subobject->getProperty() ),
			Exporter::getInstance()->getNamespaceUri( 'property' ),
			'property',
			new DIWikiPage( 'Has_subobject', SMW_NS_PROPERTY )
		);

		$this->assertTrue(
			Exporter::getInstance()->hasHelperExpElement( $subobject->getProperty() )
		);

		$this->assertCount(
			1,
			$exportData->getValues( $expectedProperty )
		);

		$this->exportDataValidator->assertThatExportDataContainsProperty(
			$expectedProperty,
			$exportData
		);

		$expectedResource = new ExpNsResource(
			Escaper::encodePage( $subobject->getSemanticData()->getSubject() ) . '-23' . 'Foo',
			Exporter::getInstance()->getNamespaceUri( 'wiki' ),
			'wiki',
			$subobject->getSemanticData()->getSubject()
		);

		$this->exportDataValidator->assertThatExportDataContainsResource(
			$expectedResource,
			$expectedProperty,
			$exportData
		);
	}

	public function testExportSubSemanticData() {

		$semanticData = $this->semanticDataFactory->newEmptySemanticData( __METHOD__ );

		$factsheet = $this->fixturesProvider->getFactsheet( 'berlin' );
		$factsheet->setTargetSubject( $semanticData->getSubject() );

		$demographicsSubobject = $factsheet->getDemographics();

		$semanticData->addPropertyObjectValue(
			$demographicsSubobject->getProperty(),
			$demographicsSubobject->getContainer()
		);

		$exportData = Exporter::getInstance()->makeExportData(
			$semanticData->findSubSemanticData( $demographicsSubobject->getSubobjectId() )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialPropertyResource( '_SKEY' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$this->assertCount(
			1,
			$exportData->getValues( Exporter::getInstance()->getSpecialNsResource( 'swivt', 'wikiNamespace' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);
	}

	private function transformPropertyLabelToAuxiliary( DIProperty $property ) {
		return str_replace( ' ', '_', $property->getLabel() );
	}

}


1			<?php
2
3			namespace SMW\Tests\Export;
4
5			use SMW\DataValueFactory;
6			use SMW\DIProperty;
7			use SMW\DIWikiPage;
8			use SMW\Exporter\Escaper;
9			use SMW\Subobject;
10			use SMW\Tests\Utils\Fixtures\FixturesProvider;
11			use SMW\Tests\Utils\SemanticDataFactory;
12			use SMW\Tests\Utils\Validators\ExportDataValidator;
13			use SMWExpNsResource as ExpNsResource;
14			use SMWExporter as Exporter;
15			use SMWExpResource as ExpResource;
16
17			/**
18			* @covers \SMWExporter
19			*
20			*
21			* @group SMW
22			* @group SMWExtension
23			*
24			* @license GNU GPL v2+
25			* @since 2.0
26			*
27			* @author mwjames
28			*/
29			class ExportSemanticDataTest extends \PHPUnit_Framework_TestCase {
30
31			private $semanticDataFactory;
32			private $dataValueFactory;
33			private $exportDataValidator;
34			private $fixturesProvider;
35
36			protected function setUp() {
37			parent::setUp();
38
39			$this->dataValueFactory = DataValueFactory::getInstance();
40			$this->semanticDataFactory = new SemanticDataFactory();

SemanticMediaWiki / SemanticMediaWiki

Push — master ( 5d1976...30add5 )

phpunit/includes/export/ExportSemanticDataTest.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like