SemanticMediaWiki /
SemanticMediaWiki
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 9 |
| Code Lines | 5 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 21 | public function testConvert( $calendarModel, $seralization, $jdValue ) { |
||
| 22 | |||
| 23 | list( $year, $month, $day, $hour, $minute, $second ) = explode( '/', $seralization ); |
||
| 24 | |||
| 25 | $this->assertEquals( |
||
| 26 | $jdValue, |
||
| 27 | JulianDay::getJD( $calendarModel, $year, $month, $day, $hour, $minute, $second ) |
||
| 28 | ); |
||
| 29 | } |
||
| 30 | |||
| 103 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.