QueryComparatorTest::testContainsComparator() - Code Metrics - Inspection of "Add QueryComparator::containsComparator (#1947)" - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b193d1...54463f )

by mw

created 2016-10-23 20:35 UTC

QueryComparatorTest::testContainsComparator() A

↳ Parent: QueryComparatorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
nc	1
nop	3
dl	0
loc	11
rs	9.4285
c	1
b	0
f	0

<?php

namespace SMW\Tests\Query;

use SMW\Query\QueryComparator;

/**
 * @covers \SMW\Query\QueryComparator
 * @group semantic-mediawiki
 *
 * @license GNU GPL v2+
 * @since 2.3
 *
 * @author mwjames
 */
class QueryComparatorTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$comparatorList = '';

		$this->assertInstanceOf(
			'\SMW\Query\QueryComparator',
			new QueryComparator( $comparatorList, false )
		);

		$this->assertInstanceOf(
			'\SMW\Query\QueryComparator',
			QueryComparator::getInstance()
		);
	}

	/**
	 * @dataProvider stringComparatorProvider
	 */
	public function testGetComparatorFromString( $stringComparator, $expected ) {

		$comparatorList = '';

		$instance = new QueryComparator( $comparatorList, false );

		$this->assertEquals(
			$expected,
			$instance->getComparatorFromString( $stringComparator )
		);
	}

	/**
	 * @dataProvider stringComparatorProvider
	 */
	public function testGetStringForComparator( $stringComparator, $comparator ) {

		$comparatorList = '';

		$instance = new QueryComparator( $comparatorList, false );

		$this->assertEquals(
			$stringComparator,
			$instance->getStringForComparator( $comparator )
		);
	}

	/**
	 * @dataProvider extractStringComparatorProvider
	 */
	public function testExtractComparatorFromString( $string, $expectedString, $expectedComparator ) {

		$comparatorList = '';

		$instance = new QueryComparator( $comparatorList, true );

		$this->assertEquals(
			$expectedComparator,
			$instance->extractComparatorFromString( $string )
		);

		$this->assertEquals(
			$expectedString,
			$string
		);
	}

	/**
	 * @dataProvider containsComparatorProvider
	 */
	public function testContainsComparator( $string, $comparator, $expected ) {

		$comparatorList = '';

		$instance = new QueryComparator( $comparatorList, true );

		$this->assertEquals(
			$expected,
			$instance->containsComparator( $string, $comparator )
		);
	}

	public function stringComparatorProvider() {

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'!~',
			SMW_CMP_NLKE
		);

		return $provider;
	}

	public function extractStringComparatorProvider() {

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'!~Foo',
			'Foo',
			SMW_CMP_NLKE
		);

		$provider[] = array(
			'<Foo',
			'Foo',
			SMW_CMP_LESS
		);

		return $provider;
	}

	public function containsComparatorProvider() {

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'~someThing',
			SMW_CMP_EQ,
			false
		);

		$provider[] = array(
			'someThing',
			SMW_CMP_EQ,
			true
		);

		$provider[] = array(
			'!~someThing',
			SMW_CMP_NLKE,
			true
		);

		$provider[] = array(
			'!~someThing',
			SMW_CMP_LIKE,
			false
		);

		$provider[] = array(
			'>>someThing',
			SMW_CMP_LESS,
			false
		);

		$provider[] = array(
			'<<someThing',
			SMW_CMP_LESS,
			true
		);

		return $provider;
	}

}


1			<?php
2
3			namespace SMW\Tests\Query;
4
5			use SMW\Query\QueryComparator;
6
7			/**
8			* @covers \SMW\Query\QueryComparator
9			* @group semantic-mediawiki
10			*
11			* @license GNU GPL v2+
12			* @since 2.3
13			*
14			* @author mwjames
15			*/
16			class QueryComparatorTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$comparatorList = '';
21
22			$this->assertInstanceOf(
23			'\SMW\Query\QueryComparator',
24			new QueryComparator( $comparatorList, false )
25			);
26
27			$this->assertInstanceOf(
28			'\SMW\Query\QueryComparator',
29			QueryComparator::getInstance()
30			);
31			}
32
33			/**
34			* @dataProvider stringComparatorProvider
35			*/
36			public function testGetComparatorFromString( $stringComparator, $expected ) {
37
38			$comparatorList = '';
39
40			$instance = new QueryComparator( $comparatorList, false );
41
42			$this->assertEquals(
43			$expected,
44			$instance->getComparatorFromString( $stringComparator )
45			);
46			}
47
48			/**
49			* @dataProvider stringComparatorProvider
50			*/
51			public function testGetStringForComparator( $stringComparator, $comparator ) {
52
53			$comparatorList = '';
54
55			$instance = new QueryComparator( $comparatorList, false );
56
57			$this->assertEquals(
58			$stringComparator,
59			$instance->getStringForComparator( $comparator )
60			);
61			}
62
63			/**
64			* @dataProvider extractStringComparatorProvider
65			*/
66			public function testExtractComparatorFromString( $string, $expectedString, $expectedComparator ) {
67
68			$comparatorList = '';
69
70			$instance = new QueryComparator( $comparatorList, true );
71
72			$this->assertEquals(
73			$expectedComparator,
74			$instance->extractComparatorFromString( $string )
75			);
76
77			$this->assertEquals(
78			$expectedString,
79			$string
80			);
81			}
82
83			/**
84			* @dataProvider containsComparatorProvider
85			*/
86			public function testContainsComparator( $string, $comparator, $expected ) {
87
88			$comparatorList = '';
89
90			$instance = new QueryComparator( $comparatorList, true );
91
92			$this->assertEquals(
93			$expected,
94			$instance->containsComparator( $string, $comparator )
95			);
96			}
97
98			public function stringComparatorProvider() {
99
100			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-23 10:29 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
101			'!~',
102			SMW_CMP_NLKE
103			);
104
105			return $provider;
106			}
107
108			public function extractStringComparatorProvider() {
109
110			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-23 16:59 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
111			'!~Foo',
112			'Foo',
113			SMW_CMP_NLKE
114			);
115
116			$provider[] = array(
117			'<Foo',
118			'Foo',
119			SMW_CMP_LESS
120			);
121
122			return $provider;
123			}
124
125			public function containsComparatorProvider() {
126
127			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-23 16:59 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
128			'~someThing',
129			SMW_CMP_EQ,
130			false
131			);
132
133			$provider[] = array(
134			'someThing',
135			SMW_CMP_EQ,
136			true
137			);
138
139			$provider[] = array(
140			'!~someThing',
141			SMW_CMP_NLKE,
142			true
143			);
144
145			$provider[] = array(
146			'!~someThing',
147			SMW_CMP_LIKE,
148			false
149			);
150
151			$provider[] = array(
152			'>>someThing',
153			SMW_CMP_LESS,
154			false
155			);
156
157			$provider[] = array(
158			'<<someThing',
159			SMW_CMP_LESS,
160			true
161			);
162
163			return $provider;
164			}
165
166			}
167

SemanticMediaWiki / SemanticMediaWiki

Push — master ( b193d1...54463f )

QueryComparatorTest::testContainsComparator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like