Completed
Push — master ( 2472c5...a814e8 )
by mw
35:03
created
src/SQLStore/ConceptCache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 *
62 62
 	 * @since 1.8
63 63
 	 * @param $concept Title
64
-	 * @return array of error strings (empty if no errors occurred)
64
+	 * @return string[] of error strings (empty if no errors occurred)
65 65
 	 */
66 66
 	public function refreshConceptCache( Title $concept ) {
67 67
 		$errors = $this->refresh( $concept );
Please login to merge, or discard this patch.
src/SQLStore/Lookup/CachedListLookup.php 1 patch
Doc Comments   +13 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 *
52 52
 	 * @param ListLookup $listLookup
53 53
 	 * @param Cache $cache
54
-	 * @param stdClass $cacheOptions
54
+	 * @param \stdClass $cacheOptions
55 55
 	 */
56 56
 	public function __construct( ListLookup $listLookup, Cache $cache, \stdClass $cacheOptions ) {
57 57
 		$this->listLookup = $listLookup;
@@ -149,6 +149,10 @@  discard block
 block discarded – undo
149 149
 		$this->cache->delete( $id );
150 150
 	}
151 151
 
152
+	/**
153
+	 * @param string $key
154
+	 * @param string $optionsKey
155
+	 */
152 156
 	private function tryFetchFromCache( $key, $optionsKey ) {
153 157
 
154 158
 		if ( !$this->cache->contains( $key ) ) {
@@ -167,6 +171,11 @@  discard block
 block discarded – undo
167 171
 		return $data['list'];
168 172
 	}
169 173
 
174
+	/**
175
+	 * @param string $key
176
+	 * @param string $optionsKey
177
+	 * @param integer $time
178
+	 */
170 179
 	private function saveToCache( $key, $optionsKey, $list, $time, $ttl ) {
171 180
 
172 181
 		$this->timestamp = $time;
@@ -185,6 +194,9 @@  discard block
 block discarded – undo
185 194
 		$this->cache->save( $optionsKey, serialize( $data ), $ttl );
186 195
 	}
187 196
 
197
+	/**
198
+	 * @param string $id
199
+	 */
188 200
 	private function getCacheKey( $id ) {
189 201
 
190 202
 		$optionsKey = '';
Please login to merge, or discard this patch.
src/SQLStore/Lookup/UndeclaredPropertyListLookup.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 *
40 40
 	 * @param Store $store
41 41
 	 * @param string $defaultPropertyType
42
-	 * @param RequestOptions $requestOptions|null
42
+	 * @param RequestOptions $requestOptions
43 43
 	 */
44 44
 	public function __construct( Store $store, $defaultPropertyType, RequestOptions $requestOptions = null ) {
45 45
 		$this->store = $store;
@@ -152,6 +152,9 @@  discard block
 block discarded – undo
152 152
 		return $property;
153 153
 	}
154 154
 
155
+	/**
156
+	 * @param string $type
157
+	 */
155 158
 	private function getPropertyTableForType( $type ) {
156 159
 
157 160
 		$propertyTables = $this->store->getPropertyTables();
Please login to merge, or discard this patch.
src/SQLStore/Lookup/UnusedPropertyListLookup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 	 *
41 41
 	 * @param Store $store
42 42
 	 * @param PropertyStatisticsStore $propertyStatisticsStore
43
-	 * @param RequestOptions $requestOptions|null
43
+	 * @param RequestOptions $requestOptions
44 44
 	 */
45 45
 	public function __construct( Store $store, PropertyStatisticsStore $propertyStatisticsStore, RequestOptions $requestOptions = null ) {
46 46
 		$this->store = $store;
Please login to merge, or discard this patch.
src/SQLStore/PropertyStatisticsTable.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 *
208 208
 	 * @since 1.9
209 209
 	 *
210
-	 * @param array $propertyIds
210
+	 * @param integer[] $propertyIds
211 211
 	 *
212 212
 	 * @return array
213 213
 	 */
Please login to merge, or discard this patch.
src/SQLStore/PropertyTableRowDiffer.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -161,6 +161,9 @@  discard block
 block discarded – undo
161 161
 		return $this->compositePropertyTableDiffIterator;
162 162
 	}
163 163
 
164
+	/**
165
+	 * @param integer $sid
166
+	 */
164 167
 	private function fetchPropertyTableHashesForId( $sid ) {
165 168
 		return $this->store->getObjectIds()->getPropertyTableHashes( $sid );
166 169
 	}
@@ -188,7 +191,6 @@  discard block
 block discarded – undo
188 191
 	 *
189 192
 	 * @since 1.8
190 193
 	 * @param integer $sid
191
-	 * @param TableDefinition $tableDeclaration
192 194
 	 * @return array
193 195
 	 */
194 196
 	private function fetchCurrentContentsForPropertyTable( $sid, TableDefinition $propertyTable ) {
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/QuerySegmentListBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@
 block discarded – undo
177 177
 	/**
178 178
 	 * @since 2.2
179 179
 	 *
180
-	 * @return array
180
+	 * @return string[]
181 181
 	 */
182 182
 	public function getErrors() {
183 183
 		return $this->errors;
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/QuerySegmentListProcessor.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -85,6 +85,7 @@
 block discarded – undo
85 85
 	 * @since 2.2
86 86
 	 *
87 87
 	 * @param &$querySegmentList
88
+	 * @param QuerySegment[] $querySegmentList
88 89
 	 */
89 90
 	public function setQuerySegmentList( &$querySegmentList ) {
90 91
 		$this->querySegmentList =& $querySegmentList;
Please login to merge, or discard this patch.
src/SQLStore/RequestOptionsProcessor.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 *
133 133
 	 * @since 1.8
134 134
 	 * @param array $data array of SMWDataItem objects
135
-	 * @param SMWRequestOptions|null $requestoptions
135
+	 * @param null|RequestOptions $requestOptions
136 136
 	 *
137 137
 	 * @return SMWDataItem[]
138 138
 	 */
@@ -170,6 +170,9 @@  discard block
 block discarded – undo
170 170
 		return $result;
171 171
 	}
172 172
 
173
+	/**
174
+	 * @param boolean $keepDataValue
175
+	 */
173 176
 	private function applyStringConditions( $requestOptions, $label, $keepDataValue ) {
174 177
 
175 178
 		foreach ( $requestOptions->getStringConditions() as $strcond ) { // apply string conditions
@@ -189,6 +192,9 @@  discard block
 block discarded – undo
189 192
 		return $keepDataValue;
190 193
 	}
191 194
 
195
+	/**
196
+	 * @param boolean $isNumeric
197
+	 */
192 198
 	private function applyBoundaryConditions( $requestOptions, $value, $isNumeric ) {
193 199
 		$keepDataValue = true; // keep datavalue only if this remains true
194 200
 
@@ -229,6 +235,9 @@  discard block
 block discarded – undo
229 235
 		return array( $label, $value );
230 236
 	}
231 237
 
238
+	/**
239
+	 * @param boolean $isNumeric
240
+	 */
232 241
 	private function applySortRestriction( $requestOptions, &$result, $sortres, $isNumeric ) {
233 242
 
234 243
 		if ( !$requestOptions->sort ) {
Please login to merge, or discard this patch.