SemanticMediaWiki / SemanticMediaWiki

src/DataItemFactory.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 use SMWDIError as DIError;
 use SMWDINumber as DINumber;
 use SMWDIUri as DIUri;
-use SMWDITime  as DITime;
+use SMWDITime as DITime;
 
 /**
  * @private

Doc Comments +2 added lines, -2 removed lines

@@ -136,8 +136,8 @@
 	 *
 	 * @param integer $calendarmodel
 	 * @param integer $year
-	 * @param integer|false $month
-	 * @param integer|false $day
+	 * @param integer $month
+	 * @param integer $day
 	 * @param integer|false $hour
 	 * @param integer|false $minute
 	 * @param integer|false $second

src/Deserializers/DVDescriptionDeserializer/DescriptionDeserializer.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 * @since 2.5
 	 *
 	 * @param DescriptionFactory|null $descriptionFactory
-	 * @param DataItemFactory|null $dataItemFactory
+	 * @param null|DescriptionFactory $dataItemFactory
 	 */
 	public function __construct( DescriptionFactory $descriptionFactory = null, DescriptionFactory $dataItemFactory = null ) {
 		$this->descriptionFactory = $descriptionFactory;

src/Deserializers/DVDescriptionDeserializer/SomeValueDescriptionDeserializer.php

Doc Comments +4 added lines

@@ -77,6 +77,10 @@
 		return $description;
 	}
 
+	/**
+	 * @param DIWikiPage $dataItem
+	 * @param ValueDescription $description
+	 */
 	private function findApproriateDescription( $comparator, $dataItem, $description ) {
 
 		$value = $dataItem->getDBKey();

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SMW\Deserializers\DVDescriptionDeserializer;
 
 use InvalidArgumentException;
-use SMW\Query\Language\ThingDescription;
 use SMW\Query\Language\ValueDescription;
 use SMWDataValue as DataValue;
 use SMW\DIWikiPage;

includes/dataitems/SMW_DI_Time.php

Doc Comments +8 added lines, -3 removed lines

@@ -327,7 +327,7 @@ 
 	 *
 	 * @param string $timestamp must be in format
 	 *
-	 * @return SMWDITime|false
+	 * @return SMWDataItem
 	 */
 	public static function newFromTimestamp( $timestamp ) {
 		$timestamp = wfTimestamp( TS_MW, (string)$timestamp );
@@ -494,10 +494,10 @@ 
 	 * calendar model, presicion.
 	 *
 	 * @param double $jdValue
-	 * @param integer|null $calendarmodel
+	 * @param integer|null $calendarModel
 	 * @param integer|null $precision
 	 *
-	 * @return DITime object
+	 * @return SMWDITime object
 	 */
 	public static function newFromJD( $jdValue, $calendarModel = null, $precision = null ) {
 
@@ -579,6 +579,11 @@ 
 		return $this->m_day > self::getDayNumberForMonth( $this->m_month, $this->m_year, $this->m_model );
 	}
 
+	/**
+	 * @param boolean $month
+	 * @param boolean $day
+	 * @param boolean $hour
+	 */
 	private function setPrecisionLevelBy( $month, $day, $hour ) {
 		if ( $month === false ) {
 			$this->m_precision = self::PREC_Y;

src/Libs/Time/JulianDay.php

Doc Comments +11 added lines, -11 removed lines

@@ -34,7 +34,7 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @param integer $calendarmodel
+	 * @param integer $calendarModel
 	 * @param integer $year
 	 * @param integer $month
 	 * @param integer $day
@@ -68,10 +68,10 @@ 
 	 * calendar model. This calculation assumes that neither calendar
 	 * has a year 0.
 	 *
-	 * @param $year integer representing the year
-	 * @param $month integer representing the month
-	 * @param $day integer representing the day
-	 * @param $calendarmodel integer either CM_GREGORIAN or CM_JULIAN
+	 * @param integer $year integer representing the year
+	 * @param integer $month integer representing the month
+	 * @param integer $day integer representing the day
+	 * @param integer $calendarmodel integer either CM_GREGORIAN or CM_JULIAN
 	 *
 	 * @return float Julian Day number
 	 * @throws RuntimeException
@@ -97,9 +97,9 @@ 
 	 * Compute the offset for the Julian Day number from a given time.
 	 * This computation is the same for all calendar models.
 	 *
-	 * @param $hours integer representing the hour
-	 * @param $minutes integer representing the minutes
-	 * @param $seconds integer representing the seconds
+	 * @param integer $hours integer representing the hour
+	 * @param integer $minutes integer representing the minutes
+	 * @param integer $seconds integer representing the seconds
 	 *
 	 * @return float offset for a Julian Day number to get this time
 	 */
@@ -114,8 +114,8 @@ 
 	 * conversion to Gregorian needs positive JD. If this happens, wrong
 	 * values will be returned. Avoid date conversions before 10000 BCE.
 	 *
-	 * @param $jdValue float number of Julian Days
-	 * @param $calendarModel integer either CM_GREGORIAN or CM_JULIAN
+	 * @param double $jdValue float number of Julian Days
+	 * @param integer $calendarModel integer either CM_GREGORIAN or CM_JULIAN
 	 *
 	 * @return array( calendarModel, yearnumber, monthnumber, daynumber )
 	 * @throws RuntimeException
@@ -166,7 +166,7 @@ 
 	 * Extract the time from a Julian Day number and return it as a string.
 	 * This conversion is the same for all calendar models.
 	 *
-	 * @param $jdvalue float number of Julian Days
+	 * @param double $jdvalue float number of Julian Days
 	 * @return array( hours, minutes, seconds )
 	 */
 	public static function JD2Time( $jdvalue ) {

src/Libs/Time/Timezone.php

Doc Comments +4 added lines, -4 removed lines

@@ -169,7 +169,7 @@ 
 	 *
 	 * @param string $identifer
 	 *
-	 * @return false|integer
+	 * @return string
 	 */
 	public static function getIdByAbbreviation( $identifer ) {
 
@@ -193,7 +193,7 @@ 
 	 *
 	 * @param integer $identifer
 	 *
-	 * @return false|string
+	 * @return string
 	 */
 	public static function getAbbreviationById( $identifer ) {
 
@@ -312,7 +312,7 @@ 
 	 *
 	 * @param string $abbreviation
 	 *
-	 * @return false|DateTimeZone
+	 * @return DateTimeZone
 	 */
 	public static function newDateTimeZone( $abbreviation ) {
 
@@ -353,7 +353,7 @@ 
 	 * @since 2.5
 	 *
 	 * @param DateTime &$dateTime
-	 * @param string|integer $identifer
+	 * @param integer $identifer
 	 *
 	 * @return string
 	 */

tests/phpunit/Unit/Libs/Time/TimezoneTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SMW\Tests\Libs\Time;
 
-use SMW\DataItemFactory;
 use SMW\Libs\Time\Timezone;
 
 /**

src/SPARQLStore/RepositoryConnectors/FourstoreHttpRepositoryConnector.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SMW\SPARQLStore\Exception\BadHttpDatabaseResponseException;
 use SMW\SPARQLStore\QueryEngine\RepositoryResult;
 use SMW\SPARQLStore\QueryEngine\XmlResponseParser;
-use SMWSparqlResultParser as SparqlResultParser;
 use SMWTurtleSerializer as TurtleSerializer;
 
 /**

src/SPARQLStore/RepositoryConnectors/GenericHttpRepositoryConnector.php

Doc Comments +4 added lines, -4 removed lines

@@ -132,7 +132,7 @@ 
 	 * rdfs, property, xsd, so these do not have to be included in
 	 * $extraNamespaces.
 	 *
-	 * @param $vars mixed array or string, field name(s) to be retrieved, can be '*'
+	 * @param string $vars mixed array or string, field name(s) to be retrieved, can be '*'
 	 * @param $where string WHERE part of the query, without surrounding { }
 	 * @param $options array (associative) of options, e.g. array( 'LIMIT' => '10' )
 	 * @param $extraNamespaces array (associative) of namespaceId => namespaceUri
@@ -549,8 +549,8 @@ 
 	}
 
 	/**
-	 * @param $endpoint string URL of endpoint that was used
-	 * @param $sparql string query that caused the problem
+	 * @param string $endpoint string URL of endpoint that was used
+	 * @param string $sparql string query that caused the problem
 	 */
 	protected function mapHttpRequestError( $endpoint, $sparql ) {
 
@@ -566,7 +566,7 @@ 
 	 *
 	 * @param integer $timeout
 	 *
-	 * @return SparqlDatabase
+	 * @return GenericHttpRepositoryConnector
 	 */
 	public function setConnectionTimeoutInSeconds( $timeout = 10 ) {
 		$this->httpRequest->setOption( CURLOPT_CONNECTTIMEOUT, $timeout );