Completed
Push — master ( ff2cd3...da92b9 )
by mw
236:43 queued 201:44
created
src/SQLStore/EntityStore/CachedEntityLookup.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -402,6 +402,10 @@
 block discarded – undo
402 402
 		) . $suffix );
403 403
 	}
404 404
 
405
+	/**
406
+	 * @param string $id
407
+	 * @param DIWikiPage $subject
408
+	 */
405 409
 	private function appendToList( $id, $subject ) {
406 410
 
407 411
 		// Store the id with the main subject
Please login to merge, or discard this patch.
src/SQLStore/QueryDependency/QueryResultDependencyListResolver.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -232,6 +232,9 @@
 block discarded – undo
232 232
 		}
233 233
 	}
234 234
 
235
+	/**
236
+	 * @param DIWikiPage|null $subject
237
+	 */
235 238
 	private function doMatchSubproperty( &$subjects, $subject, DIProperty $property ) {
236 239
 
237 240
 		$subproperties = array();
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,6 @@
 block discarded – undo
13 13
 use SMW\Query\Language\SomeProperty;
14 14
 use SMW\Query\Language\ThingDescription;
15 15
 use SMW\Query\Language\ValueDescription;
16
-use SMW\Store;
17
-use SMWQuery as Query;
18 16
 use SMWQueryResult as QueryResult;
19 17
 
20 18
 /**
Please login to merge, or discard this patch.
src/Factbox/CachedFactbox.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@  discard block
 block discarded – undo
79 79
 	/**
80 80
 	 * @since 2.5
81 81
 	 *
82
-	 * @return boolean
82
+	 * @param integer $expiryInSeconds
83
+	 * @return boolean|null
83 84
 	 */
84 85
 	public function setExpiryInSeconds( $expiryInSeconds ) {
85 86
 		$this->expiryInSeconds = $expiryInSeconds;
@@ -88,7 +89,7 @@  discard block
 block discarded – undo
88 89
 	/**
89 90
 	 * @since 2.5
90 91
 	 *
91
-	 * @return boolean
92
+	 * @return boolean|null
92 93
 	 */
93 94
 	public function isEnabled( $isEnabled ) {
94 95
 		$this->isEnabled = $isEnabled;
@@ -280,6 +281,7 @@  discard block
 block discarded – undo
280 281
 	/**
281 282
 	 * Cached content is serialized in an associative array following:
282 283
 	 * { 'revId' => $revisionId, 'text' => (...) }
284
+	 * @param string $key
283 285
 	 */
284 286
 	private function saveToCache( $key, array $content ) {
285 287
 
Please login to merge, or discard this patch.
src/MediaWiki/Specials/SearchByProperty/PageRequestOptions.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -119,6 +119,10 @@  discard block
 block discarded – undo
119 119
 		$this->setNearbySearch();
120 120
 	}
121 121
 
122
+	/**
123
+	 * @param string $value
124
+	 * @param boolean $escaped
125
+	 */
122 126
 	private function getValue( $value, $escaped ) {
123 127
 
124 128
 		$this->value = DataValueFactory::getInstance()->newDataValueByProperty(
@@ -131,6 +135,9 @@  discard block
 block discarded – undo
131 135
 		return $this->value->isValid() ? $this->value->getWikiValue() : $value;
132 136
 	}
133 137
 
138
+	/**
139
+	 * @return string
140
+	 */
134 141
 	private function unescape( $value, $escaped ) {
135 142
 
136 143
 		if ( $this->value instanceof NumberValue ) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,11 +4,9 @@
 block discarded – undo
4 4
 
5 5
 use SMW\DataValueFactory;
6 6
 use SMW\DataValues\TelephoneUriValue;
7
-use SMWUriValue as UriValue;
8 7
 use SMW\UrlEncoder;
9 8
 use SMWNumberValue as NumberValue;
10 9
 use SMWPropertyValue as PropertyValue;
11
-use SMWStringValue as TextValue;
12 10
 
13 11
 /**
14 12
  * @license GNU GPL v2+
Please login to merge, or discard this patch.
src/Query/PrintRequest.php 2 patches
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 * @param integer $mode a constant defining what to printout
70 70
 	 * @param string $label the string label to describe this printout
71 71
 	 * @param mixed $data optional data for specifying some request, might be a property object, title, or something else; interpretation depends on $mode
72
-	 * @param mixed $outputformat optional string for specifying an output format, e.g. an output unit
72
+	 * @param string $outputformat optional string for specifying an output format, e.g. an output unit
73 73
 	 * @param array|null $params optional array of further, named parameters for the print request
74 74
 	 */
75 75
 	public function __construct( $mode, $label, $data = null, $outputformat = false, array $params = null ) {
@@ -137,6 +137,7 @@  discard block
 block discarded – undo
137 137
 
138 138
 	/**
139 139
 	 * Convenience method for accessing the text in either HTML or Wiki format.
140
+	 * @param integer $outputMode
140 141
 	 */
141 142
 	public function getText( $outputMode, $linker = null ) {
142 143
 		return Formatter::format( $this, $linker, $outputMode );
@@ -239,7 +240,7 @@  discard block
 block discarded – undo
239 240
 	/**
240 241
 	 * Sets a print request parameter.
241 242
 	 *
242
-	 * @param $key string Name of the parameter
243
+	 * @param string $key string Name of the parameter
243 244
 	 * @param $value string Value for the parameter
244 245
 	 */
245 246
 	public function setParameter( $key, $value ) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\Query;
4 4
 
5 5
 use InvalidArgumentException;
6
-use SMW\Localizer;
7 6
 use SMWDataValue;
8 7
 use SMWPropertyValue as PropertyValue;
9 8
 use SMW\DataValues\PropertyChainValue;
Please login to merge, or discard this patch.
src/Query/Result/ResultFieldMatchFinder.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -156,6 +156,9 @@  discard block
 block discarded – undo
156 156
 		return $options;
157 157
 	}
158 158
 
159
+	/**
160
+	 * @param DataItem $dataItem
161
+	 */
159 162
 	private function getResultsForProperty( $dataItem ) {
160 163
 
161 164
 		$content = $this->getResultContent(
@@ -212,6 +215,9 @@  discard block
 block discarded – undo
212 215
 		return $content;
213 216
 	}
214 217
 
218
+	/**
219
+	 * @param string $parameter
220
+	 */
215 221
 	private function isMultiValueWithParameter( $parameter ) {
216 222
 		return strpos( $this->printRequest->getTypeID(), '_rec' ) !== false && $this->printRequest->getParameter( $parameter ) !== false;
217 223
 	}
Please login to merge, or discard this patch.
includes/datavalues/SMW_DV_Record.php 2 patches
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	 *
60 60
 	 * @param string $value
61 61
 	 *
62
-	 * @return array
62
+	 * @return string[]
63 63
 	 */
64 64
 	public function getValuesFromString( $value ) {
65 65
 		// #664 / T17732
@@ -280,6 +280,10 @@  discard block
 block discarded – undo
280 280
 		return $result;
281 281
 	}
282 282
 
283
+	/**
284
+	 * @param integer $type
285
+	 * @param SMWDataValue $dataValue
286
+	 */
283 287
 	protected function makeValueOutputText( $type, $dataValue, $linker ) {
284 288
 		switch ( $type ) {
285 289
 			case 0:
@@ -295,6 +299,9 @@  discard block
 block discarded – undo
295 299
 		}
296 300
 	}
297 301
 
302
+	/**
303
+	 * @param string $value
304
+	 */
298 305
 	private function newContainerSemanticData( $value ) {
299 306
 
300 307
 		if ( $this->m_contextPage === null ) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SMW\ApplicationFactory;
6 6
 use SMW\DIProperty;
7 7
 use SMW\DIWikiPage;
8
-use SMWPropertyListValue as PropertyListValue;
9 8
 use SMWDataItem as DataItem;
10 9
 use SMWContainerSemanticData as ContainerSemanticData;
11 10
 use SMWDIContainer as DIContainer;
Please login to merge, or discard this patch.
src/PropertySpecificationLookup.php 1 patch
Doc Comments   +16 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 *
78 78
 	 * @param DIProperty $property
79 79
 	 *
80
-	 * @return false|DataItem
80
+	 * @return \SMWDataItem
81 81
 	 */
82 82
 	public function getFieldListBy( DIProperty $property ) {
83 83
 
@@ -383,6 +383,10 @@  discard block
 block discarded – undo
383 383
 		return $localPropertyDescription;
384 384
 	}
385 385
 
386
+	/**
387
+	 * @param DIProperty $property
388
+	 * @param string $languageCode
389
+	 */
386 390
 	private function getPredefinedPropertyDescription( $property, $linker, $languageCode ) {
387 391
 
388 392
 		$description = '';
@@ -411,6 +415,10 @@  discard block
 block discarded – undo
411 415
 		return $message;
412 416
 	}
413 417
 
418
+	/**
419
+	 * @param DIProperty $property
420
+	 * @param string $languageCode
421
+	 */
414 422
 	private function findLocalPropertyDescription( $property, $linker, $languageCode ) {
415 423
 
416 424
 		$text = '';
@@ -428,6 +436,10 @@  discard block
 block discarded – undo
428 436
 		return $text;
429 437
 	}
430 438
 
439
+	/**
440
+	 * @param DIProperty $property
441
+	 * @param string $languageCode
442
+	 */
431 443
 	private function findPreferredPropertyLabel( $property, $languageCode ) {
432 444
 
433 445
 		$text = '';
@@ -445,6 +457,9 @@  discard block
 block discarded – undo
445 457
 		return $text;
446 458
 	}
447 459
 
460
+	/**
461
+	 * @param DIProperty $property
462
+	 */
448 463
 	private function findTextValueByLanguage( $dataItems, $property, $languageCode ) {
449 464
 
450 465
 		if ( $dataItems === null || $dataItems === array() ) {
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/OrderConditionsComplementor.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	/**
78 78
 	 * @since 2.5
79 79
 	 *
80
-	 * @return array
80
+	 * @return string[]
81 81
 	 */
82 82
 	public function getErrors() {
83 83
 		return $this->querySegmentListBuilder->getErrors();
@@ -120,6 +120,9 @@  discard block
 block discarded – undo
120 120
 		return $this->querySegmentListBuilder->getQuerySegmentList();
121 121
 	}
122 122
 
123
+	/**
124
+	 * @param QuerySegment $querySegment
125
+	 */
123 126
 	private function collectExtraDescriptionsFromSortKeys( $querySegment ) {
124 127
 
125 128
 		$extraDescriptions = array();
@@ -138,6 +141,10 @@  discard block
 block discarded – undo
138 141
 		return $extraDescriptions;
139 142
 	}
140 143
 
144
+	/**
145
+	 * @param string $label
146
+	 * @param string $order
147
+	 */
141 148
 	private function findExtraDescriptionBy( $querySegment, $label, $order ) {
142 149
 
143 150
 		$description = null;
@@ -171,6 +178,9 @@  discard block
 block discarded – undo
171 178
 		return $description;
172 179
 	}
173 180
 
181
+	/**
182
+	 * @param QuerySegment $querySegment
183
+	 */
174 184
 	private function addConjunctionFromExtraDescriptions( $querySegment, array $extraDescriptions ) {
175 185
 
176 186
 		$this->querySegmentListBuilder->setSortKeys(
Please login to merge, or discard this patch.