Completed
Push — master ( ff2cd3...da92b9 )
by mw
236:43 queued 201:44
created
SPARQLStore/QueryEngine/DescriptionInterpreters/ConjunctionInterpreter.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -100,6 +100,10 @@  discard block
 block discarded – undo
100 100
 		return $result;
101 101
 	}
102 102
 
103
+	/**
104
+	 * @param string $joinVariable
105
+	 * @param \SMW\DIProperty|null $orderByProperty
106
+	 */
103 107
 	private function doPreliminarySubDescriptionCheck( $subDescriptions, $joinVariable, $orderByProperty ) {
104 108
 
105 109
 		$count = count( $subDescriptions );
@@ -126,6 +130,9 @@  discard block
 block discarded – undo
126 130
 		return null;
127 131
 	}
128 132
 
133
+	/**
134
+	 * @param string $joinVariable
135
+	 */
129 136
 	private function doResolveSubDescriptionsRecursively( $subDescriptions, $joinVariable ) {
130 137
 
131 138
 		// Using a stdClass as data container for simpler handling in follow-up tasks
@@ -195,6 +202,9 @@  discard block
 block discarded – undo
195 202
 		return $subConditionElements;
196 203
 	}
197 204
 
205
+	/**
206
+	 * @param \stdClass $subConditionElements
207
+	 */
198 208
 	private function createConditionFromSubConditionElements( $subConditionElements ) {
199 209
 
200 210
 		if ( $subConditionElements->singletonMatchElement instanceof ExpElement ) {
Please login to merge, or discard this patch.
SPARQLStore/QueryEngine/DescriptionInterpreters/DisjunctionInterpreter.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -107,6 +107,10 @@  discard block
 block discarded – undo
107 107
 		return $result;
108 108
 	}
109 109
 
110
+	/**
111
+	 * @param string $joinVariable
112
+	 * @param \SMW\DIProperty|null $orderByProperty
113
+	 */
110 114
 	private function doPreliminarySubDescriptionCheck( $subDescriptions, $joinVariable, $orderByProperty ) {
111 115
 
112 116
 		$count = count( $subDescriptions );
@@ -131,6 +135,10 @@  discard block
 block discarded – undo
131 135
 		return null;
132 136
 	}
133 137
 
138
+	/**
139
+	 * @param string $joinVariable
140
+	 * @param \SMW\DIProperty|null $orderByProperty
141
+	 */
134 142
 	private function doResolveSubDescriptionsRecursively( $subDescriptions, $joinVariable, $orderByProperty ) {
135 143
 
136 144
 		// Using a stdClass as data container for simpler handling in follow-up tasks
@@ -213,6 +221,9 @@  discard block
 block discarded – undo
213 221
 		return $subConditionElements;
214 222
 	}
215 223
 
224
+	/**
225
+	 * @param string $joinVariable
226
+	 */
216 227
 	private function createConditionFromSubConditionElements( $subConditionElements, $joinVariable ) {
217 228
 
218 229
 		if ( $subConditionElements->unionCondition === '' ) {
Please login to merge, or discard this patch.
SPARQLStore/QueryEngine/DescriptionInterpreters/SomePropertyInterpreter.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -150,6 +150,10 @@  discard block
 block discarded – undo
150 150
 		return array( $innerOrderByProperty, $innerCondition, $innerJoinVariable );
151 151
 	}
152 152
 
153
+	/**
154
+	 * @param \SMW\SPARQLStore\QueryEngine\Condition\Condition $innerCondition
155
+	 * @param string $innerJoinVariable
156
+	 */
153 157
 	private function findObjectNameFromInnerCondition( $innerCondition, $innerJoinVariable, &$namespaces ) {
154 158
 
155 159
 		if ( !$innerCondition instanceof SingletonCondition ) {
@@ -201,6 +205,10 @@  discard block
 block discarded – undo
201 205
 		return TurtleSerializer::getTurtleNameForExpElement( $propertyExpElement );
202 206
 	}
203 207
 
208
+	/**
209
+	 * @param string $objectName
210
+	 * @param string $joinVariable
211
+	 */
204 212
 	private function doExchangeForWhenInversePropertyIsUsed( DIProperty $property, $objectName, $joinVariable ) {
205 213
 
206 214
 		$subjectName = '?' . $joinVariable;
@@ -239,6 +247,8 @@  discard block
 block discarded – undo
239 247
 	 * can be found using the "zero or more" will resolve the complete path
240 248
 	 *
241 249
 	 * @see http://www.w3.org/TR/sparql11-query/#propertypath-arbitrary-length
250
+	 * @param \SMW\SPARQLStore\QueryEngine\Condition\Condition $condition
251
+	 * @param string $propertyName
242 252
 	 */
243 253
 	private function tryToAddPropertyPathForSaturatedHierarchy( &$condition, DIProperty $property, &$propertyName ) {
244 254
 
Please login to merge, or discard this patch.
QueryEngine/DescriptionInterpreters/ValueDescriptionInterpreter.php 1 patch
Doc Comments   +19 added lines patch added patch discarded remove patch
@@ -104,10 +104,18 @@  discard block
 block discarded – undo
104 104
 		);
105 105
 	}
106 106
 
107
+	/**
108
+	 * @param string $joinVariable
109
+	 * @param \SMW\DIProperty|null $orderByProperty
110
+	 */
107 111
 	private function createConditionForEmptyComparator( $joinVariable, $orderByProperty ) {
108 112
 		return $this->compoundConditionBuilder->newTrueCondition( $joinVariable, $orderByProperty );
109 113
 	}
110 114
 
115
+	/**
116
+	 * @param string $joinVariable
117
+	 * @param \SMW\DIProperty|null $orderByProperty
118
+	 */
111 119
 	private function createConditionForEqualityComparator( $dataItem, $property, $joinVariable, $orderByProperty ) {
112 120
 
113 121
 		$expElement = $this->exporter->getDataItemHelperExpElement( $dataItem );
@@ -153,6 +161,11 @@  discard block
 block discarded – undo
153 161
 		return $condition;
154 162
 	}
155 163
 
164
+	/**
165
+	 * @param string $joinVariable
166
+	 * @param \SMW\DIProperty|null $orderByProperty
167
+	 * @param string $comparator
168
+	 */
156 169
 	private function createConditionForRegexComparator( $dataItem, $joinVariable, $orderByProperty, $comparator ) {
157 170
 
158 171
 		if ( !$dataItem instanceof DIBlob && !$dataItem instanceof DIWikiPage && !$dataItem instanceof DIUri ) {
@@ -196,6 +209,9 @@  discard block
 block discarded – undo
196 209
 		return $condition;
197 210
 	}
198 211
 
212
+	/**
213
+	 * @param string $comparator
214
+	 */
199 215
 	private function createFilterConditionForAnyOtherComparator( $dataItem, $joinVariable, $orderByProperty, $comparator ) {
200 216
 
201 217
 		$result = new FilterCondition( '', array() );
@@ -228,6 +244,9 @@  discard block
 block discarded – undo
228 244
 		return $result;
229 245
 	}
230 246
 
247
+	/**
248
+	 * @param string $pattern
249
+	 */
231 250
 	private function createFilterConditionToMatchRegexPattern( $dataItem, &$joinVariable, $comparator, $pattern ) {
232 251
 
233 252
 		if ( $dataItem instanceof DIBlob ) {
Please login to merge, or discard this patch.
QueryEngine/DescriptionInterpreters/DispatchingDescriptionInterpreter.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	/**
45 45
 	 * @param Description $description
46 46
 	 *
47
-	 * @return QuerySegment
47
+	 * @return \SMW\SQLStore\QueryEngine\QuerySegment
48 48
 	 * @throws InvalidArgumentException
49 49
 	 */
50 50
 	public function interpretDescription( Description $description ) {
@@ -63,7 +63,6 @@  discard block
 block discarded – undo
63 63
 	/**
64 64
 	 * @since  2.2
65 65
 	 *
66
-	 * @param DescriptionInterpreter $defaultInterpreter
67 66
 	 */
68 67
 	public function addInterpreter( DescriptionInterpreter $interpreter ) {
69 68
 		$this->interpreters[] = $interpreter;
Please login to merge, or discard this patch.
SQLStore/QueryEngine/DescriptionInterpreters/SomePropertyInterpreter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
 	 * ValueDescription objects, create and return a plain WHERE condition
198 198
 	 * string for it.
199 199
 	 *
200
-	 * @param $query
200
+	 * @param QuerySegment $query
201 201
 	 * @param Description $description
202 202
 	 * @param SMWSQLStore3Table $proptable
203 203
 	 * @param DataItemHandler $diHandler for that table
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -723,7 +723,7 @@  discard block
 block discarded – undo
723 723
 	 *
724 724
 	 * @param integer $sid
725 725
 	 * @param DIWikiPage $subject
726
-	 * @param integer|string|null $interWiki
726
+	 * @param string $interWiki
727 727
 	 */
728 728
 	public function updateInterwikiField( $sid, DIWikiPage $subject, $interWiki = null ) {
729 729
 
@@ -978,9 +978,8 @@  discard block
 block discarded – undo
978 978
 	/**
979 979
 	 * @since 2.3
980 980
 	 *
981
-	 * @param integer $id
982 981
 	 *
983
-	 * @return string[]
982
+	 * @return SMW\Iterators\MappingIterator
984 983
 	 */
985 984
 	public function getDataItemPoolHashListFor( array $idlist ) {
986 985
 		return $this->idToDataItemMatchFinder->getDataItemPoolHashListFor( $idlist );
Please login to merge, or discard this patch.
src/IteratorFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 	/**
28 28
 	 * @since 2.5
29 29
 	 *
30
-	 * @param Iterator/array $$iterable
30
+	 * @param Iterator/array $iterable
31 31
 	 * @param callable $callback
32 32
 	 *
33 33
 	 * @return MappingIterator
Please login to merge, or discard this patch.
tests/phpunit/Unit/Iterators/ResultIteratorTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SMW\Iterators\Tests;
4 4
 
5 5
 use SMW\Iterators\ResultIterator;
6
-use ArrayIterator;
7 6
 
8 7
 /**
9 8
  * @covers \SMW\Iterators\ResultIterator
Please login to merge, or discard this patch.