Issues in ConceptToExpDataMapper.php - All Issues - Inspection of "Merge pull request #1876 from SemanticMediaWiki/re..." - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9cb597...d2d2ad )

by mw

created 2016-09-25 12:17 UTC

src/Exporter/ConceptToExpDataMapper.php (36 issues)

Labels

Severity

Minor 36

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\Exporter;

use SMW\ApplicationFactory;
use SMW\DataValueFactory;
use SMW\DIConcept;
use SMW\DIProperty;
use SMW\Exporter\Element\ExpResource;
use SMW\Query\Language\ClassDescription;
use SMW\Query\Language\ConceptDescription;
use SMW\Query\Language\Conjunction;
use SMW\Query\Language\Description;
use SMW\Query\Language\Disjunction;
use SMW\Query\Language\SomeProperty;
use SMW\Query\Language\ThingDescription;
use SMW\Query\Language\ValueDescription;
use SMWDataItem as DataItem;
use SMWExpData as ExpData;
use SMWExporter as Exporter;

/**
 * @license GNU GPL v2+
 * @since 2.4
 *
 * @author Markus Krötzsch
 * @author mwjames
 */
class ConceptToExpDataMapper {

	/**
	 * @var Exporter
	 */
	private $exporter;

	/**
	 * @since 2.4
	 *
	 * @param Exporter|null $exporter
	 */
	public function __construct( Exporter $exporter = null ) {
		$this->exporter = $exporter;

		if ( $this->exporter === null ) {
			$this->exporter = Exporter::getInstance();
		}
	}

	/**
	 * @since 2.4
	 *
	 * @param DataItem $dataItem
	 *
	 * @return boolean
	 */
	public function isMapperFor( DataItem $dataItem ) {
		return $dataItem instanceof DIConcept;
	}

	/**
	 * @since 2.4
	 *
	 * @param DIConcept $concept
	 *
	 * @return ExpData|null
	 */
	public function getElementFor( DIConcept $concept ) {

		$dataValue = DataValueFactory::getInstance()->newDataValueByItem(
			$concept
		);

		if ( !$dataValue->isValid() ) {
			return null;
		}

		$description = ApplicationFactory::getInstance()->newQueryParser()->getQueryDescription(

			$dataValue->getWikiValue()
		);

		$exact = true;
		$owlDescription = $this->getExpDataFromDescription( $description, $exact );

		if ( $owlDescription === false ) {
			$result = new ExpData(
				$this->exporter->getSpecialNsResource( 'owl', 'Thing' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			);

			return $result;
		}

		if ( $exact ) {
			return $owlDescription;
		}

		$result = new ExpData(
			new ExpResource( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'rdf', 'type' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			new ExpData( $this->exporter->getSpecialNsResource( 'owl', 'Class' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'rdfs', 'subClassOf' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$owlDescription
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		);

		return $result;
	}

	/**
	 * @since 2.4
	 *
	 * @param Description $description
	 *
	 * @param string &$exact
	 *
	 * @return Element|false
	 */
	public function getExpDataFromDescription( Description $description, &$exact ) {

		if ( ( $description instanceof Conjunction ) || ( $description instanceof Disjunction ) ) {
			$result = $this->doMapConjunctionDisjunction( $description, $exact );
		} elseif ( $description instanceof ClassDescription ) {
			$result = $this->doMapClassDescription( $description, $exact );
		} elseif ( $description instanceof ConceptDescription ) {
			$result = $this->doMapConceptDescription( $description, $exact );
		} elseif ( $description instanceof SomeProperty ) {
			$result = $this->doMapSomeProperty( $description, $exact );
		} elseif ( $description instanceof ValueDescription ) {
			$result = $this->doMapValueDescription( $description, $exact );
		} elseif ( $description instanceof ThingDescription ) {
			$result = false;
		} else {
			$result = false;
			$exact = false;
		}

		return $result;
	}

	private function doMapValueDescription( ValueDescription $description, &$exact ) {

		if ( $description->getComparator() === SMW_CMP_EQ ) {
			$result = $this->exporter->getDataItemExpElement( $description->getDataItem() );
		} else {
			// OWL cannot represent <= and >= ...
			$exact = false;
			$result = false;
		}

		return $result;
	}

	private function doMapConceptDescription( ConceptDescription $description, &$exact ) {


		$result = new ExpData(
			$this->exporter->getResourceElementForWikiPage( $description->getConcept() )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		return $result;
	}

	private function doMapSomeProperty( SomeProperty $description, &$exact ) {

		$result = new ExpData(
			new ExpResource( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'rdf', 'type' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			new ExpData( $this->exporter->getSpecialNsResource( 'owl', 'Restriction' ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$property = $description->getProperty();

		if ( $property->isInverse() ) {
			$property = new DIProperty( $property->getKey() );
		}

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'owl', 'onProperty' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			new ExpData(
				$this->exporter->getResourceElementForProperty( $property )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			)
		);

		$subdata = $this->getExpDataFromDescription(
			$description->getDescription(),
			$exact
		);

		if ( ( $description->getDescription() instanceof ValueDescription ) &&
		     ( $description->getDescription()->getComparator() === SMW_CMP_EQ ) ) {
			$result->addPropertyObjectValue(
				$this->exporter->getSpecialNsResource( 'owl', 'hasValue' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$subdata
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			);
		} else {
			if ( $subdata === false ) {

				$owltype = $this->exporter->getOWLPropertyType(
					$description->getProperty()->findPropertyTypeID()
				);

				if ( $owltype == 'ObjectProperty' ) {
					$subdata = new ExpData(
						$this->exporter->getSpecialNsResource( 'owl', 'Thing' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
					);
				} elseif ( $owltype == 'DatatypeProperty' ) {
					$subdata = new ExpData(
						$this->exporter->getSpecialNsResource( 'rdfs', 'Literal' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
					);
				} else { // no restrictions at all with annotation properties ...
					return new ExpData(
						$this->exporter->getSpecialNsResource( 'owl', 'Thing' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
					);
				}
			}

			$result->addPropertyObjectValue(
				$this->exporter->getSpecialNsResource( 'owl', 'someValuesFrom' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$subdata
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			);
		}

		return $result;
	}

	private function doMapClassDescription( ClassDescription $description, &$exact ) {


		if ( count( $description->getCategories() ) == 1 ) { // single category
			$categories = $description->getCategories();
			$result = new ExpData(
				$this->exporter->getResourceElementForWikiPage( end( $categories ) )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			);
		} else { // disjunction of categories

			$result = new ExpData(
				new ExpResource( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			);

			$elements = array();

			foreach ( $description->getCategories() as $cat ) {
				$elements[] = new ExpData(
					$this->exporter->getResourceElementForWikiPage( $cat )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				);
			}

			$result->addPropertyObjectValue(
				$this->exporter->getSpecialNsResource( 'owl', 'unionOf' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				ExpData::makeCollection( $elements )
			);
		}

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'rdf', 'type' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			new ExpData(
				$this->exporter->getSpecialNsResource( 'owl', 'Class' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			)
		);

		return $result;
	}

	private function doMapConjunctionDisjunction( Description $description, &$exact ) {

		$result = new ExpData(
			new ExpResource( '' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		);

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'rdf', 'type' ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			new ExpData(
				$this->exporter->getSpecialNsResource( 'owl', 'Class' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			)
		);

		$elements = array();

		foreach ( $description->getDescriptions() as $subdesc ) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			$element = $this->getExpDataFromDescription( $subdesc, $exact );

			if ( $element === false ) {
				$element = new ExpData(
					$this->exporter->getSpecialNsResource( 'owl', 'Thing' )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				);
			}

			$elements[] = $element;
		}

		$prop = $description instanceof Conjunction ? 'intersectionOf' : 'unionOf';

		$result->addPropertyObjectValue(
			$this->exporter->getSpecialNsResource( 'owl', $prop ),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			ExpData::makeCollection( $elements )
		);

		return $result;
	}

}


Push — master ( 9cb597...d2d2ad )

src/Exporter/ConceptToExpDataMapper.php (36 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			namespace SMW\Exporter;
4
5			use SMW\ApplicationFactory;
6			use SMW\DataValueFactory;
7			use SMW\DIConcept;
8			use SMW\DIProperty;
9			use SMW\Exporter\Element\ExpResource;
10			use SMW\Query\Language\ClassDescription;
11			use SMW\Query\Language\ConceptDescription;
12			use SMW\Query\Language\Conjunction;
13			use SMW\Query\Language\Description;
14			use SMW\Query\Language\Disjunction;
15			use SMW\Query\Language\SomeProperty;
16			use SMW\Query\Language\ThingDescription;
17			use SMW\Query\Language\ValueDescription;
18			use SMWDataItem as DataItem;
19			use SMWExpData as ExpData;
20			use SMWExporter as Exporter;
21
22			/**
23			* @license GNU GPL v2+
24			* @since 2.4
25			*
26			* @author Markus Krötzsch
27			* @author mwjames
28			*/
29			class ConceptToExpDataMapper {
30
31			/**
32			* @var Exporter
33			*/
34			private $exporter;
35
36			/**
37			* @since 2.4
38			*
39			* @param Exporter\|null $exporter
40			*/

SemanticMediaWiki / SemanticMediaWiki

Push — master ( 9cb597...d2d2ad )

src/Exporter/ConceptToExpDataMapper.php (36 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like