Completed
Push — master ( 30add5...f043e7 )
by mw
14s
created
includes/storage/SMW_SQLHelpers.php 1 patch
Doc Comments   +2 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,8 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * @note The function partly ignores the order in which fields are set up.
64 64
 	 * Only if the type of some field changes will its order be adjusted explicitly.
65 65
 	 *
66
-	 * @param string $tableName The table name. Does not need to have been passed to DatabaseBase->tableName yet.
67
-	 * @param array $columns The fields and their types the table should have.
66
+	 * @param string $rawTableName The table name. Does not need to have been passed to DatabaseBase->tableName yet.
68 67
 	 * @param DatabaseBase or Database $db
69 68
 	 * @param object $reportTo Object to report back to.
70 69
 	 */
@@ -88,7 +87,6 @@  discard block
 block discarded – undo
88 87
 	 * Creates a new database table with the specified fields.
89 88
 	 *
90 89
 	 * @param string $tableName The table name.
91
-	 * @param array $columns The fields and their types the table should have.
92 90
 	 * @param DatabaseBase|Database $db
93 91
 	 */
94 92
 	private static function createTable( $tableName, array $fields, $db ) {
@@ -116,7 +114,6 @@  discard block
 block discarded – undo
116 114
 	 * Update a table given an array of field names and field types.
117 115
 	 *
118 116
 	 * @param string $tableName The table name.
119
-	 * @param array $columns The fields and their types the table should have.
120 117
 	 * @param DatabaseBase|Database $db
121 118
 	 * @param object $reportTo Object to report back to.
122 119
 	 */
@@ -344,7 +341,7 @@  discard block
 block discarded – undo
344 341
 	 * Make sure that each of the column descriptions in the given array is
345 342
 	 * indexed by *one* index in the given DB table.
346 343
 	 *
347
-	 * @param string $tableName table name. Does not need to have been passed to DatabaseBase->tableName yet.
344
+	 * @param string $rawTableName table name. Does not need to have been passed to DatabaseBase->tableName yet.
348 345
 	 * @param array $indexes array of strings, each a comma separated list with column names to index
349 346
 	 * @param DatabaseBase|Database $db DatabaseBase or Database
350 347
 	 * @param object $reportTo object to report messages to; since 1.8
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -637,7 +637,7 @@  discard block
 block discarded – undo
637 637
 	 *
638 638
 	 * @param integer $sid
639 639
 	 * @param DIWikiPage $subject
640
-	 * @param integer|string|null $interWiki
640
+	 * @param string $interWiki
641 641
 	 */
642 642
 	public function updateInterwikiField( $sid, DIWikiPage $subject, $interWiki = null ) {
643 643
 
@@ -891,9 +891,8 @@  discard block
 block discarded – undo
891 891
 	/**
892 892
 	 * @since 2.3
893 893
 	 *
894
-	 * @param integer $id
895 894
 	 *
896
-	 * @return string[]
895
+	 * @return DIWikiPage[]
897 896
 	 */
898 897
 	public function getDataItemPoolHashListFor( array $idlist ) {
899 898
 		return $this->byIdDataItemFinder->getDataItemPoolHashListFor( $idlist );
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_Sql3StubSemanticData.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 *
76 76
 	 * @since 2.3
77 77
 	 *
78
-	 * @return array
78
+	 * @return string[]
79 79
 	 */
80 80
 	public function __sleep() {
81 81
 		return array( 'mSubject', 'mPropVals', 'mProperties', 'subSemanticData', 'mStubPropVals' );
@@ -203,6 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * yet to ensure data consistency
204 204
 	 *
205 205
 	 * @since 2.0
206
+	 * @param string $subobjectName
206 207
 	 */
207 208
 	public function hasSubSemanticData( $subobjectName = null ) {
208 209
 
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3.php 1 patch
Doc Comments   +10 added lines, -7 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return $this->reader;
237 237
 	}
238 238
 
239
+	/**
240
+	 * @return SemanticData
241
+	 */
239 242
 	public function getSemanticData( DIWikiPage $subject, $filter = false ) {
240 243
 
241 244
 		$result = $this->cachedValueLookupStore->getSemanticData(
@@ -247,9 +250,9 @@  discard block
 block discarded – undo
247 250
 	}
248 251
 
249 252
 	/**
250
-	 * @param mixed $subject
253
+	 * @param DIWikiPage $subject
251 254
 	 * @param DIProperty $property
252
-	 * @param null $requestoptions
255
+	 * @param null $requestOptions
253 256
 	 *
254 257
 	 * @return SMWDataItem[]
255 258
 	 */
@@ -386,7 +389,7 @@  discard block
 block discarded – undo
386 389
 	/**
387 390
 	 * @param RequestOptions|null $requestOptions
388 391
 	 *
389
-	 * @return CachedListLookup
392
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
390 393
 	 */
391 394
 	public function getPropertiesSpecial( $requestOptions = null ) {
392 395
 		return $this->factory->newPropertyUsageCachedListLookup( $requestOptions );
@@ -395,7 +398,7 @@  discard block
 block discarded – undo
395 398
 	/**
396 399
 	 * @param RequestOptions|null $requestOptions
397 400
 	 *
398
-	 * @return CachedListLookup
401
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
399 402
 	 */
400 403
 	public function getUnusedPropertiesSpecial( $requestOptions = null ) {
401 404
 		return $this->factory->newUnusedPropertyCachedListLookup( $requestOptions );
@@ -404,7 +407,7 @@  discard block
 block discarded – undo
404 407
 	/**
405 408
 	 * @param RequestOptions|null $requestOptions
406 409
 	 *
407
-	 * @return CachedListLookup
410
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
408 411
 	 */
409 412
 	public function getWantedPropertiesSpecial( $requestOptions = null ) {
410 413
 		return $this->factory->newUndeclaredPropertyCachedListLookup( $requestOptions );
@@ -452,7 +455,7 @@  discard block
 block discarded – undo
452 455
 	 *
453 456
 	 * @since 1.8
454 457
 	 * @param Title $concept
455
-	 * @return array of error strings (empty if no errors occurred)
458
+	 * @return string[] of error strings (empty if no errors occurred)
456 459
 	 */
457 460
 	public function refreshConceptCache( Title $concept ) {
458 461
 		return $this->factory->newMasterConceptCache()->refreshConceptCache( $concept );
@@ -494,7 +497,7 @@  discard block
 block discarded – undo
494 497
 	 * @since 1.8
495 498
 	 *
496 499
 	 * @param SMWRequestOptions|null $requestOptions
497
-	 * @param string $valuecol
500
+	 * @param string $valueCol
498 501
 	 *
499 502
 	 * @return array
500 503
 	 */
Please login to merge, or discard this patch.
includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -243,6 +243,7 @@
 block discarded – undo
243 243
 	 * Create some initial DB entries for important built-in properties. Having the DB contents predefined
244 244
 	 * allows us to safe DB calls when certain data is needed. At the same time, the entries in the DB
245 245
 	 * make sure that DB-based functions work as with all other properties.
246
+	 * @param boolean $verbose
246 247
 	 */
247 248
 	protected function setupPredefinedProperties( $verbose, DatabaseBase $db ) {
248 249
 		global $wgDBtype;
Please login to merge, or discard this patch.
DVDescriptionDeserializer/RecordValueDescriptionDeserializer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -93,6 +93,9 @@
 block discarded – undo
93 93
 		}
94 94
 	}
95 95
 
96
+	/**
97
+	 * @param integer $propertyIndex
98
+	 */
96 99
 	private function getDescriptionForProperty( $diProperty, $values, &$valueIndex, $propertyIndex ) {
97 100
 
98 101
 		$values[$valueIndex] = str_replace( "-3B", ";", $values[$valueIndex] );
Please login to merge, or discard this patch.
DVDescriptionDeserializer/TimeValueDescriptionDeserializer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -91,6 +91,9 @@
 block discarded – undo
91 91
 		return $description;
92 92
 	}
93 93
 
94
+	/**
95
+	 * @param \SMWDataItem $dataItem
96
+	 */
94 97
 	private function getUpperLimit( $dataItem ) {
95 98
 
96 99
 		$prec = $dataItem->getPrecision();
Please login to merge, or discard this patch.
src/Deserializers/ExpDataDeserializer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@
 block discarded – undo
50 50
 		return new ExpData( ExpElement::newFromSerialization( $subject ) );
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param ExpData $expData
55
+	 */
53 56
 	private function doDeserialize( $serialization, $expData ) {
54 57
 
55 58
 		foreach ( $serialization['data'] as $data ) {
Please login to merge, or discard this patch.
src/Deserializers/SemanticDataDeserializer.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -95,6 +95,7 @@  discard block
 block discarded – undo
95 95
 	}
96 96
 
97 97
 	/**
98
+	 * @param DIProperty $property
98 99
 	 * @return DataItem
99 100
 	 */
100 101
 	private function doDeserializeDataItem( $property, $data, $value, $semanticData ) {
@@ -154,6 +155,7 @@  discard block
 block discarded – undo
154 155
 	 * otherwise the subobject is neglected (of course one could set an error
155 156
 	 * value to the DIContainer but as of now that seems unnecessary)
156 157
 	 *
158
+	 * @param SMWContainerSemanticData $semanticData
157 159
 	 * @return DIContainer|null
158 160
 	 */
159 161
 	private function unserializeSubobject( $data, $id, $semanticData ) {
Please login to merge, or discard this patch.