Inspection of "Merge pull request #1543 from SemanticMediaWiki/na..." - SemanticMediaWiki/SemanticMediaWiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 30add5...f043e7 )

by mw

created 2016-04-30 06:13 UTC

Status

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -97,7 +97,7 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAreaValue() {
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getFoundedValue() {
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAverageHighTemperatureValue() {
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationValue() {
 
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationDensityValue() {
 

Please login to merge, or discard this patch.

tests/phpunit/Utils/Fixtures/Facts/FranceFactsheet.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -85,7 +85,7 @@
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 

Please login to merge, or discard this patch.

tests/phpunit/Utils/Fixtures/Facts/ParisFactsheet.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getLocatedInValue() {
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAreaValue() {
 
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Berlin
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getAverageHighTemperatureValue() {
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Paris
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationValue() {
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
 	 *
 	 * @see https://en.wikipedia.org/wiki/Demographics_of_Paris
 	 *
-	 * @return DataValue
+	 * @return \SMWDataValue
 	 */
 	public function getPopulationDensityValue() {
 

Please login to merge, or discard this patch.

tests/phpunit/Utils/Mock/MockObjectBuilder.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 	 *
 	 * @since 1.9
 	 *
-	 * @param $objectName
+	 * @param string $objectName
 	 * @param $objectArguments
 	 *
 	 * @return mixed
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	 * @since 1.9
 	 *
 	 * @param $length
-	 * @param $prefix identify a specific random string during testing
+	 * @param string $prefix identify a specific random string during testing
 	 *
 	 * @return string
 	 */
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 	 *
 	 * @since 1.9
 	 *
-	 * @param $key
+	 * @param string $key
 	 *
 	 * @return boolean
 	 */
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
 	/**
 	 * @since 1.9
 	 *
-	 * @param $objectName
+	 * @param string $objectName
 	 *
 	 * @return MockObjectRepository|null
 	 */

Please login to merge, or discard this patch.

tests/phpunit/Utils/Page/PageEditor.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @param Title $title
+	 * @param Title|null $title
 	 *
 	 * @return PageEditor
 	 */

Please login to merge, or discard this patch.

tests/phpunit/Utils/PageReader.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@
 block discarded – undo
 	 *
 	 * @param Title $title
 	 *
-	 * @return text
+	 * @return string
 	 */
 	public function getContentAsText( Title $title ) {
 

Please login to merge, or discard this patch.

tests/phpunit/Utils/Runners/XmlImportRunner.php 1 patch

Doc Comments +4 added lines, -1 removed lines patch added patch discarded remove patch

@@ -26,6 +26,9 @@  discard block
 block discarded – undo
 	protected $result = null;
 	protected $verbose = false;
 
+	/**
+	 * @param string $file
+	 */
 	public function __construct( $file = null ) {
 		$this->file = $file;
 	}
@@ -115,7 +118,7 @@  discard block
 block discarded – undo
 	}
 
 	/**
-	 * @return integer
+	 * @return double
 	 */
 	public function getElapsedImportTimeInSeconds() {
 		return round( $this->importTime, 7 );

Please login to merge, or discard this patch.

tests/phpunit/Utils/UtilityFactory.php 1 patch

Doc Comments -1 removed lines patch added patch discarded remove patch

@@ -156,7 +156,6 @@
 block discarded – undo
 	/**
 	 * @since 2.1
 	 *
-	 * @param string $file|null
 	 *
 	 * @return JsonFileReader
 	 */

Please login to merge, or discard this patch.

tests/phpunit/Utils/Validators/ExportDataValidator.php 1 patch

Doc Comments -2 removed lines patch added patch discarded remove patch

@@ -22,7 +22,6 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.0
 	 *
-	 * @param mixed $expected
 	 * @param ExpData $exportData
 	 */
 	public function assertThatExportDataContainsProperty( $expectedProperties, ExpData $exportData ) {
@@ -57,7 +56,6 @@  discard block
 block discarded – undo
 	/**
 	 * @since 2.0
 	 *
-	 * @param mixed $expected
 	 * @param ExpResource $selectedElement
 	 * @param ExpData $exportData
 	 */

Please login to merge, or discard this patch.

		@@ -97,7 +97,7 @@ discard block
		block discarded – undo
97	97	/**
98	98	* @since 2.1
99	99	*
100		- * @return DataValue
	100	+ * @return \SMWDataValue
101	101	*/
102	102	public function getLocatedInValue() {
103	103
		@@ -114,7 +114,7 @@ discard block
		block discarded – undo
114	114	*
115	115	* @see https://en.wikipedia.org/wiki/Berlin
116	116	*
117		- * @return DataValue
	117	+ * @return \SMWDataValue
118	118	*/
119	119	public function getAreaValue() {
120	120
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	*
132	132	* @see https://en.wikipedia.org/wiki/Berlin
133	133	*
134		- * @return DataValue
	134	+ * @return \SMWDataValue
135	135	*/
136	136	public function getFoundedValue() {
137	137
		@@ -148,7 +148,7 @@ discard block
		block discarded – undo
148	148	*
149	149	* @see https://en.wikipedia.org/wiki/Berlin
150	150	*
151		- * @return DataValue
	151	+ * @return \SMWDataValue
152	152	*/
153	153	public function getAverageHighTemperatureValue() {
154	154
		@@ -166,7 +166,7 @@ discard block
		block discarded – undo
166	166	*
167	167	* @see https://en.wikipedia.org/wiki/Berlin
168	168	*
169		- * @return DataValue
	169	+ * @return \SMWDataValue
170	170	*/
171	171	public function getPopulationValue() {
172	172
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	*
184	184	* @see https://en.wikipedia.org/wiki/Demographics_of_Berlin
185	185	*
186		- * @return DataValue
	186	+ * @return \SMWDataValue
187	187	*/
188	188	public function getPopulationDensityValue() {
189	189

		@@ -85,7 +85,7 @@
		block discarded – undo
85	85	/**
86	86	* @since 2.1
87	87	*
88		- * @return DataValue
	88	+ * @return \SMWDataValue
89	89	*/
90	90	public function getLocatedInValue() {
91	91

		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	/**
96	96	* @since 2.1
97	97	*
98		- * @return DataValue
	98	+ * @return \SMWDataValue
99	99	*/
100	100	public function getLocatedInValue() {
101	101
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	*
113	113	* @see https://en.wikipedia.org/wiki/Berlin
114	114	*
115		- * @return DataValue
	115	+ * @return \SMWDataValue
116	116	*/
117	117	public function getAreaValue() {
118	118
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	*
131	131	* @see https://en.wikipedia.org/wiki/Berlin
132	132	*
133		- * @return DataValue
	133	+ * @return \SMWDataValue
134	134	*/
135	135	public function getAverageHighTemperatureValue() {
136	136
		@@ -148,7 +148,7 @@ discard block
		block discarded – undo
148	148	*
149	149	* @see https://en.wikipedia.org/wiki/Demographics_of_Paris
150	150	*
151		- * @return DataValue
	151	+ * @return \SMWDataValue
152	152	*/
153	153	public function getPopulationValue() {
154	154
		@@ -165,7 +165,7 @@ discard block
		block discarded – undo
165	165	*
166	166	* @see https://en.wikipedia.org/wiki/Demographics_of_Paris
167	167	*
168		- * @return DataValue
	168	+ * @return \SMWDataValue
169	169	*/
170	170	public function getPopulationDensityValue() {
171	171

		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	*
66	66	* @since 1.9
67	67	*
68		- * @param $objectName
	68	+ * @param string $objectName
69	69	* @param $objectArguments
70	70	*
71	71	* @return mixed
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	* @since 1.9
110	110	*
111	111	* @param $length
112		- * @param $prefix identify a specific random string during testing
	112	+ * @param string $prefix identify a specific random string during testing
113	113	*
114	114	* @return string
115	115	*/
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	*
123	123	* @since 1.9
124	124	*
125		- * @param $key
	125	+ * @param string $key
126	126	*
127	127	* @return boolean
128	128	*/
		@@ -161,7 +161,7 @@ discard block
		block discarded – undo
161	161	/**
162	162	* @since 1.9
163	163	*
164		- * @param $objectName
	164	+ * @param string $objectName
165	165	*
166	166	* @return MockObjectRepository\|null
167	167	*/

		@@ -38,7 +38,7 @@
		block discarded – undo
38	38	/**
39	39	* @since 2.1
40	40	*
41		- * @param Title $title
	41	+ * @param Title\|null $title
42	42	*
43	43	* @return PageEditor
44	44	*/

		@@ -40,7 +40,7 @@
		block discarded – undo
40	40	*
41	41	* @param Title $title
42	42	*
43		- * @return text
	43	+ * @return string
44	44	*/
45	45	public function getContentAsText( Title $title ) {
46	46

		@@ -26,6 +26,9 @@ discard block
		block discarded – undo
26	26	protected $result = null;
27	27	protected $verbose = false;
28	28
	29	+ /**
	30	+ * @param string $file
	31	+ */
29	32	public function __construct( $file = null ) {
30	33	$this->file = $file;
31	34	}
		@@ -115,7 +118,7 @@ discard block
		block discarded – undo
115	118	}
116	119
117	120	/**
118		- * @return integer
	121	+ * @return double
119	122	*/
120	123	public function getElapsedImportTimeInSeconds() {
121	124	return round( $this->importTime, 7 );

		@@ -156,7 +156,6 @@
		block discarded – undo
156	156	/**
157	157	* @since 2.1
158	158	*
159		- * @param string $file\|null
160	159	*
161	160	* @return JsonFileReader
162	161	*/

		@@ -22,7 +22,6 @@ discard block
		block discarded – undo
22	22	/**
23	23	* @since 2.0
24	24	*
25		- * @param mixed $expected
26	25	* @param ExpData $exportData
27	26	*/
28	27	public function assertThatExportDataContainsProperty( $expectedProperties, ExpData $exportData ) {
		@@ -57,7 +56,6 @@ discard block
		block discarded – undo
57	56	/**
58	57	* @since 2.0
59	58	*
60		- * @param mixed $expected
61	59	* @param ExpResource $selectedElement
62	60	* @param ExpData $exportData
63	61	*/

SemanticMediaWiki / SemanticMediaWiki

Push — master ( 30add5...f043e7 )

Status

Category

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments -1 removed lines patch added patch discarded remove patch

Doc Comments -2 removed lines patch added patch discarded remove patch