Completed
Push — master ( f5d374...685013 )
by mw
47:54 queued 25:05
created
src/DeferredRequestDispatchManager.php 1 patch
Doc Comments   +12 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	/**
86 86
 	 * @since 2.5
87 87
 	 *
88
-	 * @param Title $title
88
+	 * @param Title|null $title
89 89
 	 * @param array $parameters
90 90
 	 */
91 91
 	public function dispatchSearchTableUpdateJobFor( Title $title, $parameters = array() ) {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @since 2.3
97 97
 	 *
98 98
 	 * @param string $type
99
-	 * @param Title $title
99
+	 * @param Title|null $title
100 100
 	 * @param array $parameters
101 101
 	 */
102 102
 	public function dispatchJobRequestFor( $type, Title $title, $parameters = array() ) {
@@ -128,6 +128,9 @@  discard block
 block discarded – undo
128 128
 		return true;
129 129
 	}
130 130
 
131
+	/**
132
+	 * @param string $type
133
+	 */
131 134
 	private function getDispatchableCallbackJobFor( $type ) {
132 135
 
133 136
 		$jobFactory = ApplicationFactory::getInstance()->newJobFactory();
@@ -170,6 +173,9 @@  discard block
 block discarded – undo
170 173
 		return $callback;
171 174
 	}
172 175
 
176
+	/**
177
+	 * @param string $type
178
+	 */
173 179
 	private function doPreliminaryCheckForType( $type, array $parameters ) {
174 180
 
175 181
 		if ( $type !== 'SMW\ParserCachePurgeJob' && $type !== 'SMW\UpdateJob' && $type !== 'SMW\SearchTableUpdateJob' ) {
@@ -194,6 +200,10 @@  discard block
 block discarded – undo
194 200
 		return self::$canConnectToUrl = $this->httpRequest->ping();
195 201
 	}
196 202
 
203
+	/**
204
+	 * @param string $type
205
+	 * @param \Closure $dispatchableCallbackJob
206
+	 */
197 207
 	private function doPostJobWith( $type, $title, $parameters, $dispatchableCallbackJob ) {
198 208
 
199 209
 		$parameters['async-job'] = array(
Please login to merge, or discard this patch.
src/DataValues/ErrorMsgTextValue.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 	/**
42 42
 	 * @see DataValue::loadDataItem
43 43
 	 *
44
-	 * @param SMWDataItem $dataitem
44
+	 * @param DataItem $dataItem
45 45
 	 *
46 46
 	 * @return boolean
47 47
 	 */
Please login to merge, or discard this patch.
src/Message.php 1 patch
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	/**
61 61
 	 * @since 2.4
62 62
 	 *
63
-	 * @param $type
63
+	 * @param string $type
64 64
 	 */
65 65
 	public static function deregisterHandlerFor( $type ) {
66 66
 		unset( self::$messageHandler[$type] );
@@ -96,7 +96,6 @@  discard block
 block discarded – undo
96 96
 	 *
97 97
 	 * @since 2.5
98 98
 	 *
99
-	 * @param string|array $parameters
100 99
 	 * @param integer|null $type
101 100
 	 *
102 101
 	 * @return string
@@ -119,7 +118,7 @@  discard block
 block discarded – undo
119 118
 	 *
120 119
 	 * @since 2.5
121 120
 	 *
122
-	 * @param string $messageId
121
+	 * @param string $message
123 122
 	 *
124 123
 	 * @return boolean
125 124
 	 */
@@ -130,7 +129,6 @@  discard block
 block discarded – undo
130 129
 	/**
131 130
 	 * @since 2.5
132 131
 	 *
133
-	 * @param string $json
134 132
 	 * @param integer|null $type
135 133
 	 * @param integer|null $language
136 134
 	 *
Please login to merge, or discard this patch.
src/ProcessingErrorMsgHandler.php 1 patch
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	/**
114 114
 	 * @since 2.5
115 115
 	 *
116
-	 * @param array|string $errorMsg
116
+	 * @param array|string $error
117 117
 	 * @param DIProperty|null $property
118 118
 	 *
119 119
 	 * @return DIContainer|null
@@ -171,6 +171,11 @@  discard block
 block discarded – undo
171 171
 		return new DIContainer( $containerSemanticData );
172 172
 	}
173 173
 
174
+	/**
175
+	 * @param ContainerSemanticData $containerSemanticData
176
+	 * @param DIProperty|null $property
177
+	 * @param string $error
178
+	 */
174 179
 	private function addToContainerSemanticData( $containerSemanticData, $property, $error ) {
175 180
 
176 181
 		if ( $property !== null ) {
@@ -186,6 +191,9 @@  discard block
 block discarded – undo
186 191
 		);
187 192
 	}
188 193
 
194
+	/**
195
+	 * @param string $hash
196
+	 */
189 197
 	private function newContainerSemanticData( $hash ) {
190 198
 
191 199
 		if ( $this->subject === null ) {
Please login to merge, or discard this patch.
src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	 *
87 87
 	 * @since 2.5
88 88
 	 *
89
-	 * @return boolean
89
+	 * @return null|boolean
90 90
 	 */
91 91
 	public function run() {
92 92
 
@@ -160,6 +160,9 @@  discard block
 block discarded – undo
160 160
 		$this->doRebuildFromRows( $searchTable, $table, $pid, $rows );
161 161
 	}
162 162
 
163
+	/**
164
+	 * @param SearchTable $searchTable
165
+	 */
163 166
 	private function doRebuildFromRows( $searchTable, $table, $pid, $rows ) {
164 167
 
165 168
 		$i = 0;
@@ -203,6 +206,9 @@  discard block
 block discarded – undo
203 206
 		$this->reportMessage( "\n" );
204 207
 	}
205 208
 
209
+	/**
210
+	 * @param string $message
211
+	 */
206 212
 	private function reportMessage( $message, $verbose = true ) {
207 213
 		if ( $verbose ) {
208 214
 			$this->messageReporter->reportMessage( $message );
Please login to merge, or discard this patch.
includes/datavalues/SMW_DV_Time.php 1 patch
Doc Comments   +16 added lines, -7 removed lines patch added patch discarded remove patch
@@ -186,14 +186,17 @@  discard block
 block discarded – undo
186 186
 	 * The function sets the provided call-by-ref values to the respective
187 187
 	 * values. If errors are encountered, they are added to the objects
188 188
 	 * error list and false is returned. Otherwise, true is returned.
189
-	 * @param $string string input time representation, e.g. "12 May 2007 13:45:23-3:30"
189
+	 * @param string $string string input time representation, e.g. "12 May 2007 13:45:23-3:30"
190 190
 	 * @param $datecomponents array of strings that might belong to the specification of a date
191 191
 	 * @param $calendarmodesl string if model was set in input, otherwise false
192
-	 * @param $era string '+' or '-' if provided, otherwise false
193
-	 * @param $hours integer set to a value between 0 and 24
194
-	 * @param $minutes integer set to a value between 0 and 59
195
-	 * @param $seconds integer set to a value between 0 and 59, or false if not given
196
-	 * @param $timeoffset double set to a value for time offset (e.g. 3.5), or false if not given
192
+	 * @param boolean $era string '+' or '-' if provided, otherwise false
193
+	 * @param boolean $hours integer set to a value between 0 and 24
194
+	 * @param boolean $minutes integer set to a value between 0 and 59
195
+	 * @param boolean $seconds integer set to a value between 0 and 59, or false if not given
196
+	 * @param boolean $timeoffset double set to a value for time offset (e.g. 3.5), or false if not given
197
+	 * @param boolean $calendarmodel
198
+	 * @param boolean $microseconds
199
+	 * @param boolean $timezone
197 200
 	 * @return boolean stating if the parsing succeeded
198 201
 	 * @todo This method in principle allows date parsing to be internationalized further. Should be done.
199 202
 	 */
@@ -409,7 +412,7 @@  discard block
 block discarded – undo
409 412
 	 * messages are added to the objects list of errors, and false is
410 413
 	 * returned. Otherwise, true is returned.
411 414
 	 * @param $datecomponents array of strings that might belong to the specification of a date
412
-	 * @param $date array set to result
415
+	 * @param boolean $date array set to result
413 416
 	 * @return boolean stating if successful
414 417
 	 */
415 418
 	protected function interpretDateComponents( $datecomponents, &$date ) {
@@ -807,10 +810,16 @@  discard block
 block discarded – undo
807 810
 		}
808 811
 	}
809 812
 
813
+	/**
814
+	 * @param string $value
815
+	 */
810 816
 	private function isInterpretableAsYearOnly( $value ) {
811 817
 		return strpos( $value, ' ' ) === false && is_numeric( strval( $value ) ) && ( strval( $value ) < 0 || strlen( $value ) < 6 );
812 818
 	}
813 819
 
820
+	/**
821
+	 * @param string $value
822
+	 */
814 823
 	private function isInterpretableAsTimestamp( $value ) {
815 824
 		// 1200-11-02T12:03:25 or 20120320055913
816 825
 		return ( ( strlen( $value ) > 4 && substr( $value, 10, 1 ) === 'T' ) || strlen( $value ) == 14 ) && wfTimestamp( TS_MW, $value ) !== false;
Please login to merge, or discard this patch.
includes/specials/SMW_SpecialAsk.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -770,6 +770,9 @@  discard block
 block discarded – undo
770 770
 		return '(' . $downloadLinks . ')';
771 771
 	}
772 772
 
773
+	/**
774
+	 * @param string $html
775
+	 */
773 776
 	private function doFinalModificationsOnBorrowedOutput( &$html, &$searchInfoText ) {
774 777
 
775 778
 		if ( !$this->getRequest()->getCheck( 'bTitle' ) ) {
@@ -790,6 +793,7 @@  discard block
 block discarded – undo
790 793
 
791 794
 	/**
792 795
 	 * FIXME MW 1.25
796
+	 * @param string $key
793 797
 	 */
794 798
 	private function addExternalHelpLinkFor( $key ) {
795 799
 
Please login to merge, or discard this patch.
src/Exporter/ResourceBuilders/PropertyValueResourceBuilder.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -94,6 +94,9 @@  discard block
 block discarded – undo
94 94
 		}
95 95
 	}
96 96
 
97
+	/**
98
+	 * @param DIProperty $property
99
+	 */
97 100
 	protected function getResourceElementForProperty( $property ) {
98 101
 
99 102
 		$key = 'resource:builder:' . $property->getKey();
@@ -112,6 +115,9 @@  discard block
 block discarded – undo
112 115
 		return $resourceElement;
113 116
 	}
114 117
 
118
+	/**
119
+	 * @param DIProperty $property
120
+	 */
115 121
 	protected function getResourceElementHelperForProperty( $property ) {
116 122
 
117 123
 		$key = 'resource:builder:aux:' . $property->getKey();
Please login to merge, or discard this patch.
src/DataValues/ExternalIdentifierValue.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,6 @@  discard block
 block discarded – undo
40 40
 	/**
41 41
 	 * @see DataValue::getShortWikiText
42 42
 	 *
43
-	 * @param string $value
44 43
 	 */
45 44
 	public function getShortWikiText( $linker = null ) {
46 45
 
@@ -137,6 +136,9 @@  discard block
 block discarded – undo
137 136
 		return $dataValue->getDataItem();
138 137
 	}
139 138
 
139
+	/**
140
+	 * @return boolean
141
+	 */
140 142
 	private function getExternalFormattedUri( $value ) {
141 143
 
142 144
 		if ( $this->externalFormattedUri !== null ) {
Please login to merge, or discard this patch.