SemanticMediaWiki / SemanticMediaWiki

includes/query/SMW_QueryProcessor.php

Doc Comments +4 added lines, -4 removed lines

@@ -168,7 +168,6 @@ 
 	 * @since 1.7
 	 *
 	 * @param array $sortParam
-	 * @param array $orders
 	 * @param string $defaultSort
 	 *
 	 * @return array ( keys => array(), errors => array() )
@@ -363,6 +362,7 @@ 
 	 * @param integer $outputMode SMW_OUTPUT_WIKI, SMW_OUTPUT_HTML, ...
 	 * @param integer $context INLINE_QUERY, SPECIAL_PAGE, CONCEPT_DESC
 	 * @param boolean $showMode process like #show parser function?
+	 * @param DIWikiPage $contextPage
 	 * @return array( SMWQuery, array of IParam )
 	 */
 	static public function getQueryAndParamsFromFunctionParams( array $rawParams, $outputMode, $context, $showMode, $contextPage = null ) {
@@ -415,9 +415,9 @@ 
 	 * printout requests for the query results.
 	 *
 	 * @param string $queryString
-	 * @param array $params These need to be the result of a list fed to getProcessedParams
+	 * @param Param[] $params These need to be the result of a list fed to getProcessedParams
 	 * @param $extraPrintouts
-	 * @param $outputMode
+	 * @param integer $outputMode
 	 * @param $context
 	 *
 	 * @return string
@@ -529,7 +529,7 @@ 
 	 *
 	 * @since 1.6.2, return element type changed in 1.8
 	 *
-	 * @return IParamDefinition[]
+	 * @return ParamProcessor\IParamDefinition[]
 	 */
 	public static function getParameters() {
 		$params = array();

src/IntlNumberFormatter.php

Doc Comments +10 added lines, -1 removed lines

@@ -100,6 +100,7 @@ 
 	 *
 	 * @return string $key
 	 * @param mxied $value
+	 * @param string $key
 	 */
 	public function setOption( $key, $value ) {
 		$this->options->set( $key, $value );
@@ -161,7 +162,7 @@ 
 	 * to format a number that was not hand-formatted by a user.
 	 *
 	 * @param mixed $value input number
-	 * @param integer|false $precision optional positive integer, controls how many digits after
+	 * @param boolean $precision optional positive integer, controls how many digits after
 	 * the decimal point are shown
 	 *
 	 * @since 2.1
@@ -277,6 +278,10 @@ 
 		return round( $value, $this->defaultPrecision );
 	}
 
+	/**
+	 * @param string $decimal
+	 * @param string $thousand
+	 */
 	private function doFormatWithPrecision( $value, $precision = false, $decimal, $thousand ) {
 		// Format to some level of precision; number_format does rounding and
 		// locale formatting, x and y are used temporarily since number_format
@@ -321,6 +326,10 @@ 
 		return $language;
 	}
 
+	/**
+	 * @param string $custom
+	 * @param string $standard
+	 */
 	private function getPreferredLocalizedSeparator( $custom, $standard, $language ) {
 
 		if ( $this->options->has( $custom ) && ( $separator = $this->options->get( $custom ) ) !== false ) {

tests/phpunit/Unit/IntlNumberFormatterTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SMW\Tests;
 
-use Language;
 use SMW\NumberFormatter;
 
 /**

includes/datavalues/SMW_DV_Number.php

Doc Comments +3 added lines, -3 removed lines

@@ -92,7 +92,7 @@ 
 	 * Parse a string of the form "number unit" where unit is optional. The
 	 * results are stored in the $number and $unit parameters. Returns an
 	 * error code.
-	 * @param $value string to parse
+	 * @param string $value string to parse
 	 * @param $number call-by-ref parameter that will be set to the numerical value
 	 * @param $unit call-by-ref parameter that will be set to the "unit" string (after the number)
 	 * @return integer 0 (no errors), 1 (no number found at all), 2 (number
@@ -226,7 +226,7 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @return float
+	 * @return string
 	 */
 	public function getLocalizedFormattedNumber( $value ) {
 		return $this->getNumberFormatter()->format( $value, $this->getPreferredDisplayPrecision() );
@@ -235,7 +235,7 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @return float
+	 * @return string
 	 */
 	public function getNormalizedFormattedNumber( $value ) {
 		return $this->getNumberFormatter()->format( $value, $this->getPreferredDisplayPrecision(), IntlNumberFormatter::VALUE_FORMAT );

includes/datavalues/SMW_DV_String.php

Doc Comments +4 added lines, -1 removed lines

@@ -34,7 +34,7 @@ 
 	/**
 	 * @see DataValue::loadDataItem
 	 *
-	 * @param SMWDataItem $dataitem
+	 * @param SMWDataItem $dataItem
 	 *
 	 * @return boolean
 	 */
@@ -96,6 +96,9 @@ 
 		return $this->getDataValueFormatter()->format( DataValueFormatter::VALUE );
 	}
 
+	/**
+	 * @param integer $length
+	 */
 	public function getWikiValueForLengthOf( $length ) {
 
 		if ( mb_strlen( $this->getWikiValue() ) > $length ) {

includes/datavalues/SMW_DV_WikiPage.php

Doc Comments +6 added lines

@@ -72,6 +72,9 @@ 
 	 */
 	protected $linkAttributes = array();
 
+	/**
+	 * @param string $typeid
+	 */
 	public function __construct( $typeid ) {
 		parent::__construct( $typeid );
 		switch ( $typeid ) {
@@ -630,6 +633,9 @@ 
 		return $dvWikiPage;
 	}
 
+	/**
+	 * @param DataItem $subject
+	 */
 	private function findDisplayTitleFor( $subject ) {
 
 		$displayTitle = '';

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use SMW\DataValueFactory;
 use SMW\DIProperty;
 use SMW\Highlighter;
-use SMW\Message;
 
 /**
  * Objects of this class represent properties in SMW.

src/DataValues/InfoLinksProvider.php

Doc Comments +1 added lines, -2 removed lines

@@ -83,7 +83,6 @@ 
 	 *
 	 * @since 2.4
 	 *
-	 * @param Infolink $link
 	 */
 	public function addInfolink( Infolink $infoLink ) {
 		$this->infoLinks[] = $infoLink;
@@ -92,7 +91,7 @@ 
 	/**
 	 * @since 2.4
 	 *
-	 * @param array|false $serviceLinkParameters
+	 * @param boolean $serviceLinkParameters
 	 */
 	public function setServiceLinkParameters( $serviceLinkParameters ) {
 		$this->serviceLinkParameters = $serviceLinkParameters;

includes/storage/SQLStore/SMW_SQLStore3.php

Doc Comments +9 added lines, -6 removed lines

@@ -250,6 +250,9 @@ 
 		return $this->reader;
 	}
 
+	/**
+	 * @return SemanticData
+	 */
 	public function getSemanticData( DIWikiPage $subject, $filter = false ) {
 
 		$result = $this->cachedValueLookupStore->getSemanticData(
@@ -261,7 +264,7 @@ 
 	}
 
 	/**
-	 * @param mixed $subject
+	 * @param DIWikiPage $subject
 	 * @param DIProperty $property
 	 * @param null $requestOptions
 	 *
@@ -407,7 +410,7 @@ 
 	/**
 	 * @param RequestOptions|null $requestOptions
 	 *
-	 * @return CachedListLookup
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
 	 */
 	public function getPropertiesSpecial( $requestOptions = null ) {
 		return $this->factory->newPropertyUsageCachedListLookup( $requestOptions );
@@ -416,7 +419,7 @@ 
 	/**
 	 * @param RequestOptions|null $requestOptions
 	 *
-	 * @return CachedListLookup
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
 	 */
 	public function getUnusedPropertiesSpecial( $requestOptions = null ) {
 		return $this->factory->newUnusedPropertyCachedListLookup( $requestOptions );
@@ -425,7 +428,7 @@ 
 	/**
 	 * @param RequestOptions|null $requestOptions
 	 *
-	 * @return CachedListLookup
+	 * @return SMW\SQLStore\Lookup\CachedListLookup
 	 */
 	public function getWantedPropertiesSpecial( $requestOptions = null ) {
 		return $this->factory->newUndeclaredPropertyCachedListLookup( $requestOptions );
@@ -473,7 +476,7 @@ 
 	 *
 	 * @since 1.8
 	 * @param Title $concept
-	 * @return array of error strings (empty if no errors occurred)
+	 * @return string[] of error strings (empty if no errors occurred)
 	 */
 	public function refreshConceptCache( Title $concept ) {
 		return $this->factory->newMasterConceptCache()->refreshConceptCache( $concept );
@@ -515,7 +518,7 @@ 
 	 * @since 1.8
 	 *
 	 * @param SMWRequestOptions|null $requestOptions
-	 * @param string $valuecol
+	 * @param string $valueCol
 	 *
 	 * @return array
 	 */

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use SMW\DataTypeRegistry;
 use SMW\DIConcept;
 use SMW\DIProperty;
 use SMW\DIWikiPage;

src/SQLStore/QueryDependency/QueryDependencyLinksStore.php

Doc Comments +3 added lines

@@ -371,6 +371,9 @@
 		return $id;
 	}
 
+	/**
+	 * @param DIWikiPage $subject
+	 */
 	private function canSuppressUpdateOnSkewFactorFor( $sid, $subject ) {
 
 		if ( $sid < 1 ) {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SMW\ApplicationFactory;
 use SMW\DIProperty;
 use SMW\DIWikiPage;
-use SMW\EventHandler;
 use SMW\SQLStore\CompositePropertyTableDiffIterator;
 use SMW\Store;
 use SMW\RequestOptions;