+global\SMWSQLStore3Readers::fetchSemanticData()

Complexity

Conditions	34
Paths	> 20000

Size

Total Lines	133
Code Lines	77

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	69
CRAP Score	34.0259

Importance

Changes

0

<?php
	private function fetchSemanticData( $id, SMWDataItem $object = null, TableDefinition $propTable, $isSubject = true, SMWRequestOptions $requestOptions = null ) {
		// stop if there is not enough data:
		// properties always need to be given as object,
		// subjects at least if !$proptable->idsubject
		if ( ( $id == 0 ) ||
			( is_null( $object ) && ( !$isSubject || !$propTable->usesIdSubject() ) ) ) {
				return array();
		}

		$result = array();
		$db = $this->store->getConnection();

		$diHandler = $this->store->getDataItemHandlerForDIType( $propTable->getDiType() );

		// ***  First build $from, $select, and $where for the DB query  ***//
		$from = $db->tableName( $propTable->getName() ); // always use actual table

		$select = '';
		$where  = '';

		if ( $isSubject ) { // restrict subject, select property
			$where .= ( $propTable->usesIdSubject() ) ? 's_id=' . $db->addQuotes( $id ) :
					  's_title=' . $db->addQuotes( $object->getDBkey() ) .

It seems like you code against a specific sub-type and not the parent class SMWDataItem as the method getDBkey() does only exist in the following sub-classes of SMWDataItem: SMWDIWikiPage, SMW\DIWikiPage. Maybe you want to instanceof check for one of these explicitly?

					  ' AND s_namespace=' . $db->addQuotes( $object->getNamespace() );

It seems like you code against a specific sub-type and not the parent class SMWDataItem as the method getNamespace() does only exist in the following sub-classes of SMWDataItem: SMWDIWikiPage, SMW\DIWikiPage. Maybe you want to instanceof check for one of these explicitly?

			if ( !$propTable->isFixedPropertyTable() ) { // select property name
				$from .= ' INNER JOIN ' . $db->tableName( SMWSql3SmwIds::TABLE_NAME ) . ' AS p ON p_id=p.smw_id';
				$select .= 'p.smw_title as prop';
			} // else: fixed property, no select needed
		} elseif ( !$propTable->isFixedPropertyTable() ) { // restrict property only
			$where .= 'p_id=' . $db->addQuotes( $id );
		}

		$valuecount = 0;
		// Don't use DISTINCT for value of one subject:
		$usedistinct = !$isSubject;

		$valueField = $diHandler->getIndexField();
		$labelField = $diHandler->getLabelField();
		$fields = $diHandler->getFetchFields();
		foreach ( $fields as $fieldname => $fieldType ) { // select object column(s)
			if ( $fieldType === FieldType::FIELD_ID ) { // get data from ID table
				$from .= ' INNER JOIN ' . $db->tableName( SMWSql3SmwIds::TABLE_NAME ) . " AS o$valuecount ON $fieldname=o$valuecount.smw_id";
				$select .= ( ( $select !== '' ) ? ',' : '' ) .
					"$fieldname AS id$valuecount" .
					",o$valuecount.smw_title AS v$valuecount" .
					",o$valuecount.smw_namespace AS v" . ( $valuecount + 1 ) .
					",o$valuecount.smw_iw AS v" . ( $valuecount + 2 ) .
					",o$valuecount.smw_sortkey AS v" . ( $valuecount + 3 ) .
					",o$valuecount.smw_subobject AS v" . ( $valuecount + 4 );

				if ( $valueField == $fieldname ) {
					$valueField = "o$valuecount.smw_sortkey";
				}
				if ( $labelField == $fieldname ) {
					$labelField = "o$valuecount.smw_sortkey";
				}

				$valuecount += 4;
			} else {
				$select .= ( ( $select !== '' ) ? ',' : '' ) .
					"$fieldname AS v$valuecount";
			}

			$valuecount += 1;
		}

		// Postgres
		// Function: SMWSQLStore3Readers::fetchSemanticData
		// Error: 42P10 ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list
		if ( strpos( $select, $valueField ) === false ) {
			$select .= ", $valueField AS v" . ( $valuecount + 1 );
		}

		if ( !$isSubject ) { // Apply sorting/string matching; only with given property
			$where .= $this->store->getSQLConditions( $requestOptions, $valueField, $labelField, $where !== '' );
		} else {
			$valueField = '';
		}

		// ***  Now execute the query and read the results  ***//
		$res = $db->select( $from, $select, $where, __METHOD__,
				( $usedistinct ?
					$this->store->getSQLOptions( $requestOptions, $valueField ) + array( 'DISTINCT' ) :
					$this->store->getSQLOptions( $requestOptions, $valueField )
				) );

		foreach ( $res as $row ) {

			$valueHash = '';

			if ( $isSubject ) { // use joined or predefined property name
				$propertykey = $propTable->isFixedPropertyTable() ? $propTable->getFixedProperty() : $row->prop;
				$valueHash = $propertykey;
			}

			// Use enclosing array only for results with many values:
			if ( $valuecount > 1 ) {
				$valuekeys = array();
				for ( $i = 0; $i < $valuecount; $i += 1 ) { // read the value fields from the current row
					$fieldname = "v$i";
					$valuekeys[] = $row->$fieldname;
				}
			} else {
				$valuekeys = $row->v0;
			}

			// #Issue 615
			// If the iw field contains a redirect marker then remove it
			if ( isset( $valuekeys[2] ) && ( $valuekeys[2] === SMW_SQL3_SMWREDIIW || $valuekeys[2] === SMW_SQL3_SMWDELETEIW ) ) {
				$valuekeys[2] = '';
			}

			// The valueHash prevents from inserting duplicate entries of the same content
			$valueHash = $valuecount > 1 ? md5( $valueHash . implode( '#', $valuekeys ) ) : md5( $valueHash . $valuekeys );

			// Filter out any accidentally retrieved internal things (interwiki starts with ":"):
			if ( $valuecount < 3 ||
				implode( '', $fields ) !== FieldType::FIELD_ID ||
				$valuekeys[2] === '' ||
				$valuekeys[2]{0} != ':' ) {

				if ( isset( $result[$valueHash] ) ) {
					$this->factory->getLogger()->info( __METHOD__ . " Duplicate entry for {$propertykey} with " . ( is_array( $valuekeys ) ? implode( ',', $valuekeys ) : $valuekeys ) . "\n" );

The variable $propertykey does not seem to be defined for all execution paths leading up to this point.

				}

				$result[$valueHash] = $isSubject ? array( $propertykey, $valuekeys ) : $valuekeys;
			}
		}

		$db->freeResult( $res );

		return $result;
	}