+global\SMWAskPage::makeHTMLResult()

Complexity

Conditions	31
Paths	> 20000

Size

Total Lines	188
Code Lines	108

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	72
CRAP Score	48.9446

Importance

Changes

0

<?php
	protected function makeHTMLResult() {
		global $wgOut;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		// TODO: hold into account $smwgAutocompleteInSpecialAsk

		$result = '';
		$res = null;

		// build parameter strings for URLs, based on current settings
		$urlArgs['q'] = $this->m_querystring;

$urlArgs was never initialized. Although not strictly required by PHP, it is generally a good practice to add $urlArgs = array(); before regardless.

		$tmp_parray = array();
		foreach ( $this->m_params as $key => $value ) {
			if ( !in_array( $key, array( 'sort', 'order', 'limit', 'offset', 'title' ) ) ) {
				$tmp_parray[$key] = $value;
			}
		}

		$urlArgs['p'] = SMWInfolink::encodeParameters( $tmp_parray );
		$printoutstring = '';
		$duration = 0;
		$navigation = '';
		$queryobj = null;

		/**
		 * @var PrintRequest $printout
		 */
		foreach ( $this->m_printouts as $printout ) {
			$printoutstring .= $printout->getSerialisation( true ) . "\n";
		}

		if ( $printoutstring !== '' ) {
			$urlArgs['po'] = $printoutstring;
		}

		if ( array_key_exists( 'sort', $this->m_params ) ) {
			$urlArgs['sort'] = $this->m_params['sort'];
		}

		if ( array_key_exists( 'order', $this->m_params ) ) {
			$urlArgs['order'] = $this->m_params['order'];
		}

		if ( $this->getRequest()->getCheck( 'bTitle' ) ) {
			$urlArgs['bTitle'] = $this->getRequest()->getVal( 'bTitle' );
			$urlArgs['bMsg'] = $this->getRequest()->getVal( 'bMsg' );
		}

		if ( $this->m_querystring !== '' ) {
			// FIXME: this is a hack
			SMWQueryProcessor::addThisPrintout( $this->m_printouts, $this->m_params );
			$params = SMWQueryProcessor::getProcessedParams( $this->m_params, $this->m_printouts );
			$this->m_params['format'] = $params['format']->getValue();

			$this->params = $params;

			$queryobj = SMWQueryProcessor::createQuery(
				$this->m_querystring,
				$params,
				SMWQueryProcessor::SPECIAL_PAGE,
				$this->m_params['format'],
				$this->m_printouts
			);

			/**
			 * @var SMWQueryResult $res
			 */

			$queryobj->setOption( SMWQuery::PROC_CONTEXT, 'SpecialAsk' );
			$this->queryLinker = QueryLinker::get( $queryobj, $this->m_params );

			// Determine query results
			$duration = microtime( true );
			$res = $this->getStoreFromParams( $params )->getQueryResult( $queryobj );
			$duration = number_format( (microtime( true ) - $duration), 4, '.', '' );

			// Try to be smart for rss/ical if no description/title is given and we have a concept query:
			if ( $this->m_params['format'] == 'rss' ) {
				$desckey = 'rssdescription';
				$titlekey = 'rsstitle';
			} elseif ( $this->m_params['format'] == 'icalendar' ) {
				$desckey = 'icalendardescription';
				$titlekey = 'icalendartitle';
			} else { $desckey = false;
			}

			if ( ( $desckey ) && ( $queryobj->getDescription() instanceof SMWConceptDescription ) &&

The expression $desckey of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

The class SMWConceptDescription does not exist. Did you forget a USE statement, or did you not list all dependencies?

			     ( !isset( $this->m_params[$desckey] ) || !isset( $this->m_params[$titlekey] ) ) ) {
				$concept = $queryobj->getDescription()->getConcept();

				if ( !isset( $this->m_params[$titlekey] ) ) {
					$this->m_params[$titlekey] = $concept->getText();

The variable $titlekey does not seem to be defined for all execution paths leading up to this point.

				}

				if ( !isset( $this->m_params[$desckey] ) ) {
					// / @bug The current SMWStore will never return SMWConceptValue (an SMWDataValue) here; it might return SMWDIConcept (an SMWDataItem)
					$dv = end( \SMW\StoreFactory::getStore()->getPropertyValues( SMWWikiPageValue::makePageFromTitle( $concept ), new SMW\DIProperty( '_CONC' ) ) );

\SMW\StoreFactory::getStore()->getPropertyValues(\SMWWikiPageValue::makePageFromTitle($concept), new \SMW\DIProperty('_CONC')) cannot be passed to end() as the parameter $array expects a reference.

The method SMWWikiPageValue::makePageFromTitle() has been deprecated with message: This method will vanish before SMW 1.7. If you really need this, simply copy its code.

					if ( $dv instanceof SMWConceptValue ) {
						$this->m_params[$desckey] = $dv->getDocu();
					}
				}
			}

			$printer = SMWQueryProcessor::getResultPrinter( $this->m_params['format'], SMWQueryProcessor::SPECIAL_PAGE );
			$printer->setShowErrors( false );

			global $wgRequest;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

			$hidequery = $wgRequest->getVal( 'eq' ) == 'no';
			$debug = '';

			// Allow to generate a debug output
			if ( $this->getRequest()->getVal( 'debug' ) ) {

				$queryobj = SMWQueryProcessor::createQuery(
					$this->m_querystring,
					$params,
					SMWQueryProcessor::SPECIAL_PAGE,
					'debug',
					$this->m_printouts
				);

				$debug = $this->getStoreFromParams( $params )->getQueryResult( $queryobj );
			}

			if ( !$printer->isExportFormat() ) {
				if ( $res->getCount() > 0 ) {
					if ( $this->m_editquery ) {
						$urlArgs['eq'] = 'yes';
					}
					elseif ( $hidequery ) {
						$urlArgs['eq'] = 'no';
					}

					$navigation = $this->getNavigationBar( $res, $urlArgs );
					$query_result = $printer->getResult( $res, $params, SMW_OUTPUT_HTML );

					if ( is_array( $query_result ) ) {
						$result .= $query_result[0];
					} else {
						$result .= $query_result;
					}

					$result .= $debug;
				} else {
					$result = $this->errorFormWidget->createNoResultFormElement();
					$result .= $debug;
				}
			}
		}

		// FileExport will override the header and cause issues during the unit
		// test when fetching the output stream therefore use the plain output
		if ( defined( 'MW_PHPUNIT_TEST' ) && isset( $printer ) && $printer->isExportFormat() ) {
			$result = $printer->getResult( $res, $params, SMW_OUTPUT_FILE );

The variable $params does not seem to be defined for all execution paths leading up to this point.

			$printer = null;
		}

		if ( isset( $printer ) && $printer->isExportFormat() ) {
			$wgOut->disable();

			/**
			 * @var SMWIExportPrinter $printer
			 */
			$printer->outputAsFile( $res, $params );
		} else {
			if ( $this->m_querystring ) {
				$this->getOutput()->setHTMLtitle( $this->m_querystring );
			} else {
				$this->getOutput()->setHTMLtitle( wfMessage( 'ask' )->text() );
			}

			$urlArgs['offset'] = $this->m_params['offset'];
			$urlArgs['limit'] = $this->m_params['limit'];

			$isFromCache = $res !== null ? $res->isFromCache() : false;

			$result = $this->getInputForm(
				$printoutstring,
				wfArrayToCGI( $urlArgs ),
				$navigation,
				$duration,
				$isFromCache
			) . $this->errorFormWidget->getFormattedQueryErrorElement( $queryobj ) . $result;

			$this->getOutput()->addHTML( $result );
		}
	}