Issues in SM_GeoCoordsValueDescription.php (master) - Issues in master - SemanticMediaWiki/SemanticMaps - Measure and Improve Code Quality continuously with Scrutinizer

Issues (51)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SM_GeoCoordsValueDescription.php (1 issue)

Labels

Deprecated Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use SMW\DataValueFactory;

/**
 * Description of one data value of type Geographical Coordinates.
 * 
 * @since 0.6
 * @ingroup SemanticMaps
 * 
 * @author Jeroen De Dauw
 */
class SMGeoCoordsValueDescription extends SMWValueDescription {

	/**
	 * @see SMWDescription::getQueryString
	 * 
	 * @since 0.6
	 * 
	 * @param boolean $asValue
	 * @return string
	 */
	public function getQueryString( $asValue = false ) {
		if ( $this->getDataItem() !== null ) {
			$queryString = DataValueFactory::newDataItemValue( $this->getDataItem(), $this->getPropertyCompat() )->getWikiValue();

			return $asValue ? $queryString : "[[$queryString]]";
		} else {
			return $asValue ? '+' : '';
		}
	}

	private function getPropertyCompat() {
		return method_exists( $this, 'getProperty' ) ? $this->getProperty() : $this->m_property;
	}
	
	/**
	 * @see SMWDescription::getSQLCondition
	 *
	 * FIXME: store specific code should be in the store component
	 *
	 * @since 0.6
	 * 
	 * @param string $tableName
	 * @param array $fieldNames
	 * @param DatabaseBase $dbs
	 * 
	 * @return boolean
	 */
	public function getSQLCondition( $tableName, array $fieldNames, DatabaseBase $dbs ) {
		$dataItem = $this->getDataItem();
		
		// Only execute the query when the description's type is geographical coordinates,
		// the description is valid, and the near comparator is used.
		if ( $dataItem instanceof SMWDIGeoCoord ) {
			switch ( $this->getComparator() ) {
				case SMW_CMP_EQ: $comparator = '='; break;
				case SMW_CMP_LEQ: $comparator = '<='; break;
				case SMW_CMP_GEQ: $comparator = '>='; break;
				case SMW_CMP_NEQ: $comparator = '!='; break;
				default: return false;
			}

			$lat = $dbs->addQuotes( $dataItem->getLatitude() );
			$lon = $dbs->addQuotes( $dataItem->getLongitude() );

			$conditions = [];

			$conditions[] = "{$tableName}.$fieldNames[1] $comparator $lat";
			$conditions[] = "{$tableName}.$fieldNames[2] $comparator $lon";

			return implode( ' AND ', $conditions );
		}

		return false;
	}
	
}

1			<?php
2
3			use SMW\DataValueFactory;
4
5			/**
6			* Description of one data value of type Geographical Coordinates.
7			*
8			* @since 0.6
9			* @ingroup SemanticMaps
10			*
11			* @author Jeroen De Dauw
12			*/
13			class SMGeoCoordsValueDescription extends SMWValueDescription {
14
15			/**
16			* @see SMWDescription::getQueryString
17			*
18			* @since 0.6
19			*
20			* @param boolean $asValue
21			* @return string
22			*/
23			public function getQueryString( $asValue = false ) {
24			if ( $this->getDataItem() !== null ) {
25			$queryString = DataValueFactory::newDataItemValue( $this->getDataItem(), $this->getPropertyCompat() )->getWikiValue();
			0 ignored issues – show Deprecated Code introduced 2016-08-01 06:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `SMW\DataValueFactory::newDataItemValue()` has been deprecated with message: since 2.4, use DataValueFactory::newDataValueByItem This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
26			return $asValue ? $queryString : "[[$queryString]]";
27			} else {
28			return $asValue ? '+' : '';
29			}
30			}
31
32			private function getPropertyCompat() {
33			return method_exists( $this, 'getProperty' ) ? $this->getProperty() : $this->m_property;
34			}
35
36			/**
37			* @see SMWDescription::getSQLCondition
38			*
39			* FIXME: store specific code should be in the store component
40			*
41			* @since 0.6
42			*
43			* @param string $tableName
44			* @param array $fieldNames
45			* @param DatabaseBase $dbs
46			*
47			* @return boolean
48			*/
49			public function getSQLCondition( $tableName, array $fieldNames, DatabaseBase $dbs ) {
50			$dataItem = $this->getDataItem();
51
52			// Only execute the query when the description's type is geographical coordinates,
53			// the description is valid, and the near comparator is used.
54			if ( $dataItem instanceof SMWDIGeoCoord ) {
55			switch ( $this->getComparator() ) {
56			case SMW_CMP_EQ: $comparator = '='; break;
57			case SMW_CMP_LEQ: $comparator = '<='; break;
58			case SMW_CMP_GEQ: $comparator = '>='; break;
59			case SMW_CMP_NEQ: $comparator = '!='; break;
60			default: return false;
61			}
62
63			$lat = $dbs->addQuotes( $dataItem->getLatitude() );
64			$lon = $dbs->addQuotes( $dataItem->getLongitude() );
65
66			$conditions = [];
67
68			$conditions[] = "{$tableName}.$fieldNames[1] $comparator $lat";
69			$conditions[] = "{$tableName}.$fieldNames[2] $comparator $lon";
70
71			return implode( ' AND ', $conditions );
72			}
73
74			return false;
75			}
76
77			}

SemanticMediaWiki / SemanticMaps

Issues (51)

Security Analysis no request data

src/SM_GeoCoordsValueDescription.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like