Hooks - Code Metrics - Inspection of "Pull request from last edits, gesinn and biocore" - SemanticMediaWiki/SemanticFormsSelect - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#71)

by Toni Hermoso

created 2018-09-20 09:46 UTC

Hooks A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	0
dl	0
loc	29
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	onSemanticFormsSelectSetup()	0	12	3
A	onRegistration()	0	6	2

<?php

namespace SFS;

/**
 * @license GNU GPL v2+
 * @since 3.0
 * @author: Alexander Gesinn
 */
class Hooks {
	/**
	 * Register Page Forms Input Type
	 *
	 * This is attached to the MediaWiki 'ParserFirstCallInit' hook.
	 *
	 * @param $parser Parser
	 * @return bool
	 */
	public static function onSemanticFormsSelectSetup ( & $parser ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( !defined( 'PF_VERSION' ) ) {
			die( '<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.' );

		}

		if ( isset( $GLOBALS['wgPageFormsFormPrinter'] ) ) {
			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( \SFS\SemanticFormsSelectInput::class );
		}

		return true;
	}
	
	public static function onRegistration() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( isset( $GLOBALS['wgAPIModules'] ) ) {
			$GLOBALS['wgAPIModules']['sformsselect'] = \SFS\ApiSemanticFormsSelect::class;
		}
	}
}


1			<?php
2
3			namespace SFS;
4
5			/**
6			* @license GNU GPL v2+
7			* @since 3.0
8			* @author: Alexander Gesinn
9			*/
10			class Hooks {
11			/**
12			* Register Page Forms Input Type
13			*
14			* This is attached to the MediaWiki 'ParserFirstCallInit' hook.
15			*
16			* @param $parser Parser
17			* @return bool
18			*/
19			public static function onSemanticFormsSelectSetup ( & $parser ) {
			0 ignored issues – show Unused Code introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report The parameter `$parser` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report `onSemanticFormsSelectSetup` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20
21			if ( !defined( 'PF_VERSION' ) ) {
22			die( '<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.' );
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report The method `onSemanticFormsSelectSetup()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
23			}
24
25			if ( isset( $GLOBALS['wgPageFormsFormPrinter'] ) ) {
26			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( \SFS\SemanticFormsSelectInput::class );
27			}
28
29			return true;
30			}
31
32			public static function onRegistration() {
			0 ignored issues – show Coding Style introduced 2018-09-20 10:08 UTC by Report Bug Copy Issue Report `onRegistration` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33
34			if ( isset( $GLOBALS['wgAPIModules'] ) ) {
35			$GLOBALS['wgAPIModules']['sformsselect'] = \SFS\ApiSemanticFormsSelect::class;
36			}
37			}
38			}
39

SemanticMediaWiki / SemanticFormsSelect

Pull Request — master (#71)

Hooks A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like