SemanticFormsSelectHooks::onExtensionFunction() - Code Metrics - Inspection of "Add extension.json and a posible fix for composer" - SemanticMediaWiki/SemanticFormsSelect - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by None

created 2016-01-26 18:35 UTC

SemanticFormsSelectHooks::onExtensionFunction() A

↳ Parent: SemanticFormsSelectHooks

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	7
rs	9.4285
cc	2
eloc	4
nc	2
nop	0

<?php

class SemanticFormsSelectHooks {
namespace YourVendor;

class YourClass { }

	public static function onCallback() {
		// Do not initialize more than once.
		if ( defined( 'SFS_VERSION' ) ) {
			return 1;
		}

		define( 'SFS_VERSION', '1.3.0' );
	}

	public static function onExtensionFunction() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( !\ExtensionRegistry::getInstance()->isLoaded( 'SemanticForms' ) ) {
			die( '<b>Error:</b> <a href="https://www.mediawiki.org/wiki/Extension:SemanticFormsSelect">Semantic Forms Selects</a> is a Semantic Forms extension. You need to install <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms">Semantic Forms</a> first.' );

		}

		$GLOBALS['sfgFormPrinter']->setInputTypeHook( 'SF_Select', '\SFS\SemanticFormsSelect::init', array() );
	}

}

1			<?php
2
3			class SemanticFormsSelectHooks {
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-25 17:27 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5			public static function onCallback() {
6			// Do not initialize more than once.
7			if ( defined( 'SFS_VERSION' ) ) {
8			return 1;
9			}
10
11			define( 'SFS_VERSION', '1.3.0' );
12			}
13
14			public static function onExtensionFunction() {
			0 ignored issues – show Coding Style introduced 2016-01-25 20:46 UTC by Report Bug Copy Issue Report `onExtensionFunction` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			if ( !\ExtensionRegistry::getInstance()->isLoaded( 'SemanticForms' ) ) {
16			die( '<b>Error:</b> <a href="https://www.mediawiki.org/wiki/Extension:SemanticFormsSelect">Semantic Forms Selects</a> is a Semantic Forms extension. You need to install <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms">Semantic Forms</a> first.' );
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-25 20:46 UTC by Report Bug Copy Issue Report The method `onExtensionFunction()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
17			}
18
19			$GLOBALS['sfgFormPrinter']->setInputTypeHook( 'SF_Select', '\SFS\SemanticFormsSelect::init', array() );
20			}
21
22			}

SemanticMediaWiki / SemanticFormsSelect

Pull Request — master (#8)

SemanticFormsSelectHooks::onExtensionFunction() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like