SemanticFormsSelectHooks::onSemanticFormsSelectSetup() - Code Metrics - Inspection of "added support for mapping properties ..." - SemanticMediaWiki/SemanticFormsSelect - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

unknown

created 2017-05-02 18:11 UTC

onSemanticFormsSelectSetup() A

↳ Parent: SemanticFormsSelectHooks

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1

<?php

/**
 * @license GNU GPL v2+
 * @since 3.0
 * @author: Alexander Gesinn
 */
class SemanticFormsSelectHooks {
namespace YourVendor;

class YourClass { }
	/**
	 * Register Page Forms Input Type
	 *
	 * This is attached to the MediaWiki 'ParserFirstCallInit' hook.
	 *
	 * @param $parser Parser
	 * @return bool
	 */
	public static function onSemanticFormsSelectSetup ( & $parser ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( !defined( 'PF_VERSION' ) ) {
			die( '<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.' );

		}

		if ( isset( $GLOBALS['wgPageFormsFormPrinter'] )) {
			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( '\SFS\SemanticFormsSelectInput' );
		}

		return true;
	}
}

1			<?php
2
3			/**
4			* @license GNU GPL v2+
5			* @since 3.0
6			* @author: Alexander Gesinn
7			*/
8			class SemanticFormsSelectHooks {
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			/**
10			* Register Page Forms Input Type
11			*
12			* This is attached to the MediaWiki 'ParserFirstCallInit' hook.
13			*
14			* @param $parser Parser
15			* @return bool
16			*/
17			public static function onSemanticFormsSelectSetup ( & $parser ) {
			0 ignored issues – show Unused Code introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report The parameter `$parser` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report `onSemanticFormsSelectSetup` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
18
19			if ( !defined( 'PF_VERSION' ) ) {
20			die( '<b>Error:</b><a href="https://github.com/SemanticMediaWiki/SemanticFormsSelect/">Semantic Forms Select</a> requires the <a href="https://www.mediawiki.org/wiki/Extension:PageForms">Page Forms</a> extension. Please install and activate this extension first.' );
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-02 18:16 UTC by Report Bug Copy Issue Report The method `onSemanticFormsSelectSetup()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
21			}
22
23			if ( isset( $GLOBALS['wgPageFormsFormPrinter'] )) {
24			$GLOBALS['wgPageFormsFormPrinter']->registerInputType( '\SFS\SemanticFormsSelectInput' );
25			}
26
27			return true;
28			}
29			}

SemanticMediaWiki / SemanticFormsSelect

Pull Request — master (#59)

onSemanticFormsSelectSetup() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like