TalkPageNumRevisionPropertyAnnotator::addAnnotation() - Code Metrics - Inspection of "2.0 refactoring" - SemanticMediaWiki/SemanticExtraSpecialProperties - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by mw

created 2017-06-04 10:05 UTC

addAnnotation() A

↳ Parent: TalkPageNumRevisionPropertyAnnotator

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	4
nop	2
dl	0
loc	18
ccs	13
cts	13
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDINumber as DINumber;
use SESP\PropertyAnnotator;
use SESP\AppFactory;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class TalkPageNumRevisionPropertyAnnotator implements PropertyAnnotator {

	/**
	 * Predefined property ID
	 */
	const PROP_ID = '___NTREV';

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === self::PROP_ID;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		$title = $semanticData->getSubject()->getTitle()->getTalkPage();

		$numRevisions = $this->getPageRevisions(
			$title->getArticleID()
		);

		$dataItem = null;

		if ( $title->exists() && $numRevisions > 0 ) {
			$dataItem = new DINumber( $numRevisions );
		}

		if ( $dataItem instanceof DataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

	private function getPageRevisions( $pageId ) {
		return $this->appFactory->getConnection()->estimateRowCount(

			"revision",
			"*",
			array( "rev_page" => $pageId )
		);
	}

}


1		<?php
2
3		namespace SESP\PropertyAnnotators;
4
5		use SMW\DIProperty;
6		use SMW\SemanticData;
7		use SMWDataItem as DataItem;
8		use SMWDINumber as DINumber;
9		use SESP\PropertyAnnotator;
10		use SESP\AppFactory;
11
12		/**
13		* @private
14		* @ingroup SESP
15		*
16		* @license GNU GPL v2+
17		* @since 2.0
18		*
19		* @author mwjames
20		*/
21		class TalkPageNumRevisionPropertyAnnotator implements PropertyAnnotator {
22
23		/**
24		* Predefined property ID
25		*/
26		const PROP_ID = '___NTREV';
27
28		/**
29		* @var AppFactory
30		*/
31		private $appFactory;
32
33		/**
34		* @since 2.0
35		*
36		* @param AppFactory $appFactory
37		*/
38	3	public function __construct( AppFactory $appFactory ) {
39	3	$this->appFactory = $appFactory;
40	3	}
41
42		/**
43		* @since 2.0
44		*
45		* {@inheritDoc}
46		*/
47	1	public function isAnnotatorFor( DIProperty $property ) {
48	1	return $property->getKey() === self::PROP_ID;
49		}
50
51		/**
52		* @since 2.0
53		*
54		* {@inheritDoc}
55		*/
56	1	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
57
58	1	$title = $semanticData->getSubject()->getTitle()->getTalkPage();
59
60	1	$numRevisions = $this->getPageRevisions(
61	1	$title->getArticleID()
62	1	);
63
64	1	$dataItem = null;
65
66	1	if ( $title->exists() && $numRevisions > 0 ) {
67	1	$dataItem = new DINumber( $numRevisions );
68	1	}
69
70	1	if ( $dataItem instanceof DataItem ) {
71	1	$semanticData->addPropertyObjectValue( $property, $dataItem );
72	1	}
73	1	}
74
75	1	private function getPageRevisions( $pageId ) {
76	1	return $this->appFactory->getConnection()->estimateRowCount(
		0 ignored issues – show Bug introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report The method `estimateRowCount` cannot be called on `$this->appFactory->getConnection()` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
77	1	"revision",
78	1	"*",
79	1	array( "rev_page" => $pageId )
80	1	);
81		}
82
83		}
84

SemanticMediaWiki / SemanticExtraSpecialProperties

Pull Request — master (#75)

addAnnotation() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like