SESP\ExtraPropertyAnnotator

Complexity

Total Complexity

17

Size/Duplication

Total Lines	179
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	21

Test Coverage

Coverage

85.14%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	addPropertyAnnotator()	0	3	1
A	__construct()	0	3	1
B	findPropertyAnnotator()	0	16	5
A	initDefaultPropertyAnnotators()	0	64	1
B	addAnnotation()	0	31	5
A	canAnnotate()	0	10	4

<?php

namespace SESP;

use SMW\DIProperty;
use SMW\SemanticData;
use SESP\PropertyAnnotators\NullPropertyAnnotator;
use SESP\PropertyAnnotators\CreatorPropertyAnnotator;
use SESP\PropertyAnnotators\PageViewsPropertyAnnotator;
use SESP\PropertyAnnotators\LocalPropertyAnnotator;
use SESP\PropertyAnnotators\UserRegistrationDatePropertyAnnotator;
use SESP\PropertyAnnotators\UserEditCountPropertyAnnotator;
use SESP\PropertyAnnotators\PageIDPropertyAnnotator;
use SESP\PropertyAnnotators\ShortUrlPropertyAnnotator;
use SESP\PropertyAnnotators\ExifPropertyAnnotator;
use SESP\PropertyAnnotators\RevisionIDPropertyAnnotator;
use SESP\PropertyAnnotators\PageNumRevisionPropertyAnnotator;
use SESP\PropertyAnnotators\TalkPageNumRevisionPropertyAnnotator;
use SESP\PropertyAnnotators\PageContributorsPropertyAnnotator;
use SESP\PropertyAnnotators\SubPagePropertyAnnotator;
use SESP\PropertyAnnotators\PageLengthPropertyAnnotator;

/**
 * @private
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class ExtraPropertyAnnotator {

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @var PropertyAnnotator[]
	 */
	private $propertyAnnotators = array();

	/**
	 * @var PropertyAnnotator
	 */
	private $localPropertyAnnotator;

	/**
	 * @var array
	 */
	private $options;

The property $options is not used and could be removed.

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * @param SemanticData $semanticData
	 */
	public function addAnnotation( SemanticData $semanticData ) {

		$time = microtime( true );

		if ( !$this->canAnnotate( $semanticData->getSubject() ) ) {
			return;
		}

		$propertyDefinitions = $this->appFactory->getPropertyDefinitions();

		foreach ( $this->appFactory->getOption( 'sespSpecialProperties', array() ) as $key ) {

array() is of type array, but the function expects a boolean.

			if ( !$propertyDefinitions->deepHas( $key, 'id' ) ) {
				continue;
			}

			$property = new DIProperty(
				$propertyDefinitions->deepGet( $key, 'id' )
			);

			if ( $propertyDefinitions->isLocalDef( $key ) ) {
				$this->localPropertyAnnotator->addAnnotation( $property, $semanticData );
			} else {
				$this->findPropertyAnnotator( $property )->addAnnotation( $property, $semanticData );
			}
		}

		$this->appFactory->getLogger()->info(
			__METHOD__ . ' (procTime in sec: '. ( microtime( true ) - $time ) . ')'
		);
	}

	/**
	 * @since 2.0
	 *
	 * @param DIProperty $property
	 *
	 * @return PropertyAnnotator
	 */
	public function findPropertyAnnotator( DIProperty $property ) {

		$key = $property->getKey();

		if ( $this->propertyAnnotators === array() ) {
			$this->initDefaultPropertyAnnotators();
		}

		if ( isset( $this->propertyAnnotators[$key] ) && is_callable( $this->propertyAnnotators[$key] ) ) {
			return call_user_func( $this->propertyAnnotators[$key], $this->appFactory );
		} elseif( isset( $this->propertyAnnotators[$key] ) ) {
			return $this->propertyAnnotators[$key];
		}

		return new NullPropertyAnnotator();
	}

	/**
	 * @since 2.0
	 *
	 * @param string $key
	 * @param Closure $callbak

There is no parameter named $callbak. Did you maybe mean $callback?

	 */
	public function addPropertyAnnotator( $key, Closure $callback ) {
		$this->propertyAnnotators[$key] = $callback;
	}

	private function canAnnotate( $subject ) {

		if ( $subject === null || $subject->getTitle() === null || $subject->getTitle()->isSpecialPage() ) {
			return false;
		}

		$this->initDefaultPropertyAnnotators();

		return true;
	}

	private function initDefaultPropertyAnnotators() {

		$this->localPropertyAnnotator = new LocalPropertyAnnotator(
			$this->appFactory
		);

		// Encapsulate each instance to avoid direct instantiation for unused
		// matches
		$this->propertyAnnotators = array(

It seems like array(\SESP\PropertyAnnotators\CreatorPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\CreatorPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\PageViewsPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\PageViewsPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\UserRegistrationDatePropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\UserRegistrationDatePropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\UserEditCountPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\UserEditCountPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\PageIDPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\PageIDPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\PageLengthPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\PageLengthPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\RevisionIDPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\RevisionIDPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\PageNumRevisionPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\PageNumRevisionPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\TalkPageNumRevisionPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\TalkPageNumRevisionPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\PageContributorsPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\PageContributorsPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\SubPagePropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\SubPagePropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\ShortUrlPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\ShortUrlPropertyAnnotator($appFactory); }, \SESP\PropertyAnnotators\ExifPropertyAnnotator::PROP_ID => function ($appFactory) { return new \SESP\PropertyAnnotators\ExifPropertyAnnotator($appFactory); }) of type array<string|integer,object<Closure>> is incompatible with the declared type array<integer,object<SESP\PropertyAnnotator>> of property $propertyAnnotators.

			CreatorPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new CreatorPropertyAnnotator( $appFactory );
			},

			PageViewsPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new PageViewsPropertyAnnotator( $appFactory );
			},

			UserRegistrationDatePropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new UserRegistrationDatePropertyAnnotator( $appFactory );
			},

			UserEditCountPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new UserEditCountPropertyAnnotator( $appFactory );
			},

			PageIDPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new PageIDPropertyAnnotator( $appFactory );
			},

			PageLengthPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new PageLengthPropertyAnnotator( $appFactory );
			},

			RevisionIDPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new RevisionIDPropertyAnnotator( $appFactory );
			},

			PageNumRevisionPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new PageNumRevisionPropertyAnnotator( $appFactory );
			},

			TalkPageNumRevisionPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new TalkPageNumRevisionPropertyAnnotator( $appFactory );
			},

			PageContributorsPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new PageContributorsPropertyAnnotator( $appFactory );
			},

			SubPagePropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new SubPagePropertyAnnotator( $appFactory );
			},

			ShortUrlPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new ShortUrlPropertyAnnotator( $appFactory );
			},

			ExifPropertyAnnotator::PROP_ID => function( $appFactory ) {
				return new ExifPropertyAnnotator( $appFactory );
			},

		);
	}

}