SESP\PropertyAnnotators\ApprovedStatusPropertyAnnotator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	setApprovedStatus()	0	3	1
A	isAnnotatorFor()	0	3	1
B	addAnnotation()	0	18	5
A	getDataItem()	0	3	1

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDIString as DIString;
use SESP\PropertyAnnotator;
use SESP\AppFactory;
use LogReader;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 */
class ApprovedStatusPropertyAnnotator implements PropertyAnnotator {

	/**
	 * Predefined property ID
	 */
	const PROP_ID = '___APPROVEDSTATUS';

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @var Integer|null
	 */
	private $approvedStatus;

	/**
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * @param string $approvedStatus
	 */
	public function setApprovedStatus( $approvedStatus ) {
		$this->approvedStatus = $approvedStatus;

It seems like $approvedStatus of type string is incompatible with the declared type integer|null of property $approvedStatus.

	}

	/**
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === self::PROP_ID;
	}

	public function getDataItem() {
		return new DIString( $this->approvedStatus );

The class SMWDIString has been deprecated with message: Will be removed after SMW 1.9; use SMWDIBlob instead

	}

	/**
	 * {@inheritDoc}
	 */
	public function addAnnotation(
		DIProperty $property, SemanticData $semanticData
	) {
		if ( $this->approvedStatus === null && class_exists( 'ApprovedRevs' ) ) {
			$logReader = $this->appFactory->newDatabaseLogReader(
				$semanticData->getSubject()->getTitle(), 'approval'
			);
			$this->approvedStatus = $logReader->getStatusOfLogEntry();

It seems like $logReader->getStatusOfLogEntry() of type string is incompatible with the declared type integer|null of property $approvedStatus.

		}

		if ( is_string( $this->approvedStatus ) && $this->approvedStatus !== "" ) {
			$semanticData->addPropertyObjectValue(
				$property, $this->getDataItem()
			);
		} else {
			$semanticData->removeProperty( $property );
		}
	}
}