SESP\LabelFetcher

Complexity

Total Complexity

13

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

95.35%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	setLabelCacheVersion()	0	3	1
A	getLabel()	0	3	1
B	getLabelsFrom()	0	32	6
A	matchLabel()	0	14	3

<?php

namespace SESP;

use Onoi\Cache\Cache;
use Onoi\Cache\NullCache;
use SMW\Message;

/**
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class LabelFetcher {

	/**
	 * Namespace of the cache instance
	 */
	const LABEL_CACHE_NAMESPACE = 'sesp:labels';

	/**
	 * @var Cache
	 */
	private $cache;

	/**
	 * @var string
	 */
	private $languageCode = 'en';

	/**
	 * @var string
	 */
	private $labelCacheVersion = 0;

	/**
	 * @since 2.0
	 *
	 * @param Cache|null $cache
	 * @param string $languageCode
	 */
	public function __construct( Cache $cache = null, $languageCode = 'en' ) {
		$this->cache = $cache;
		$this->languageCode = $languageCode;

		if ( $this->cache === null ) {
			$this->cache = new NullCache();
		}
	}

	/**
	 * @since 2.0
	 *
	 * @param integer|string $labelCacheVersion
	 */
	public function setLabelCacheVersion( $labelCacheVersion ) {
		$this->labelCacheVersion = $labelCacheVersion;

It seems like $labelCacheVersion can also be of type integer. However, the property $labelCacheVersion is declared as type string. Maybe add an additional type check?

	}

	/**
	 * @since 2.0
	 *
	 * @param string $key
	 *
	 * @return string
	 */
	public function getLabel( $key ) {
		return Message::get( $key, null, Message::USER_LANGUAGE );
	}

	/**
	 * @since 2.0
	 *
	 * @param PropertyDefinitions $propertyDefinitions
	 *
	 * @return array
	 */
	public function getLabelsFrom( PropertyDefinitions $propertyDefinitions ) {

		$hash = smwfCacheKey(
			self::LABEL_CACHE_NAMESPACE,
			array(

array($propertyDefinitions, $this->languageCode, $this->labelCacheVersion) is of type array<integer,object<SESP\PropertyDefinitions>|string,{"0":"object<SESP\\PropertyDefinitions>","1":"string","2":"string"}>, but the function expects a string.

				$propertyDefinitions,
				$this->languageCode,
				$this->labelCacheVersion
			)
		);

		if ( $this->labelCacheVersion !== false && ( $labels = $this->cache->fetch( $hash ) ) !== false ) {
			return $labels;
		}

		$labels = array();
		$exifDefinitions = array();

$exifDefinitions is not used, you could remove the assignment.

		foreach ( $propertyDefinitions as $key => $definition ) {
			$this->matchLabel( $labels, $definition );
		}

		foreach ( $propertyDefinitions->safeGet( '_EXIF', array() ) as $key => $definition ) {
			$this->matchLabel( $labels, $definition );
		}

		if ( $labels !== array() ) {
			$this->cache->save( $hash, $labels, 3600 * 24 );
		}

		return $labels;
	}

	private function matchLabel( &$labels, $definition ) {

		if ( !isset( $definition['id'] ) ) {
			return;
		}

		$alias = 'sesp-property-unknown-label';

		if ( isset( $definition['alias'] ) ) {
			$alias = $definition['alias'];
		}

		$labels[$definition['id']] = Message::get( $alias, null, $this->languageCode );
	}

}