UserRegistrationDatePropertyAnnotator::addAnnotation() - Code Metrics - Inspection of "2.0 refactoring" - SemanticMediaWiki/SemanticExtraSpecialProperties - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by mw

created 2017-06-03 14:12 UTC

addAnnotation() B

↳ Parent: UserRegistrationDatePropertyAnnotator

Complexity

Conditions	4
Paths	5

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	18
nc	5
nop	2
dl	0
loc	30
rs	8.5806
c	0
b	0
f	0
ccs	0
cts	23
cp	0
crap	20

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDITime as DITime;
use SESP\PropertyAnnotator;
use SESP\AppFactory;
use User;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class UserRegistrationDatePropertyAnnotator implements PropertyAnnotator {

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === '___USERREG' ;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		$title = $semanticData->getSubject()->getTitle();

		if ( !$title->inNamespace( NS_USER ) ) {
			return;
		}

		$user = $this->appFactory->newUserFromTitle( $title );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		$dataItem = null;

		if ( $user instanceof User ) {


			$timestamp = wfTimestamp( TS_ISO_8601, $user->getRegistration() );
			$date = new \DateTime( $timestamp );

			$dataItem = new DITime(
				DITime::CM_GREGORIAN,
				$date->format('Y'),
				$date->format('m'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$date->format('d'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$date->format('H'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				$date->format('i')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			);
		}

		if ( $dataItem instanceof DataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

}


1			<?php
2
3			namespace SESP\PropertyAnnotators;
4
5			use SMW\DIProperty;
6			use SMW\SemanticData;
7			use SMWDataItem as DataItem;
8			use SMWDITime as DITime;
9			use SESP\PropertyAnnotator;
10			use SESP\AppFactory;
11			use User;
12
13			/**
14			* @private
15			* @ingroup SESP
16			*
17			* @license GNU GPL v2+
18			* @since 2.0
19			*
20			* @author mwjames
21			*/
22			class UserRegistrationDatePropertyAnnotator implements PropertyAnnotator {
23
24			/**
25			* @var AppFactory
26			*/
27			private $appFactory;
28
29			/**
30			* @since 2.0
31			*
32			* @param AppFactory $appFactory
33			*/
34			public function __construct( AppFactory $appFactory ) {
35			$this->appFactory = $appFactory;
36			}
37
38			/**
39			* @since 2.0
40			*
41			* {@inheritDoc}
42			*/
43			public function isAnnotatorFor( DIProperty $property ) {
44			return $property->getKey() === '___USERREG' ;
45			}
46
47			/**
48			* @since 2.0
49			*
50			* {@inheritDoc}
51			*/
52			public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
53
54			$title = $semanticData->getSubject()->getTitle();
55
56			if ( !$title->inNamespace( NS_USER ) ) {
57			return;
58			}
59
60			$user = $this->appFactory->newUserFromTitle( $title );
			0 ignored issues – show Bug introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report It seems like `$title` defined by `$semanticData->getSubject()->getTitle()` on line `54` can be `null`; however, `SESP\AppFactory::newUserFromTitle()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
61			$dataItem = null;
62
63			if ( $user instanceof User ) {
			0 ignored issues – show Bug introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report The class `User` does not exist. Is this class maybe located in a folder that is not analyzed, or in a newer version of your dependencies than listed in your composer.lock/composer.json? Loading history...
64
65			$timestamp = wfTimestamp( TS_ISO_8601, $user->getRegistration() );
66			$date = new \DateTime( $timestamp );
67
68			$dataItem = new DITime(
69			DITime::CM_GREGORIAN,
70			$date->format('Y'),
71			$date->format('m'),
			0 ignored issues – show Documentation introduced 2015-12-04 20:50 UTC by Report Bug Copy Issue Report `$date->format('m')` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72			$date->format('d'),
			0 ignored issues – show Documentation introduced 2015-12-04 20:50 UTC by Report Bug Copy Issue Report `$date->format('d')` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			$date->format('H'),
			0 ignored issues – show Documentation introduced 2015-12-04 20:50 UTC by Report Bug Copy Issue Report `$date->format('H')` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			$date->format('i')
			0 ignored issues – show Documentation introduced 2015-12-04 20:50 UTC by Report Bug Copy Issue Report `$date->format('i')` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75			);
76			}
77
78			if ( $dataItem instanceof DataItem ) {
79			$semanticData->addPropertyObjectValue( $property, $dataItem );
80			}
81			}
82
83			}
84

SemanticMediaWiki / SemanticExtraSpecialProperties

Pull Request — master (#75)

addAnnotation() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like