TalkPageNumRevisionPropertyAnnotator::addAnnotation() - Code Metrics - Inspection of "2.0 refactoring" - SemanticMediaWiki/SemanticExtraSpecialProperties - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by mw

created 2017-06-03 14:12 UTC

addAnnotation() A

↳ Parent: TalkPageNumRevisionPropertyAnnotator

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	4
nop	2
dl	0
loc	18
rs	9.2
c	0
b	0
f	0
ccs	0
cts	13
cp	0
crap	20

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDINumber as DINumber;
use SESP\PropertyAnnotator;
use SESP\AppFactory;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class TalkPageNumRevisionPropertyAnnotator implements PropertyAnnotator {

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === '___NTREV' ;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		$title = $semanticData->getSubject()->getTitle()->getTalkPage();

		$numRevisions = $this->getPageRevisions(
			$title->getArticleID()
		);

		$dataItem = null;

		if ( $title->exists() && $numRevisions > 0 ) {
			$dataItem = new DINumber( $numRevisions );
		}

		if ( $dataItem instanceof DataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

	private function getPageRevisions( $pageId ) {
		return $this->appFactory->getConnection()->estimateRowCount(

			"revision",
			"*",
			array( "rev_page" => $pageId )
		);
	}

}


1			<?php
2
3			namespace SESP\PropertyAnnotators;
4
5			use SMW\DIProperty;
6			use SMW\SemanticData;
7			use SMWDataItem as DataItem;
8			use SMWDINumber as DINumber;
9			use SESP\PropertyAnnotator;
10			use SESP\AppFactory;
11
12			/**
13			* @private
14			* @ingroup SESP
15			*
16			* @license GNU GPL v2+
17			* @since 2.0
18			*
19			* @author mwjames
20			*/
21			class TalkPageNumRevisionPropertyAnnotator implements PropertyAnnotator {
22
23			/**
24			* @var AppFactory
25			*/
26			private $appFactory;
27
28			/**
29			* @since 2.0
30			*
31			* @param AppFactory $appFactory
32			*/
33			public function __construct( AppFactory $appFactory ) {
34			$this->appFactory = $appFactory;
35			}
36
37			/**
38			* @since 2.0
39			*
40			* {@inheritDoc}
41			*/
42			public function isAnnotatorFor( DIProperty $property ) {
43			return $property->getKey() === '___NTREV' ;
44			}
45
46			/**
47			* @since 2.0
48			*
49			* {@inheritDoc}
50			*/
51			public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
52
53			$title = $semanticData->getSubject()->getTitle()->getTalkPage();
54
55			$numRevisions = $this->getPageRevisions(
56			$title->getArticleID()
57			);
58
59			$dataItem = null;
60
61			if ( $title->exists() && $numRevisions > 0 ) {
62			$dataItem = new DINumber( $numRevisions );
63			}
64
65			if ( $dataItem instanceof DataItem ) {
66			$semanticData->addPropertyObjectValue( $property, $dataItem );
67			}
68			}
69
70			private function getPageRevisions( $pageId ) {
71			return $this->appFactory->getConnection()->estimateRowCount(
			0 ignored issues – show Bug introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report The method `estimateRowCount` cannot be called on `$this->appFactory->getConnection()` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
72			"revision",
73			"*",
74			array( "rev_page" => $pageId )
75			);
76			}
77
78			}
79

SemanticMediaWiki / SemanticExtraSpecialProperties

Pull Request — master (#75)

addAnnotation() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like